This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch 1.x in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit 70ed92d8147fd7d171dc52e4e77b0804967262cf Author: Gary Gregory <[email protected]> AuthorDate: Sun Feb 8 09:46:45 2026 -0500 Internal refactoring. Don't let `repository` be initialized to null. --- .../java/org/apache/commons/fileupload/disk/DiskFileItem.java | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java index e85b2286..f7d5e53a 100644 --- a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java +++ b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java @@ -138,7 +138,7 @@ public class DiskFileItem implements FileItem { private boolean formField; /** - * The directory in which uploaded files will be stored, if stored on disk. + * The directory in which uploaded files will be stored, if stored on disk, never {@code null}. */ private final File repository; @@ -177,7 +177,7 @@ public class DiskFileItem implements FileItem { this.formField = isFormField; this.fileName = fileName; this.sizeThreshold = sizeThreshold; - this.repository = repository; + this.repository = repository != null ? repository : FileUtils.getTempDirectory(); } /** @@ -433,12 +433,7 @@ public class DiskFileItem implements FileItem { */ protected File getTempFile() { if (tempFile == null) { - File tempDir = repository; - if (tempDir == null) { - tempDir = FileUtils.getTempDirectory(); - } - final String tempFileName = String.format("upload_%s_%s.tmp", UID, nextUniqueId()); - tempFile = new File(tempDir, tempFileName); + tempFile = new File(repository, String.format("upload_%s_%s.tmp", UID, nextUniqueId())); } return tempFile; }
