This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
The following commit(s) were added to refs/heads/master by this push:
new bbda7c1b Bump org.apache.commons:commons-parent from 96 to 97.
bbda7c1b is described below
commit bbda7c1bd20c76c1b00a5cb62c63c4a20df295f7
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Feb 27 21:14:50 2026 -0500
Bump org.apache.commons:commons-parent from 96 to 97.
Fix PMD UnconditionalIfStatement
---
pom.xml | 2 +-
.../java/org/apache/commons/imaging/formats/gif/GifImageParser.java | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 24febd15..961b4003 100644
--- a/pom.xml
+++ b/pom.xml
@@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.commons</groupId>
<artifactId>commons-parent</artifactId>
- <version>96</version>
+ <version>97</version>
</parent>
<artifactId>commons-imaging</artifactId>
<name>Apache Commons Imaging</name>
diff --git
a/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
b/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
index ae95e254..cb8c57a6 100644
--- a/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
@@ -84,6 +84,8 @@ public class GifImageParser extends
AbstractImageParser<GifImagingParameters> im
0x50, // P
};
+ private static final boolean LOCAL_COLOR_TABLE_FLAG = true;
+
// Made internal for testability.
static DisposalMethod createDisposalMethodFromIntValue(final int value)
throws ImagingException {
switch (value) {
@@ -959,7 +961,6 @@ public class GifImageParser extends
AbstractImageParser<GifImagingParameters> im
bos.write2Bytes(height); // Image Height
{
- final boolean localColorTableFlag = true;
// boolean LocalColorTableFlag = false;
final boolean interlaceFlag = false;
final boolean sortFlag = false;
@@ -968,7 +969,7 @@ public class GifImageParser extends
AbstractImageParser<GifImagingParameters> im
// int SizeOfLocalColorTable = 0;
final int packedFields;
- if (localColorTableFlag) {
+ if (LOCAL_COLOR_TABLE_FLAG) {
packedFields = LOCAL_COLOR_TABLE_FLAG_MASK |
(interlaceFlag ? INTERLACE_FLAG_MASK : 0) | (sortFlag ? SORT_FLAG_MASK : 0)
| 7 & sizeOfLocalColorTable;
} else {