(commons-validator) branch master updated: Use @ParameterizedTest and add more CUSIP fixtures

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new 6d9da924 Use @ParameterizedTest and add more CUSIP fixtures
6d9da924 is described below

commit 6d9da924261ca96ea7cb28db7418dddcc5dd4ee6
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Jun 4 11:10:47 2026 -0400

    Use @ParameterizedTest and add more CUSIP fixtures
---
 .../routines/checkdigit/CUSIPCheckDigitTest.java   | 26 +++++++++-------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
 
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
index 78afa057..737a2cb5 100644
--- 
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
+++ 
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
@@ -14,23 +14,21 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.apache.commons.validator.routines.checkdigit;
 
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 /**
  * CUSIP Check Digit Test.
  */
 class CUSIPCheckDigitTest extends AbstractCheckDigitTest {
 
-    private static final String[] INVALID_CHECK_DIGITS = { "DUS0421CW", 
"DUS0421CN", "DUS0421CE" };
-
-    private static final String[] VALID_CHECK_DIGITS = { "DUS0421C5" };
-
     /**
      * Sets up routine & valid codes.
      */
@@ -41,17 +39,15 @@ class CUSIPCheckDigitTest extends AbstractCheckDigitTest {
         invalid = new String[] { "0378#3100" };
     }
 
-    @Test
-    void testValidator336InvalidCheckDigits() {
-        for (final String invalidCheckDigit : INVALID_CHECK_DIGITS) {
-            assertFalse(routine.isValid(invalidCheckDigit), "Should fail: " + 
invalidCheckDigit);
-        }
+    @ParameterizedTest
+    @ValueSource(strings = { "DUS0421CW", "DUS0421CN", "DUS0421CE" })
+    void testValidator336InvalidCheckDigits(final String invalidCheckDigit) {
+        assertFalse(routine.isValid(invalidCheckDigit), "Should fail: " + 
invalidCheckDigit);
     }
 
-    @Test
-    void testValidator336ValidCheckDigits() {
-        for (final String validCheckDigit : VALID_CHECK_DIGITS) {
-            assertTrue(routine.isValid(validCheckDigit), "Should fail: " + 
validCheckDigit);
-        }
+    @ParameterizedTest
+    @ValueSource(strings = { "DUS0421C5", "037833100", "17275R102", 
"38259P508", "594918104", "EJ7125481" })
+    void testValidator336ValidCheckDigits(final String validCheckDigit) {
+        assertTrue(routine.isValid(validCheckDigit), "Should fail: " + 
validCheckDigit);
     }
 }