This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
The following commit(s) were added to refs/heads/master by this push:
new c4e9d892 Flip null test
c4e9d892 is described below
commit c4e9d892888c31d2f412caa13ac8c23661915ca0
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jul 5 09:40:37 2026 -0400
Flip null test
---
src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java | 2 +-
.../apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java | 2 +-
.../apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java | 4 ++--
.../org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git
a/src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
b/src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
index 360c5b3e..95233888 100644
--- a/src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
+++ b/src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
@@ -118,7 +118,7 @@ public class NTFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
f.setSize(0);
} else {
f.setType(FTPFile.FILE_TYPE);
- if (null != size) {
+ if (size != null) {
f.setSize(Long.parseLong(size));
}
}
diff --git
a/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
b/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
index 22bc2adf..32cbcbbd 100644
---
a/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
+++
b/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
@@ -145,7 +145,7 @@ public abstract class RegexFTPFileEntryParserImpl extends
FTPFileEntryParserImpl
if (_matcher_.matches()) {
result = _matcher_.toMatchResult();
}
- return null != result;
+ return result != null;
}
/**
diff --git
a/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
b/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
index 4de02a24..84af7658 100644
---
a/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
+++
b/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
@@ -100,7 +100,7 @@ public class VMSVersioningFTPEntryParser extends
VMSFTPEntryParser {
final String version = result.group(2);
final Integer nv = Integer.valueOf(version);
final Integer existing = existingEntries.get(name);
- if (null != existing && nv.intValue() < existing.intValue()) {
+ if (existing != null && nv.intValue() < existing.intValue()) {
iter.remove(); // removes older version from original list.
continue;
}
@@ -122,7 +122,7 @@ public class VMSVersioningFTPEntryParser extends
VMSFTPEntryParser {
final String version = result.group(2);
final int nv = Integer.parseInt(version);
final Integer existing = existingEntries.get(name);
- if (null != existing && nv < existing.intValue()) {
+ if (existing != null && nv < existing.intValue()) {
iter.remove(); // removes older version from original list.
}
}
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
index 024734d2..f91aad5d 100644
---
a/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
+++
b/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
@@ -91,7 +91,7 @@ class UnixFTPEntryParserTest extends AbstractFTPParseTest {
@Override
protected void doAdditionalGoodTests(final String test, final FTPFile f) {
final String link = f.getLink();
- if (null != link) {
+ if (link != null) {
final int linklen = link.length();
if (linklen > 0) {
assertEquals(link, test.substring(test.length() - linklen));