This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git


The following commit(s) were added to refs/heads/master by this push:
     new bf0c0d5c Flip null test
bf0c0d5c is described below

commit bf0c0d5cce5b2f25e97612c1603428ec2092ceeb
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jul 5 10:00:48 2026 -0400

    Flip null test
---
 src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java          | 2 +-
 .../java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java 
b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
index 886b3758..7957c55e 100644
--- a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
+++ b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
@@ -220,7 +220,7 @@ final class EvictionTimer {
      * @param period    Time in milliseconds between executions.
      */
     static synchronized void schedule(final BaseGenericObjectPool<?, 
?>.Evictor pool, final Duration delay, final Duration period) {
-        if (null == executor) {
+        if (executor == null) {
             executor = new ScheduledThreadPoolExecutor(1, new 
EvictorThreadFactory());
             executor.setRemoveOnCancelPolicy(true);
             executor.scheduleAtFixedRate(new Reaper(), delay.toMillis(), 
period.toMillis(), TimeUnit.MILLISECONDS);
diff --git 
a/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java 
b/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java
index e8e14d3f..cc53e293 100644
--- a/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java
+++ b/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java
@@ -176,7 +176,7 @@ public class SoftReferenceObjectPool<T, E extends 
Exception> extends BaseObjectP
         T obj = null;
         boolean newlyCreated = false;
         PooledSoftReference<T> ref = null;
-        while (null == obj) {
+        while (obj == null) {
             if (idleReferences.isEmpty()) {
                 newlyCreated = true;
                 obj = factory.makeObject().getObject();

Reply via email to