This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit 39e57f65030ca1bbf580cddcd66a0ffb76bd1650 Author: Gary Gregory <[email protected]> AuthorDate: Sat Jul 11 07:41:58 2026 -0400 Import once instead of using FQCN over and over. --- .../commons/validator/GenericTypeValidator.java | 4 ++-- .../org/apache/commons/validator/ISBNValidator.java | 19 ++++++------------- .../apache/commons/validator/ValidatorException.java | 4 ++-- .../commons/validator/routines/DomainValidator.java | 5 +++-- .../validator/routines/checkdigit/CheckDigit.java | 3 ++- 5 files changed, 15 insertions(+), 20 deletions(-) diff --git a/src/main/java/org/apache/commons/validator/GenericTypeValidator.java b/src/main/java/org/apache/commons/validator/GenericTypeValidator.java index 2c62e7da..24e541fc 100644 --- a/src/main/java/org/apache/commons/validator/GenericTypeValidator.java +++ b/src/main/java/org/apache/commons/validator/GenericTypeValidator.java @@ -92,7 +92,7 @@ public class GenericTypeValidator implements Serializable { * Checks if the field is a valid date. * * <p> - * The {@link Locale} is used with {@link java.text.DateFormat}. The {@link java.text.DateFormat#setLenient(boolean)} method is set to {@code false} for + * The {@link Locale} is used with {@link DateFormat}. The {@link java.text.DateFormat#setLenient(boolean)} method is set to {@code false} for * all. * </p> * @@ -132,7 +132,7 @@ public class GenericTypeValidator implements Serializable { * Checks if the field is a valid date. * * <p> - * The pattern is used with {@link java.text.SimpleDateFormat}. If strict is true, then the length will be checked so '2/12/1999' will not pass validation + * The pattern is used with {@link SimpleDateFormat}. If strict is true, then the length will be checked so '2/12/1999' will not pass validation * with the format 'MM/dd/yyyy' because the month isn't two digits. The {@link java.text.SimpleDateFormat#setLenient(boolean)} method is set to * {@code false} for all. * </p> diff --git a/src/main/java/org/apache/commons/validator/ISBNValidator.java b/src/main/java/org/apache/commons/validator/ISBNValidator.java index 4adaa2d2..68b579ec 100644 --- a/src/main/java/org/apache/commons/validator/ISBNValidator.java +++ b/src/main/java/org/apache/commons/validator/ISBNValidator.java @@ -14,16 +14,13 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.apache.commons.validator; /** - * A class for validating 10 digit ISBN codes. - * Based on this - * <a href="https://www.isbn.org/standards/home/isbn/international/html/usm4.htm";> - * algorithm</a> + * A class for validating 10 digit ISBN codes. Based on this <a href="https://www.isbn.org/standards/home/isbn/international/html/usm4.htm";> algorithm</a> * <p> - * <strong>NOTE:</strong> This has been replaced by the new - * {@link org.apache.commons.validator.routines.ISBNValidator}. + * <strong>NOTE:</strong> This has been replaced by the new {@link ISBNValidator}. * </p> * * @since 1.2.0 @@ -39,17 +36,13 @@ public class ISBNValidator { } /** - * If the ISBN is formatted with space or dash separators its format is - * validated. Then the digits in the number are weighted, summed, and - * divided by 11 according to the ISBN algorithm. If the result is zero, - * the ISBN is valid. This method accepts formatted or raw ISBN codes. + * If the ISBN is formatted with space or dash separators its format is validated. Then the digits in the number are weighted, summed, and divided by 11 + * according to the ISBN algorithm. If the result is zero, the ISBN is valid. This method accepts formatted or raw ISBN codes. * - * @param isbn Candidate ISBN number to be validated. {@code null} is - * considered invalid. + * @param isbn Candidate ISBN number to be validated. {@code null} is considered invalid. * @return true if the string is a valid ISBN code. */ public boolean isValid(final String isbn) { return org.apache.commons.validator.routines.ISBNValidator.getInstance().isValidISBN10(isbn); } - } diff --git a/src/main/java/org/apache/commons/validator/ValidatorException.java b/src/main/java/org/apache/commons/validator/ValidatorException.java index ebcbf3bb..dccad070 100644 --- a/src/main/java/org/apache/commons/validator/ValidatorException.java +++ b/src/main/java/org/apache/commons/validator/ValidatorException.java @@ -17,8 +17,8 @@ package org.apache.commons.validator; +import java.security.PrivilegedActionException; import java.util.IllegalFormatException; - /** * The base exception for the Validator Framework. All other {@code Exception}s thrown during calls to {@code Validator.validate()} are considered errors. */ @@ -71,7 +71,7 @@ public class ValidatorException extends Exception { /** * Constructs a new exception with the specified cause and a detail message of {@code (cause==null ? null : cause.toString())} (which typically contains the * class and detail message of {@code cause}). This constructor is useful for exceptions that are little more than wrappers for other throwables (for - * example, {@link java.security.PrivilegedActionException}). + * example, {@link PrivilegedActionException}). * * @param cause the cause (which is saved for later retrieval by the {@link #getCause()} method). (A {@code null} value is permitted, and indicates that the * cause is nonexistent or unknown.) diff --git a/src/main/java/org/apache/commons/validator/routines/DomainValidator.java b/src/main/java/org/apache/commons/validator/routines/DomainValidator.java index cbbacc99..0b097ed9 100644 --- a/src/main/java/org/apache/commons/validator/routines/DomainValidator.java +++ b/src/main/java/org/apache/commons/validator/routines/DomainValidator.java @@ -18,6 +18,7 @@ package org.apache.commons.validator.routines; import java.io.Serializable; import java.net.IDN; +import java.net.InetAddress; import java.util.Arrays; import java.util.List; import java.util.Locale; @@ -56,7 +57,7 @@ import java.util.Locale; * <p> * (<strong>NOTE</strong>: This class does not provide IP address lookup for domain names or * methods to ensure that a given domain name matches a specific IP; see - * {@link java.net.InetAddress} for that functionality.) + * {@link InetAddress} for that functionality.) * </p> * * @since 1.4 @@ -1985,7 +1986,7 @@ public class DomainValidator implements Serializable { * To clear an override array, provide an empty array. * </p> * - * @param table the table to update, see {@link DomainValidator.ArrayType} Must be one of the following + * @param table the table to update, see {@link ArrayType} Must be one of the following * <ul> * <li>COUNTRY_CODE_MINUS</li> * <li>COUNTRY_CODE_PLUS</li> diff --git a/src/main/java/org/apache/commons/validator/routines/checkdigit/CheckDigit.java b/src/main/java/org/apache/commons/validator/routines/checkdigit/CheckDigit.java index c5fa233c..3d0b3886 100644 --- a/src/main/java/org/apache/commons/validator/routines/checkdigit/CheckDigit.java +++ b/src/main/java/org/apache/commons/validator/routines/checkdigit/CheckDigit.java @@ -17,6 +17,7 @@ package org.apache.commons.validator.routines.checkdigit; import org.apache.commons.validator.routines.CodeValidator; +import org.apache.commons.validator.routines.ISBNValidator; /** * <strong>Check Digit</strong> calculation and validation. @@ -32,7 +33,7 @@ import org.apache.commons.validator.routines.CodeValidator; * Although Commons Validator is primarily concerned with validation, * {@link CheckDigit} also defines behavior for calculating/generating check * digits, since it makes sense that users will want to (re-)use the - * same logic for both. The {@link org.apache.commons.validator.routines.ISBNValidator} + * same logic for both. The {@link ISBNValidator} * makes specific use of this feature by providing the facility to validate ISBN-10 codes * and then convert them to the new ISBN-13 standard. * </p>
