This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new 176b03b7 Javadoc
176b03b7 is described below
commit 176b03b78b0916ef8abfe9a64128f6ec057032cb
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Jul 11 09:08:29 2026 -0400
Javadoc
---
.../org/apache/commons/dbcp2/BasicDataSource.java | 6 ++---
.../apache/commons/dbcp2/ConnectionFactory.java | 2 +-
.../commons/dbcp2/ConnectionFactoryFactory.java | 2 +-
.../apache/commons/dbcp2/DelegatingResultSet.java | 4 +--
.../java/org/apache/commons/dbcp2/PStmtKey.java | 2 +-
.../commons/dbcp2/PoolableConnectionFactory.java | 2 +-
.../apache/commons/dbcp2/PoolingConnection.java | 22 ++++++++--------
src/main/java/org/apache/commons/dbcp2/Utils.java | 8 +++---
.../commons/dbcp2/cpdsadapter/ConnectionImpl.java | 6 ++---
.../dbcp2/cpdsadapter/PooledConnectionImpl.java | 30 +++++++++++-----------
.../datasources/AbstractConnectionFactory.java | 2 +-
.../commons/dbcp2/managed/XAConnectionFactory.java | 2 +-
.../org/apache/commons/dbcp2/StackMessageLog.java | 2 +-
.../apache/commons/dbcp2/TestConnectionPool.java | 2 +-
14 files changed, 46 insertions(+), 46 deletions(-)
diff --git a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
index 1ff5d34b..8db5b582 100644
--- a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
@@ -592,7 +592,7 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
* @param factory the object factory
* @param poolConfig the object pool configuration
* @param abandonedConfig the abandoned objects configuration
- * @return a non-null instance
+ * @return A non-null instance
*/
protected GenericObjectPool<PoolableConnection> createObjectPool(final
PoolableConnectionFactory factory,
final GenericObjectPoolConfig<PoolableConnection> poolConfig,
final AbandonedConfig abandonedConfig) {
@@ -708,7 +708,7 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
* Creates (if necessary) and return a connection to the database.
*
* @throws SQLException if a database access error occurs
- * @return a database connection
+ * @return A database connection
*/
@Override
public Connection getConnection() throws SQLException {
@@ -872,7 +872,7 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
* trigger a disconnection even if they match other disconnection criteria.
* </p>
*
- * @return a set of SQL State codes that should be ignored for
disconnection checks, or an empty set if none have been specified.
+ * @return A set of SQL State codes that should be ignored for
disconnection checks, or an empty set if none have been specified.
* @since 2.13.0
*/
public Set<String> getDisconnectionIgnoreSqlCodes() {
diff --git a/src/main/java/org/apache/commons/dbcp2/ConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/ConnectionFactory.java
index 50fa9fd7..13fd0149 100644
--- a/src/main/java/org/apache/commons/dbcp2/ConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/ConnectionFactory.java
@@ -29,7 +29,7 @@ public interface ConnectionFactory {
/**
* Create a new {@link Connection} in an implementation specific fashion.
*
- * @return a new {@link Connection}
+ * @return A new {@link Connection}
* @throws SQLException
* if a database error occurs creating the connection
*/
diff --git
a/src/main/java/org/apache/commons/dbcp2/ConnectionFactoryFactory.java
b/src/main/java/org/apache/commons/dbcp2/ConnectionFactoryFactory.java
index e7d8260f..a0122997 100644
--- a/src/main/java/org/apache/commons/dbcp2/ConnectionFactoryFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/ConnectionFactoryFactory.java
@@ -33,7 +33,7 @@ final class ConnectionFactoryFactory {
*
* @param basicDataSource Configures creation.
* @param driver The JDBC driver.
- * @return a new {@link DriverConnectionFactory} allowing for a {@link
BasicDataSource#getDriverClassName()}
+ * @return A new {@link DriverConnectionFactory} allowing for a {@link
BasicDataSource#getDriverClassName()}
* override.
* @throws SQLException Thrown when instantiation fails.
*/
diff --git a/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java
b/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java
index 2f15f489..c900f63c 100644
--- a/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java
+++ b/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java
@@ -61,7 +61,7 @@ public final class DelegatingResultSet extends AbandonedTrace
implements ResultS
* The Connection which created the ResultSet.
* @param resultSet
* The ResultSet to wrap.
- * @return a new delegate.
+ * @return A new delegate.
*/
public static ResultSet wrapResultSet(final Connection connection, final
ResultSet resultSet) {
if (resultSet == null) {
@@ -77,7 +77,7 @@ public final class DelegatingResultSet extends AbandonedTrace
implements ResultS
* The Statement which created the ResultSet.
* @param resultSet
* The ResultSet to wrap.
- * @return a new delegate.
+ * @return A new delegate.
*/
public static ResultSet wrapResultSet(final Statement statement, final
ResultSet resultSet) {
if (resultSet == null) {
diff --git a/src/main/java/org/apache/commons/dbcp2/PStmtKey.java
b/src/main/java/org/apache/commons/dbcp2/PStmtKey.java
index 733f6297..52ea9a2d 100644
--- a/src/main/java/org/apache/commons/dbcp2/PStmtKey.java
+++ b/src/main/java/org/apache/commons/dbcp2/PStmtKey.java
@@ -539,7 +539,7 @@ public class PStmtKey {
* Gets a flag indicating whether auto-generated keys should be returned;
one of {@link Statement#RETURN_GENERATED_KEYS}
* or {@link Statement#NO_GENERATED_KEYS}.
*
- * @return a flag indicating whether auto-generated keys should be
returned.
+ * @return A flag indicating whether auto-generated keys should be
returned.
*/
public Integer getAutoGeneratedKeys() {
return autoGeneratedKeys;
diff --git
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index f7027abe..5b47a010 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -301,7 +301,7 @@ public class PoolableConnectionFactory implements
PooledObjectFactory<PoolableCo
* being treated as fatal even if they match the typical disconnection
criteria.
* </p>
*
- * @return a {@link Collection} of SQL State codes that should be ignored
for disconnection checks.
+ * @return A {@link Collection} of SQL State codes that should be ignored
for disconnection checks.
* @since 2.13.0
*/
public Collection<String> getDisconnectionIgnoreSqlCodes() {
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
b/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
index 13859323..9db81d6d 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
@@ -407,7 +407,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
*
* @param key
* a {@link PStmtKey} for the given arguments
- * @return a {@link PoolableCallableStatement}
+ * @return A {@link PoolableCallableStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -420,7 +420,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
*
* @param sql
* the SQL string used to define the CallableStatement
- * @return a {@link PoolableCallableStatement}
+ * @return A {@link PoolableCallableStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -438,7 +438,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* result set type
* @param resultSetConcurrency
* result set concurrency
- * @return a {@link PoolableCallableStatement}
+ * @return A {@link PoolableCallableStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -459,7 +459,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* result set concurrency
* @param resultSetHoldability
* result set holdability
- * @return a {@link PoolableCallableStatement}
+ * @return A {@link PoolableCallableStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -475,7 +475,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
*
* @param key
* a {@link PStmtKey} for the given arguments
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -499,7 +499,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
*
* @param sql
* the SQL string used to define the PreparedStatement
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -516,7 +516,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* @param autoGeneratedKeys
* A flag indicating whether auto-generated keys should be
returned; one of
* {@link Statement#RETURN_GENERATED_KEYS} or {@link
Statement#NO_GENERATED_KEYS}.
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -534,7 +534,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* result set type
* @param resultSetConcurrency
* result set concurrency
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -555,7 +555,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* result set concurrency
* @param resultSetHoldability
* result set holdability
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -573,7 +573,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* @param columnIndexes
* An array of column indexes indicating the columns that
should be returned from the inserted row or
* rows.
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
@@ -589,7 +589,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* the SQL string used to define the PreparedStatement
* @param columnNames
* column names
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException
* Wraps an underlying exception.
*/
diff --git a/src/main/java/org/apache/commons/dbcp2/Utils.java
b/src/main/java/org/apache/commons/dbcp2/Utils.java
index 9b771fbe..dd3cd502 100644
--- a/src/main/java/org/apache/commons/dbcp2/Utils.java
+++ b/src/main/java/org/apache/commons/dbcp2/Utils.java
@@ -108,7 +108,7 @@ public final class Utils {
* Clones the given char[] if not null.
*
* @param value may be null.
- * @return a cloned char[] or null.
+ * @return A cloned char[] or null.
*/
public static char[] clone(final char[] value) {
return value == null ? null : value.clone();
@@ -118,7 +118,7 @@ public final class Utils {
* Clones the given {@link Properties} without the standard "user" or
"password" entries.
*
* @param properties may be null
- * @return a clone of the input without the standard "user" or "password"
entries.
+ * @return A clone of the input without the standard "user" or "password"
entries.
* @since 2.8.0
*/
public static Properties cloneWithoutCredentials(final Properties
properties) {
@@ -260,7 +260,7 @@ public final class Utils {
* Converts the given String to a char[].
*
* @param value may be null.
- * @return a char[] or null.
+ * @return A char[] or null.
*/
public static char[] toCharArray(final String value) {
return value != null ? value.toCharArray() : null;
@@ -270,7 +270,7 @@ public final class Utils {
* Converts the given char[] to a String.
*
* @param value may be null.
- * @return a String or null.
+ * @return A String or null.
*/
public static String toString(final char[] value) {
return value == null ? null : String.valueOf(value);
diff --git
a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/ConnectionImpl.java
b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/ConnectionImpl.java
index bd994c36..db2d7583 100644
--- a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/ConnectionImpl.java
+++ b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/ConnectionImpl.java
@@ -138,7 +138,7 @@ final class ConnectionImpl extends
DelegatingConnection<Connection> {
* @param sql
* an SQL statement that may contain one or more '?' parameter
placeholders. Typically, this statement is
* specified using JDBC call escape syntax.
- * @return a default {@link CallableStatement} object containing the
pre-compiled SQL statement.
+ * @return A default {@link CallableStatement} object containing the
pre-compiled SQL statement.
* @throws SQLException
* Thrown if a database access error occurs or this method
is called on a closed connection.
* @since 2.4.0
@@ -167,7 +167,7 @@ final class ConnectionImpl extends
DelegatingConnection<Connection> {
* @param resultSetConcurrency
* a concurrency type; one of {@link
ResultSet#CONCUR_READ_ONLY} or
* {@link ResultSet#CONCUR_UPDATABLE}.
- * @return a {@link CallableStatement} object containing the pre-compiled
SQL statement that will produce
+ * @return A {@link CallableStatement} object containing the pre-compiled
SQL statement that will produce
* {@link ResultSet} objects with the given type and concurrency.
* @throws SQLException
* Thrown if a database access error occurs, this method is
called on a closed connection or the given
@@ -203,7 +203,7 @@ final class ConnectionImpl extends
DelegatingConnection<Connection> {
* @param resultSetHoldability
* one of the following {@link ResultSet} constants: {@link
ResultSet#HOLD_CURSORS_OVER_COMMIT}
* or {@link ResultSet#CLOSE_CURSORS_AT_COMMIT}.
- * @return a new {@link CallableStatement} object, containing the
pre-compiled SQL statement, that will
+ * @return A new {@link CallableStatement} object, containing the
pre-compiled SQL statement, that will
* generate {@link ResultSet} objects with the given type,
concurrency, and holdability.
* @throws SQLException
* Thrown if a database access error occurs, this method is
called on a closed connection or the given
diff --git
a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java
b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java
index e7b9031d..9d73efb9 100644
---
a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java
+++
b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java
@@ -183,7 +183,7 @@ final class PooledConnectionImpl
*
* @param sql
* The SQL statement.
- * @return a {@link PStmtKey} for the given arguments.
+ * @return A {@link PStmtKey} for the given arguments.
*/
protected PStmtKey createKey(final String sql) {
return new PStmtKey(sql, getCatalogOrNull(), getSchemaOrNull());
@@ -197,7 +197,7 @@ final class PooledConnectionImpl
* @param autoGeneratedKeys
* A flag indicating whether auto-generated keys should be
returned; one of
* {@link Statement#RETURN_GENERATED_KEYS} or {@link
Statement#NO_GENERATED_KEYS}.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
*/
protected PStmtKey createKey(final String sql, final int
autoGeneratedKeys) {
return new PStmtKey(sql, getCatalogOrNull(), getSchemaOrNull(),
autoGeneratedKeys);
@@ -214,7 +214,7 @@ final class PooledConnectionImpl
* @param resultSetConcurrency
* A concurrency type; one of {@link
ResultSet#CONCUR_READ_ONLY} or
* {@link ResultSet#CONCUR_UPDATABLE}.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
*/
protected PStmtKey createKey(final String sql, final int resultSetType,
final int resultSetConcurrency) {
return new PStmtKey(sql, getCatalogOrNull(), getSchemaOrNull(),
resultSetType, resultSetConcurrency);
@@ -234,7 +234,7 @@ final class PooledConnectionImpl
* @param resultSetHoldability
* One of the following {@link ResultSet} constants: {@link
ResultSet#HOLD_CURSORS_OVER_COMMIT}
* or {@link ResultSet#CLOSE_CURSORS_AT_COMMIT}.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
*/
protected PStmtKey createKey(final String sql, final int resultSetType,
final int resultSetConcurrency, final int resultSetHoldability) {
return new PStmtKey(sql, getCatalogOrNull(), getSchemaOrNull(),
resultSetType, resultSetConcurrency, resultSetHoldability);
@@ -256,7 +256,7 @@ final class PooledConnectionImpl
* or {@link ResultSet#CLOSE_CURSORS_AT_COMMIT}.
* @param statementType
* The SQL statement type, prepared or callable.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
* @since 2.4.0
*/
protected PStmtKey createKey(final String sql, final int resultSetType,
final int resultSetConcurrency, final int resultSetHoldability,
@@ -277,7 +277,7 @@ final class PooledConnectionImpl
* {@link ResultSet#CONCUR_UPDATABLE}.
* @param statementType
* The SQL statement type, prepared or callable.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
* @since 2.4.0
*/
protected PStmtKey createKey(final String sql, final int resultSetType,
final int resultSetConcurrency, final StatementType statementType) {
@@ -292,7 +292,7 @@ final class PooledConnectionImpl
* @param columnIndexes
* An array of column indexes indicating the columns that
should be returned from the inserted row or
* rows.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
*/
protected PStmtKey createKey(final String sql, final int[] columnIndexes) {
return new PStmtKey(sql, getCatalogOrNull(), getSchemaOrNull(),
columnIndexes);
@@ -305,7 +305,7 @@ final class PooledConnectionImpl
* The SQL statement.
* @param statementType
* The SQL statement type, prepared or callable.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
*/
protected PStmtKey createKey(final String sql, final StatementType
statementType) {
return new PStmtKey(sql, getCatalogOrNull(), getSchemaOrNull(),
statementType);
@@ -318,7 +318,7 @@ final class PooledConnectionImpl
* The SQL statement.
* @param columnNames
* An array of column names indicating the columns that should
be returned from the inserted row or rows.
- * @return a key to uniquely identify a prepared statement.
+ * @return A key to uniquely identify a prepared statement.
*/
protected PStmtKey createKey(final String sql, final String[] columnNames)
{
return new PStmtKey(sql, getCatalogOrNull(), getSchemaOrNull(),
columnNames);
@@ -471,7 +471,7 @@ final class PooledConnectionImpl
* @param sql
* an SQL statement that may contain one or more '?' parameter
placeholders. Typically, this statement is
* specified using JDBC call escape syntax.
- * @return a default {@link CallableStatement} object containing the
pre-compiled SQL statement.
+ * @return A default {@link CallableStatement} object containing the
pre-compiled SQL statement.
* @throws SQLException
* Thrown if a database access error occurs or this method
is called on a closed connection.
* @since 2.4.0
@@ -502,7 +502,7 @@ final class PooledConnectionImpl
* @param resultSetConcurrency
* a concurrency type; one of {@link
ResultSet#CONCUR_READ_ONLY} or
* {@link ResultSet#CONCUR_UPDATABLE}.
- * @return a {@link CallableStatement} object containing the pre-compiled
SQL statement that will produce
+ * @return A {@link CallableStatement} object containing the pre-compiled
SQL statement that will produce
* {@link ResultSet} objects with the given type and concurrency.
* @throws SQLException
* Thrown if a database access error occurs, this method is
called on a closed connection or the given
@@ -540,7 +540,7 @@ final class PooledConnectionImpl
* @param resultSetHoldability
* one of the following {@link ResultSet} constants: {@link
ResultSet#HOLD_CURSORS_OVER_COMMIT}
* or {@link ResultSet#CLOSE_CURSORS_AT_COMMIT}.
- * @return a new {@link CallableStatement} object, containing the
pre-compiled SQL statement, that will
+ * @return A new {@link CallableStatement} object, containing the
pre-compiled SQL statement, that will
* generate {@link ResultSet} objects with the given type,
concurrency, and holdability.
* @throws SQLException
* Thrown if a database access error occurs, this method is
called on a closed connection or the given
@@ -567,7 +567,7 @@ final class PooledConnectionImpl
* Creates or obtains a {@link PreparedStatement} from my pool.
*
* @param sql the SQL statement.
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException Thrown if a database access error occurs, this
method is called on a closed connection, or
* the borrow failed.
*/
@@ -593,7 +593,7 @@ final class PooledConnectionImpl
* @param autoGeneratedKeys
* a flag indicating whether auto-generated keys should be
returned; one of
* {@link Statement#RETURN_GENERATED_KEYS} or {@link
Statement#NO_GENERATED_KEYS}.
- * @return a {@link PoolablePreparedStatement}
+ * @return A {@link PoolablePreparedStatement}
* @throws SQLException Thrown if a database access error occurs, this
method is called on a closed connection, or
* the borrow failed.
* @see Connection#prepareStatement(String, int)
@@ -625,7 +625,7 @@ final class PooledConnectionImpl
* a concurrency type; one of {@link
ResultSet#CONCUR_READ_ONLY} or
* {@link ResultSet#CONCUR_UPDATABLE}.
*
- * @return a {@link PoolablePreparedStatement}.
+ * @return A {@link PoolablePreparedStatement}.
* @throws SQLException Thrown if a database access error occurs, this
method is called on a closed connection, or
* the borrow failed.
* @see Connection#prepareStatement(String, int, int)
diff --git
a/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java
index 4aef3f46..bed3e2d3 100644
---
a/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java
+++
b/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java
@@ -78,7 +78,7 @@ class AbstractConnectionFactory {
* Converts a duration to seconds where a duration less than one second
becomes 1 second.
*
* @param duration the duration to convert.
- * @return a duration to seconds where a duration less than one second
becomes 1 second.
+ * @return A duration to seconds where a duration less than one second
becomes 1 second.
* @throws ArithmeticException if the query validation timeout does not
fit as seconds in an int.
*/
private int toSeconds(final Duration duration) {
diff --git
a/src/main/java/org/apache/commons/dbcp2/managed/XAConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/managed/XAConnectionFactory.java
index 3628a93c..50ef681e 100644
--- a/src/main/java/org/apache/commons/dbcp2/managed/XAConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/managed/XAConnectionFactory.java
@@ -38,7 +38,7 @@ public interface XAConnectionFactory extends
ConnectionFactory {
* the setAutoCommit, commit and rollback when enrolled in a XA
transaction.
* </p>
*
- * @return a new {@link Connection}
+ * @return A new {@link Connection}
* @throws SQLException if a database error occurs creating the connection
*/
@Override
diff --git a/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
b/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
index df25d275..148e055a 100644
--- a/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
+++ b/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
@@ -53,7 +53,7 @@ public class StackMessageLog extends SimpleLog {
* Note: lock the stack first.
* </p>
*
- * @return a new list.
+ * @return A new list.
*/
public static List<String> getAll() {
return new ArrayList<>(MESSAGE_STACK);
diff --git a/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
b/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
index bc5c11a3..6e292693 100644
--- a/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
+++ b/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
@@ -442,7 +442,7 @@ public abstract class TestConnectionPool {
/**
* Acquires a new connection and push it onto the connections stack.
*
- * @return a new connection.
+ * @return A new connection.
* @throws Exception Defined in subclasses.
*/
@SuppressWarnings("resource") // Caller closes
