This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/commons-xml.git
commit 0ebe9e03d66ee5a30031a997089eb2a2f100045d Author: Gary Gregory <[email protected]> AuthorDate: Sun Aug 30 11:52:27 2026 -0400 Use final. Use compact array initialization. --- .../commons/xml/FallbackIgnoreEntityResolver2.java | 2 +- .../commons/xml/SecureValidatorHandlerTest.java | 32 +++++++++++----------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/main/java/org/apache/commons/xml/FallbackIgnoreEntityResolver2.java b/src/main/java/org/apache/commons/xml/FallbackIgnoreEntityResolver2.java index 15931de..bd7d1a5 100644 --- a/src/main/java/org/apache/commons/xml/FallbackIgnoreEntityResolver2.java +++ b/src/main/java/org/apache/commons/xml/FallbackIgnoreEntityResolver2.java @@ -55,7 +55,7 @@ */ class FallbackIgnoreEntityResolver2 extends DefaultHandler2 { - private static final byte[] EMPTY = new byte[0]; + private static final byte[] EMPTY = {}; /** * Resolves {@code systemId} against {@code baseURI}. diff --git a/src/test/java/org/apache/commons/xml/SecureValidatorHandlerTest.java b/src/test/java/org/apache/commons/xml/SecureValidatorHandlerTest.java index f3d4721..e61e07a 100644 --- a/src/test/java/org/apache/commons/xml/SecureValidatorHandlerTest.java +++ b/src/test/java/org/apache/commons/xml/SecureValidatorHandlerTest.java @@ -125,7 +125,7 @@ private static final class RecordingValidatorHandler extends ValidatorHandler { LSResourceResolver resourceResolver; @Override - public void characters(char[] ch, int start, int length) { + public void characters(final char[] ch, final int start, final int length) { charactersCalled = true; charactersChars = ch.clone(); charactersStart = start; @@ -138,7 +138,7 @@ public void endDocument() { } @Override - public void endElement(String uri, String localName, String qName) { + public void endElement(final String uri, final String localName, final String qName) { endElementCalled = true; endElementUri = uri; endElementLocalName = localName; @@ -146,7 +146,7 @@ public void endElement(String uri, String localName, String qName) { } @Override - public void endPrefixMapping(String prefix) { + public void endPrefixMapping(final String prefix) { endPrefixMappingCalled = true; endPrefixMappingPrefix = prefix; } @@ -162,12 +162,12 @@ public ErrorHandler getErrorHandler() { } @Override - public boolean getFeature(String name) { + public boolean getFeature(final String name) { return false; } @Override - public Object getProperty(String name) { + public Object getProperty(final String name) { return null; } @@ -182,55 +182,55 @@ public TypeInfoProvider getTypeInfoProvider() { } @Override - public void ignorableWhitespace(char[] ch, int start, int length) { + public void ignorableWhitespace(final char[] ch, final int start, final int length) { ignorableWhitespaceCalled = true; } @Override - public void processingInstruction(String target, String data) { + public void processingInstruction(final String target, final String data) { processingInstructionCalled = true; piTarget = target; piData = data; } @Override - public void setContentHandler(ContentHandler handler) { + public void setContentHandler(final ContentHandler handler) { setContentHandlerCalled = true; contentHandler = handler; } @Override - public void setDocumentLocator(Locator locator) { + public void setDocumentLocator(final Locator locator) { setDocumentLocatorCalled = true; } @Override - public void setErrorHandler(ErrorHandler handler) { + public void setErrorHandler(final ErrorHandler handler) { setErrorHandlerCalled = true; errorHandler = handler; } @Override - public void setFeature(String name, boolean value) { + public void setFeature(final String name, final boolean value) { setFeatureCalled = true; setFeatureName = name; setFeatureValue = value; } @Override - public void setProperty(String name, Object value) { + public void setProperty(final String name, final Object value) { setPropertyCalled = true; setPropertyName = name; setPropertyValue = value; } @Override - public void setResourceResolver(LSResourceResolver resolver) { + public void setResourceResolver(final LSResourceResolver resolver) { resourceResolver = resolver; } @Override - public void skippedEntity(String name) { + public void skippedEntity(final String name) { skippedEntityCalled = true; skippedEntityName = name; } @@ -241,7 +241,7 @@ public void startDocument() { } @Override - public void startElement(String uri, String localName, String qName, Attributes atts) { + public void startElement(final String uri, final String localName, final String qName, final Attributes atts) { startElementCalled = true; startElementUri = uri; startElementLocalName = localName; @@ -250,7 +250,7 @@ public void startElement(String uri, String localName, String qName, Attributes } @Override - public void startPrefixMapping(String prefix, String uri) { + public void startPrefixMapping(final String prefix, final String uri) { startPrefixMappingCalled = true; startPrefixMappingPrefix = prefix; startPrefixMappingUri = uri;
