Author: sebb
Date: Mon Apr 18 20:06:17 2011
New Revision: 1094721

URL: http://svn.apache.org/viewvc?rev=1094721&view=rev
Log:
VALIDATOR-293 add tests for trailing - and _

Modified:
    
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java

Modified: 
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java?rev=1094721&r1=1094720&r2=1094721&view=diff
==============================================================================
--- 
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
 (original)
+++ 
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
 Mon Apr 18 20:06:17 2011
@@ -164,11 +164,11 @@ public class EmailValidatorTest extends 
     * Tests the email validation with spaces.
     */
     public void testEmailWithSpaces()  {
-        assertFalse(validator.isValid("joeblow @apache.org"));
+        assertFalse(validator.isValid("joeblow @apache.org")); // TODO - this 
should be valid?
 
         assertFalse(validator.isValid("joeblow@ apache.org"));
 
-        assertTrue(validator.isValid(" [email protected]"));
+        assertTrue(validator.isValid(" [email protected]")); // TODO - this 
should be valid?
 
         assertTrue(validator.isValid("[email protected] "));
 
@@ -402,4 +402,11 @@ public class EmailValidatorTest extends 
         }
     }
 
+    public void testValidator293(){
+        assertTrue(validator.isValid("[email protected]"));
+        assertTrue(validator.isValid("[email protected]"));
+        assertTrue(validator.isValid("[email protected]"));
+        assertTrue(validator.isValid("[email protected]"));
+        assertFalse(validator.isValid("abc@abc_def.com"));
+    }
 }


Reply via email to