Author: simonetripodi
Date: Thu Apr 21 05:54:13 2011
New Revision: 1095600
URL: http://svn.apache.org/viewvc?rev=1095600&view=rev
Log:
lightweight notation when iterating over OptionGroup.getOptions() elements
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java?rev=1095600&r1=1095599&r2=1095600&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
(original)
+++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
Thu Apr 21 05:54:13 2011
@@ -23,7 +23,6 @@ import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
-import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
@@ -69,17 +68,13 @@ public class Options implements Serializ
*/
public Options addOptionGroup(OptionGroup group)
{
- Iterator<Option> options = group.getOptions().iterator();
-
if (group.isRequired())
{
requiredOpts.add(group);
}
- while (options.hasNext())
+ for (Option option : group.getOptions())
{
- Option option = options.next();
-
// an Option cannot be required if it is in an
// OptionGroup, either the group is required or
// nothing is required
