(commons-pool) branch master updated: Add missing @Test annotations

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git


The following commit(s) were added to refs/heads/master by this push:
     new 5f86facc Add missing @Test annotations
5f86facc is described below

commit 5f86facc754dfc4c0ec099b6742c0ba6eda6dbe8
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Oct 30 09:02:01 2026 -0400

    Add missing @Test annotations
    
    Add TODOs
---
 .../org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java   | 4 ++++
 .../java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java   | 4 ++++
 .../java/org/apache/commons/pool3/impl/TestBaseGenericObjectPool.java | 1 +
 3 files changed, 9 insertions(+)

diff --git 
a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java 
b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
index 3d7c414c..d61812ab 100644
--- 
a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
+++ 
b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
@@ -39,6 +39,7 @@ import org.apache.commons.pool3.PooledObject;
 import org.apache.commons.pool3.Waiter;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -305,6 +306,8 @@ class TestAbandonedKeyedObjectPool {
         assertEquals(0, pool.getNumActive(), "numActive should have been 0, 
was " + pool.getNumActive());
     }
 
+    @Test
+    @Disabled("TODO")
     void testDestroyModeAbandoned() throws Exception {
         abandonedConfig = new AbandonedConfig();
         abandonedConfig.setRemoveAbandonedOnMaintenance(true);
@@ -321,6 +324,7 @@ class TestAbandonedKeyedObjectPool {
         assertTrue(obj.isDetached());
     }
 
+    @Test
     void testDestroyModeNormal() throws Exception {
         abandonedConfig = new AbandonedConfig();
         pool.close();  // Unregister pool created by setup
diff --git 
a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java 
b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
index 5b7be2ec..1baee06f 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
@@ -42,6 +42,7 @@ import org.apache.commons.pool3.TrackedUse;
 import org.apache.commons.pool3.Waiter;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 final class PooledTestObject implements TrackedUse {
@@ -369,6 +370,8 @@ class TestAbandonedObjectPool {
         assertEquals(0, pool.getNumActive(), "numActive should have been 0, 
was " + pool.getNumActive());
     }
 
+    @Test
+    @Disabled("TODO")
     void testDestroyModeAbandoned() throws Exception {
         abandonedConfig = new AbandonedConfig();
         abandonedConfig.setRemoveAbandonedOnMaintenance(true);
@@ -385,6 +388,7 @@ class TestAbandonedObjectPool {
         assertTrue(obj.isDetached());
     }
 
+    @Test
     void testDestroyModeNormal() throws Exception {
         abandonedConfig = new AbandonedConfig();
         pool.close();  // Unregister pool created by setup
diff --git 
a/src/test/java/org/apache/commons/pool3/impl/TestBaseGenericObjectPool.java 
b/src/test/java/org/apache/commons/pool3/impl/TestBaseGenericObjectPool.java
index 2e0055af..92ba650f 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestBaseGenericObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestBaseGenericObjectPool.java
@@ -84,6 +84,7 @@ class TestBaseGenericObjectPool {
         assertEquals(30, pool.getMaxBorrowWaitTimeMillis(), 0);
     }
 
+    @Test
     void testBorrowWaitStatisticsMax() {
         final DefaultPooledObject<String> p = (DefaultPooledObject<String>) 
factory.makeObject();
         assertEquals(0, pool.getMaxBorrowWaitTimeMillis(), Double.MIN_VALUE);