svn commit: r1124154 - /incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java

[simonetripodi]

Author: simonetripodi
Date: Wed May 18 09:53:45 2011
New Revision: 1124154

URL: http://svn.apache.org/viewvc?rev=1124154&view=rev
Log:
removed ugly string concatenation

Modified:
    
incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java

Modified: 
incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
URL: 
http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java?rev=1124154&r1=1124153&r2=1124154&view=diff
==============================================================================
--- 
incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
 (original)
+++ 
incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
 Wed May 18 09:53:45 2011
@@ -19,6 +19,8 @@ package org.apache.commons.ognl.enhance;
  * under the License.
  */
 
+import static java.lang.String.format;
+
 import java.lang.reflect.Method;
 import java.lang.reflect.Modifier;
 import java.util.Collection;
@@ -684,11 +686,7 @@ public class ExpressionCompiler
 
             String widener = ref.getType().isPrimitive() ? " " : " ($w) ";
 
-            String body = "{";
-            body += " return  " + widener + ref.getExpression() + ";";
-            body += "}";
-
-            body = body.replaceAll( "\\.\\.", "." );
+            String body = format( "{ return %s %s; }", widener, 
ref.getExpression() ).replaceAll( "\\.\\.", "." );
 
             // System.out.println("adding method " + ref.getName() + " with 
body:\n" + body + " and return type: " +
             // ref.getType());