Author: sebb
Date: Tue Dec 13 01:03:39 2011
New Revision: 1213529
URL: http://svn.apache.org/viewvc?rev=1213529&view=rev
Log:
Write once private fields might as well be final
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java?rev=1213529&r1=1213528&r2=1213529&view=diff
==============================================================================
---
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
(original)
+++
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
Tue Dec 13 01:03:39 2011
@@ -306,10 +306,10 @@ public class SoftReferenceObjectPool<T>
}
/** My pool. */
- private List<SoftReference<T>> _pool = null;
+ private final List<SoftReference<T>> _pool;
/** My {@link PoolableObjectFactory}. */
- private PoolableObjectFactory<T> _factory = null;
+ private final PoolableObjectFactory<T> _factory;
/**
* Queue of broken references that might be able to be removed from
<code>_pool</code>.
@@ -319,5 +319,5 @@ public class SoftReferenceObjectPool<T>
private final ReferenceQueue<T> refQueue = new ReferenceQueue<T>();
/** Number of active objects. */
- private int _numActive = 0;
+ private int _numActive = 0; // @GuardedBy("this")
}
