svn commit: r1213741 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericKeyedObjectPool.java GenericObjectPool.java

[sebb]

Author: sebb
Date: Tue Dec 13 15:33:00 2011
New Revision: 1213741

URL: http://svn.apache.org/viewvc?rev=1213741&view=rev
Log:
Document reason for final qualifier

Modified:
    
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
    
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java

Modified: 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
URL: 
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java?rev=1213741&r1=1213740&r2=1213741&view=diff
==============================================================================
--- 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
 (original)
+++ 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
 Tue Dec 13 15:33:00 2011
@@ -1637,6 +1637,7 @@ public class GenericKeyedObjectPool<K,T>
      *
      * @param delay milliseconds between evictor runs.
      */
+    // Needs to be final; see POOL-195. Make protected method final as it is 
called from constructor.
     protected final synchronized void startEvictor(long delay) {
         if (null != evictor) {
             EvictionTimer.cancel(evictor);

Modified: 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
URL: 
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java?rev=1213741&r1=1213740&r2=1213741&view=diff
==============================================================================
--- 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
 (original)
+++ 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
 Tue Dec 13 15:33:00 2011
@@ -1224,6 +1224,7 @@ public class GenericObjectPool<T> extend
      * @param delay
      *            milliseconds between evictor runs.
      */
+    // Needs to be final; see POOL-195. Make protected method final as it is 
called from constructor.
     protected final synchronized void startEvictor(long delay) {
         if (null != evictor) {
             EvictionTimer.cancel(evictor);