svn commit: r1213834 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericKeyedObjectPool.java GenericObjectPool.java

[sebb]

Author: sebb
Date: Tue Dec 13 18:30:53 2011
New Revision: 1213834

URL: http://svn.apache.org/viewvc?rev=1213834&view=rev
Log:
The counters are created once, and are private so make them final

Modified:
    
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
    
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java

Modified: 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
URL: 
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java?rev=1213834&r1=1213833&r2=1213834&view=diff
==============================================================================
--- 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
 (original)
+++ 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
 Tue Dec 13 18:30:53 2011
@@ -2118,12 +2118,12 @@ public class GenericKeyedObjectPool<K,T>
 
     // JMX specific attributes
     private static final int AVERAGE_TIMING_STATS_CACHE_SIZE = 100;
-    private AtomicLong borrowedCount = new AtomicLong(0);
-    private AtomicLong returnedCount = new AtomicLong(0);
-    private AtomicLong createdCount = new AtomicLong(0);
-    private AtomicLong destroyedCount = new AtomicLong(0);
-    private AtomicLong destroyedByEvictorCount = new AtomicLong(0);
-    private AtomicLong destroyedByBorrowValidationCount = new AtomicLong(0);
+    private final AtomicLong borrowedCount = new AtomicLong(0);
+    private final AtomicLong returnedCount = new AtomicLong(0);
+    private final AtomicLong createdCount = new AtomicLong(0);
+    private final AtomicLong destroyedCount = new AtomicLong(0);
+    private final AtomicLong destroyedByEvictorCount = new AtomicLong(0);
+    private final AtomicLong destroyedByBorrowValidationCount = new 
AtomicLong(0);
     private final LinkedList<Long> activeTimes = new LinkedList<Long>();
     private final LinkedList<Long> idleTimes = new LinkedList<Long>();
     private final LinkedList<Long> waitTimes = new LinkedList<Long>();

Modified: 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
URL: 
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java?rev=1213834&r1=1213833&r2=1213834&view=diff
==============================================================================
--- 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
 (original)
+++ 
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
 Tue Dec 13 18:30:53 2011
@@ -1568,12 +1568,12 @@ public class GenericObjectPool<T> extend
 
     // JMX specific attributes
     private static final int AVERAGE_TIMING_STATS_CACHE_SIZE = 100;
-    private AtomicLong borrowedCount = new AtomicLong(0);
-    private AtomicLong returnedCount = new AtomicLong(0);
-    private AtomicLong createdCount = new AtomicLong(0);
-    private AtomicLong destroyedCount = new AtomicLong(0);
-    private AtomicLong destroyedByEvictorCount = new AtomicLong(0);
-    private AtomicLong destroyedByBorrowValidationCount = new AtomicLong(0);
+    private final AtomicLong borrowedCount = new AtomicLong(0);
+    private final AtomicLong returnedCount = new AtomicLong(0);
+    private final AtomicLong createdCount = new AtomicLong(0);
+    private final AtomicLong destroyedCount = new AtomicLong(0);
+    private final AtomicLong destroyedByEvictorCount = new AtomicLong(0);
+    private final AtomicLong destroyedByBorrowValidationCount = new 
AtomicLong(0);
     private final LinkedList<Long> activeTimes = new LinkedList<Long>();
     private final LinkedList<Long> idleTimes = new LinkedList<Long>();
     private final LinkedList<Long> waitTimes = new LinkedList<Long>();