Author: sebb
Date: Tue Dec 13 18:51:58 2011
New Revision: 1213855
URL: http://svn.apache.org/viewvc?rev=1213855&view=rev
Log:
Make write-once private object final, and fix safe publication issue.
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/PooledObject.java
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/PooledObject.java
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/PooledObject.java?rev=1213855&r1=1213854&r2=1213855&view=diff
==============================================================================
---
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/PooledObject.java
(original)
+++
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/PooledObject.java
Tue Dec 13 18:51:58 2011
@@ -20,10 +20,12 @@ package org.apache.commons.pool2.impl;
/**
* This wrapper is used to track the additional information, such as state, for
* the pooled objects.
+ * <p>
+ * This class is intended to be thread-safe.
*/
public class PooledObject<T> implements Comparable<PooledObject<T>> {
- private T object = null;
+ private final T object;
private volatile PooledObjectState state = PooledObjectState.IDLE; //
@GuardedBy("this") to ensure transitions are valid
private final long createTime = System.currentTimeMillis();
private volatile long lastBorrowTime = createTime;