Author: erans
Date: Thu Mar 1 22:30:26 2012
New Revision: 1295953
URL: http://svn.apache.org/viewvc?rev=1295953&view=rev
Log:
Made inner class "static" because it is "Serializable" while the enclosing
class is not (bad practice signalled by "FindBugs").
Modified:
commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SymmLQ.java
Modified:
commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SymmLQ.java
URL:
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SymmLQ.java?rev=1295953&r1=1295952&r2=1295953&view=diff
==============================================================================
---
commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SymmLQ.java
(original)
+++
commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SymmLQ.java
Thu Mar 1 22:30:26 2012
@@ -658,17 +658,17 @@ public class SymmLQ
*
* @version $Id$
*/
- private class SymmLQEvent extends IterativeLinearSolverEvent {
+ private static class SymmLQEvent extends IterativeLinearSolverEvent {
/*
* TODO This class relies dangerously on references being transparently
* updated.
*/
- /** */
+ /** Identifier. */
private static final long serialVersionUID = 2012012801L;
/** A reference to the state of this solver. */
- private final State state;
+ private final transient State state;
/**
* Creates a new instance of this class.
@@ -677,15 +677,15 @@ public class SymmLQ
* occurred
* @param state the state of this solver at the time of creation
*/
- public SymmLQEvent(final Object source, final State state) {
- super(source, getIterationManager().getIterations());
+ public SymmLQEvent(final SymmLQ source, final State state) {
+ super(source, source.getIterationManager().getIterations());
this.state = state;
}
/** {@inheritDoc} */
@Override
public int getIterations() {
- return getIterationManager().getIterations();
+ return ((SymmLQ)
getSource()).getIterationManager().getIterations();
}
/** {@inheritDoc} */
