Author: simonetripodi Date: Sun Jun 10 08:06:11 2012 New Revision: 1348547 URL: http://svn.apache.org/viewvc?rev=1348547&view=rev Log: [FUNCTOR-19] Fix checkstyle warnings - patch provided by Bruno P. Kinoshita
Modified: commons/proper/functor/trunk/src/changes/changes.xml commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Limit.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Offset.java Modified: commons/proper/functor/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/changes/changes.xml?rev=1348547&r1=1348546&r2=1348547&view=diff ============================================================================== --- commons/proper/functor/trunk/src/changes/changes.xml (original) +++ commons/proper/functor/trunk/src/changes/changes.xml Sun Jun 10 08:06:11 2012 @@ -23,6 +23,9 @@ </properties> <body> <release version="1.0" date="2012-??-??" description="First release."> + <action dev="simonetripodi" issue="FUNCTOR-19" due-to="Bruno P. Kinoshita"> + Fix checkstyle warnings + </action> <action dev="simonetripodi" issue="FUNCTOR-18" due-to="Bruno P. Kinoshita"> Fix duplicated entries in examples page of [functor] website, and replace <br/> tags in aggregator.xml </action> Modified: commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Limit.java URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Limit.java?rev=1348547&r1=1348546&r2=1348547&view=diff ============================================================================== --- commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Limit.java (original) +++ commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Limit.java Sun Jun 10 08:06:11 2012 @@ -32,13 +32,13 @@ import org.apache.commons.functor.UnaryP * @version $Revision$ $Date$ */ public final class Limit implements Predicate, UnaryPredicate<Object>, BinaryPredicate<Object, Object>, Serializable { - // static attributes + // static attributes // ------------------------------------------------------------------------ /** - * serialVersionUID declaration. - */ - private static final long serialVersionUID = 8974528922587619067L; - // instance variables + * serialVersionUID declaration. + */ + private static final long serialVersionUID = 8974528922587619067L; + // instance variables //--------------------------------------------------------------- /** * The max number of times the predicate can be invoked. @@ -91,14 +91,14 @@ public final class Limit implements Pred */ @Override public boolean equals(Object obj) { - if(obj == this) { - return true; - } - if(!(obj instanceof Limit)) { - return false; - } - Limit other = (Limit)obj; - return other.max == max; + if (obj == this) { + return true; + } + if (!(obj instanceof Limit)) { + return false; + } + Limit other = (Limit) obj; + return other.max == max; } /** @@ -106,10 +106,10 @@ public final class Limit implements Pred */ @Override public int hashCode() { - int result = "Limit".hashCode(); - result <<= 2; - result ^= max; - return result; + int result = "Limit".hashCode(); + result <<= 2; + result ^= max; + return result; } /** Modified: commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Offset.java URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Offset.java?rev=1348547&r1=1348546&r2=1348547&view=diff ============================================================================== --- commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Offset.java (original) +++ commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/Offset.java Sun Jun 10 08:06:11 2012 @@ -31,14 +31,14 @@ import org.apache.commons.functor.UnaryP * @version $Revision$ $Date$ */ public final class Offset implements Predicate, UnaryPredicate<Object>, BinaryPredicate<Object, Object>, Serializable { - // static attributes + // static attributes // ------------------------------------------------------------------------ /** - * serialVersionUID declaration. - */ - private static final long serialVersionUID = 5800706757874735854L; + * serialVersionUID declaration. + */ + private static final long serialVersionUID = 5800706757874735854L; - // instance variables + // instance variables //--------------------------------------------------------------- /** * The number of times the predicate must return {@code false}. @@ -91,14 +91,14 @@ public final class Offset implements Pre */ @Override public boolean equals(Object obj) { - if(obj == this) { - return true; - } - if(!(obj instanceof Offset)) { - return false; - } - Offset other = (Offset)obj; - return other.min == min; + if (obj == this) { + return true; + } + if (!(obj instanceof Offset)) { + return false; + } + Offset other = (Offset) obj; + return other.min == min; } /** @@ -106,10 +106,10 @@ public final class Offset implements Pre */ @Override public int hashCode() { - int result = "Offset".hashCode(); - result <<= 2; - result ^= min; - return result; + int result = "Offset".hashCode(); + result <<= 2; + result ^= min; + return result; } /**