Author: sebb
Date: Wed Apr 24 17:40:22 2013
New Revision: 1471558
URL: http://svn.apache.org/r1471558
Log:
Private immutable fields might as well be final (helps with thread-safety)
Modified:
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/HandlerCommand.java
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/RequestContext.java
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/ResponseContext.java
commons/proper/chain/trunk/configuration/api/src/main/java/org/apache/commons/chain2/config/ConfigParser.java
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigCatalogRule.java
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigDefineRule.java
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigRegisterRule.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/MapEntry.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletApplicationScopeMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletInitParamMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamValuesMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletRequestScopeMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletApplicationScopeMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletCookieMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderValuesMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletInitParamMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamValuesMap.java
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletRequestScopeMap.java
Modified:
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/HandlerCommand.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/HandlerCommand.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/HandlerCommand.java
(original)
+++
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/HandlerCommand.java
Wed Apr 24 17:40:22 2013
@@ -28,7 +28,7 @@ import org.apache.commons.chain2.cookboo
public class HandlerCommand implements Command<String, Object, RequestContext>,
RequestHandler {
- private String name = null;
+ private final String name;
public HandlerCommand(String name) {
this.name = name;
Modified:
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/RequestContext.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/RequestContext.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/RequestContext.java
(original)
+++
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/RequestContext.java
Wed Apr 24 17:40:22 2013
@@ -25,7 +25,7 @@ import org.apache.commons.chain2.impl.Co
*/
public class RequestContext extends ContextBase implements Request {
- private String name;
+ private final String name;
private Response response;
Modified:
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/ResponseContext.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/ResponseContext.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/ResponseContext.java
(original)
+++
commons/proper/chain/trunk/apps/cookbook-examples/src/main/java/org/apache/commons/chain2/cookbook/agility/impl/ResponseContext.java
Wed Apr 24 17:40:22 2013
@@ -24,7 +24,7 @@ import org.apache.commons.chain2.impl.Co
*/
public class ResponseContext extends ContextBase implements Response {
- private String name;
+ private final String name;
public ResponseContext(String name) {
super();
Modified:
commons/proper/chain/trunk/configuration/api/src/main/java/org/apache/commons/chain2/config/ConfigParser.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/configuration/api/src/main/java/org/apache/commons/chain2/config/ConfigParser.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/configuration/api/src/main/java/org/apache/commons/chain2/config/ConfigParser.java
(original)
+++
commons/proper/chain/trunk/configuration/api/src/main/java/org/apache/commons/chain2/config/ConfigParser.java
Wed Apr 24 17:40:22 2013
@@ -33,7 +33,7 @@ import java.net.URL;
* @version $Id$
*/
public class ConfigParser {
- private Log logger = LogFactory.getLog(getClass());
+ private final Log logger = LogFactory.getLog(getClass());
/**
* Constructor for loading a configuration parser with the default
settings.
Modified:
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigCatalogRule.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigCatalogRule.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigCatalogRule.java
(original)
+++
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigCatalogRule.java
Wed Apr 24 17:40:22 2013
@@ -58,13 +58,13 @@ class ConfigCatalogRule extends Rule {
* <p>The fully qualified class name of a {@link
org.apache.commons.chain2.Catalog} class to use for
* instantiating new instances.</p>
*/
- private String catalogClass = null;
+ private final String catalogClass;
/**
* <p>The name of the attribute under which we can retrieve the name
* this catalog should be registered with (if any).</p>
*/
- private String nameAttribute = null;
+ private final String nameAttribute;
// --------------------------------------------------------- Public Methods
Modified:
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigDefineRule.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigDefineRule.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigDefineRule.java
(original)
+++
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigDefineRule.java
Wed Apr 24 17:40:22 2013
@@ -56,13 +56,13 @@ class ConfigDefineRule extends Rule {
* fully qualified class name of the implementation class for this
* new element.</p>
*/
- private String classAttribute = null;
+ private final String classAttribute;
/**
* <p>The name of the attribute under which we can retrieve the name
* this element for which rules should be created.</p>
*/
- private String nameAttribute = null;
+ private final String nameAttribute;
// --------------------------------------------------------- Public Methods
Modified:
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigRegisterRule.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigRegisterRule.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigRegisterRule.java
(original)
+++
commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/ConfigRegisterRule.java
Wed Apr 24 17:40:22 2013
@@ -56,7 +56,7 @@ class ConfigRegisterRule extends Rule {
* <p>The name of the attribute under which we can retrieve the name
* this command should be registered with.</p>
*/
- private String nameAttribute = null;
+ private final String nameAttribute;
// --------------------------------------------------------- Public Methods
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/MapEntry.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/MapEntry.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/MapEntry.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/MapEntry.java
Wed Apr 24 17:40:22 2013
@@ -32,7 +32,7 @@ public class MapEntry<K, V> implements M
/**
* <p>The entry key.</p>
*/
- private K key;
+ private final K key;
/**
* <p>The entry value.</p>
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletApplicationScopeMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletApplicationScopeMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletApplicationScopeMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletApplicationScopeMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class PortletApplicationScopeMap i
this.context = context;
}
- private PortletContext context = null;
+ private final PortletContext context;
public void clear() {
for (String key : keySet()) {
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletInitParamMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletInitParamMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletInitParamMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletInitParamMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class PortletInitParamMap implemen
this.context = context;
}
- private PortletContext context = null;
+ private final PortletContext context;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class PortletParamMap implements M
this.request = request;
}
- private PortletRequest request = null;
+ private final PortletRequest request;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamValuesMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamValuesMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamValuesMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletParamValuesMap.java
Wed Apr 24 17:40:22 2013
@@ -40,7 +40,7 @@ final class PortletParamValuesMap implem
this.request = request;
}
- private PortletRequest request = null;
+ private final PortletRequest request;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletRequestScopeMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletRequestScopeMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletRequestScopeMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/portlet/PortletRequestScopeMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class PortletRequestScopeMap imple
this.request = request;
}
- private PortletRequest request = null;
+ private final PortletRequest request;
public void clear() {
for (String key : keySet()) {
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletApplicationScopeMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletApplicationScopeMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletApplicationScopeMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletApplicationScopeMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletApplicationScopeMap i
this.context = context;
}
- private ServletContext context = null;
+ private final ServletContext context;
public void clear() {
for (String key : keySet()) {
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletCookieMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletCookieMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletCookieMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletCookieMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletCookieMap implements
this.request = request;
}
- private HttpServletRequest request = null;
+ private final HttpServletRequest request;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletHeaderMap implements
this.request = request;
}
- private HttpServletRequest request = null;
+ private final HttpServletRequest request;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderValuesMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderValuesMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderValuesMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletHeaderValuesMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletHeaderValuesMap imple
this.request = request;
}
- private HttpServletRequest request = null;
+ private final HttpServletRequest request;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletInitParamMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletInitParamMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletInitParamMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletInitParamMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletInitParamMap implemen
this.context = context;
}
- private ServletContext context = null;
+ private final ServletContext context;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletParamMap implements M
this.request = request;
}
- private HttpServletRequest request = null;
+ private final HttpServletRequest request;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamValuesMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamValuesMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamValuesMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletParamValuesMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletParamValuesMap implem
this.request = request;
}
- private HttpServletRequest request = null;
+ private final HttpServletRequest request;
public void clear() {
throw new UnsupportedOperationException();
Modified:
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletRequestScopeMap.java
URL:
http://svn.apache.org/viewvc/commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletRequestScopeMap.java?rev=1471558&r1=1471557&r2=1471558&view=diff
==============================================================================
---
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletRequestScopeMap.java
(original)
+++
commons/proper/chain/trunk/web/src/main/java/org/apache/commons/chain2/web/servlet/ServletRequestScopeMap.java
Wed Apr 24 17:40:22 2013
@@ -39,7 +39,7 @@ final class ServletRequestScopeMap imple
this.request = request;
}
- private HttpServletRequest request = null;
+ private final HttpServletRequest request;
public void clear() {
for (String key : keySet()) {
