Author: ebourg
Date: Sun Aug 18 11:31:17 2013
New Revision: 1515087
URL: http://svn.apache.org/r1515087
Log:
Replaced StringBuffers with StringBuilders
Modified:
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseCompilationProblem.java
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java
commons/proper/jci/trunk/compilers/janino/src/main/java/org/apache/commons/jci/compilers/JaninoCompilationProblem.java
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacClassLoader.java
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacCompilationProblem.java
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacJavaCompiler.java
commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/compilers/AbstractCompilerTestCase.java
commons/proper/jci/trunk/examples/src/main/java/org/apache/commons/jci/examples/serverpages/JspGenerator.java
Modified:
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseCompilationProblem.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseCompilationProblem.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseCompilationProblem.java
(original)
+++
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseCompilationProblem.java
Sun Aug 18 11:31:17 2013
@@ -62,7 +62,7 @@ public final class EclipseCompilationPro
}
public String toString() {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
sb.append(getFileName()).append(" (");
sb.append(getStartLine());
sb.append(":");
Modified:
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java
(original)
+++
commons/proper/jci/trunk/compilers/eclipse/src/main/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java
Sun Aug 18 11:31:17 2013
@@ -204,7 +204,7 @@ public final class EclipseJavaCompiler e
final INameEnvironment nameEnvironment = new INameEnvironment() {
public NameEnvironmentAnswer findType( final char[][]
pCompoundTypeName ) {
- final StringBuffer result = new StringBuffer();
+ final StringBuilder result = new StringBuilder();
for (int i = 0; i < pCompoundTypeName.length; i++) {
if (i != 0) {
result.append('.');
@@ -218,7 +218,7 @@ public final class EclipseJavaCompiler e
}
public NameEnvironmentAnswer findType( final char[] pTypeName,
final char[][] pPackageName ) {
- final StringBuffer result = new StringBuffer();
+ final StringBuilder result = new StringBuilder();
for (int i = 0; i < pPackageName.length; i++) {
result.append(pPackageName[i]);
result.append('.');
@@ -317,7 +317,7 @@ public final class EclipseJavaCompiler e
}
public boolean isPackage( char[][] parentPackageName, char[]
pPackageName ) {
- final StringBuffer result = new StringBuffer();
+ final StringBuilder result = new StringBuilder();
if (parentPackageName != null) {
for (int i = 0; i < parentPackageName.length; i++) {
if (i != 0) {
@@ -359,7 +359,7 @@ public final class EclipseJavaCompiler e
for (int i = 0; i < clazzFiles.length; i++) {
final ClassFile clazzFile = clazzFiles[i];
final char[][] compoundName =
clazzFile.getCompoundName();
- final StringBuffer clazzName = new StringBuffer();
+ final StringBuilder clazzName = new StringBuilder();
for (int j = 0; j < compoundName.length; j++) {
if (j != 0) {
clazzName.append('.');
Modified:
commons/proper/jci/trunk/compilers/janino/src/main/java/org/apache/commons/jci/compilers/JaninoCompilationProblem.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/compilers/janino/src/main/java/org/apache/commons/jci/compilers/JaninoCompilationProblem.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/compilers/janino/src/main/java/org/apache/commons/jci/compilers/JaninoCompilationProblem.java
(original)
+++
commons/proper/jci/trunk/compilers/janino/src/main/java/org/apache/commons/jci/compilers/JaninoCompilationProblem.java
Sun Aug 18 11:31:17 2013
@@ -87,7 +87,7 @@ public final class JaninoCompilationProb
}
public String toString() {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
sb.append(getFileName()).append(" (");
sb.append(getStartLine());
sb.append(":");
Modified:
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacClassLoader.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacClassLoader.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacClassLoader.java
(original)
+++
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacClassLoader.java
Sun Aug 18 11:31:17 2013
@@ -22,6 +22,7 @@ import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
+import java.lang.StringBuilder;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
@@ -78,7 +79,7 @@ public final class JavacClassLoader exte
}
}
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
sb.append("Could not find javac compiler class (should be in the
tools.jar/classes.jar in your JRE/JDK). ");
sb.append("os.name").append('=').append(System.getProperty("os.name")).append(",
");
sb.append("os.version").append('=').append(System.getProperty("os.version")).append(",
");
Modified:
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacCompilationProblem.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacCompilationProblem.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacCompilationProblem.java
(original)
+++
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacCompilationProblem.java
Sun Aug 18 11:31:17 2013
@@ -78,7 +78,7 @@ public class JavacCompilationProblem imp
}
public String toString() {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
sb.append(getFileName()).append(" (");
sb.append(getStartLine());
sb.append(":");
Modified:
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacJavaCompiler.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacJavaCompiler.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacJavaCompiler.java
(original)
+++
commons/proper/jci/trunk/compilers/javac/src/main/java/org/apache/commons/jci/compilers/JavacJavaCompiler.java
Sun Aug 18 11:31:17 2013
@@ -101,7 +101,7 @@ public final class JavacJavaCompiler ext
while (true) {
// cleanup the buffer
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
// most errors terminate with the '^' char
do {
@@ -135,11 +135,11 @@ public final class JavacJavaCompiler ext
String file = tokens.nextToken();
// When will this happen?
if (file.length() == 1) {
- file = new StringBuffer(file).append(":").append(
+ file = new StringBuilder(file).append(":").append(
tokens.nextToken()).toString();
}
final int line = Integer.parseInt(tokens.nextToken());
- final StringBuffer msgBuffer = new StringBuffer();
+ final StringBuilder msgBuffer = new StringBuilder();
String msg = tokens.nextToken(EOL).substring(2);
isError = !msg.startsWith(WARNING_PREFIX);
Modified:
commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/compilers/AbstractCompilerTestCase.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/compilers/AbstractCompilerTestCase.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/compilers/AbstractCompilerTestCase.java
(original)
+++
commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/compilers/AbstractCompilerTestCase.java
Sun Aug 18 11:31:17 2013
@@ -341,7 +341,7 @@ public abstract class AbstractCompilerTe
}
public final String toString( final CompilationProblem[] pProblems ) {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
for (int i = 0; i < pProblems.length; i++) {
final CompilationProblem problem = pProblems[i];
Modified:
commons/proper/jci/trunk/examples/src/main/java/org/apache/commons/jci/examples/serverpages/JspGenerator.java
URL:
http://svn.apache.org/viewvc/commons/proper/jci/trunk/examples/src/main/java/org/apache/commons/jci/examples/serverpages/JspGenerator.java?rev=1515087&r1=1515086&r2=1515087&view=diff
==============================================================================
---
commons/proper/jci/trunk/examples/src/main/java/org/apache/commons/jci/examples/serverpages/JspGenerator.java
(original)
+++
commons/proper/jci/trunk/examples/src/main/java/org/apache/commons/jci/examples/serverpages/JspGenerator.java
Sun Aug 18 11:31:17 2013
@@ -35,7 +35,7 @@ public final class JspGenerator {
private String quote( final String s ) {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
final char[] input = s.toCharArray();
for (int i = 0; i < input.length; i++) {
@@ -57,7 +57,7 @@ public final class JspGenerator {
return sb.toString();
}
- private void wrap( final StringBuffer pInput, final Writer pOutput )
throws IOException {
+ private void wrap( final StringBuilder pInput, final Writer pOutput )
throws IOException {
pOutput.append(" out.write(\"");
@@ -103,7 +103,7 @@ public final class JspGenerator {
final char[] open = "<?".toCharArray();
final char[] close = "?>".toCharArray();
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
char[] watch = open;
int w = 0;
while(true) {
@@ -121,7 +121,7 @@ public final class JspGenerator {
wrap(sb, output);
- sb = new StringBuffer();
+ sb = new StringBuilder();
watch = close;
} else if (watch == close) {
// found close
@@ -129,7 +129,7 @@ public final class JspGenerator {
// <? ... ?> is java
output.append(sb.toString());
- sb = new StringBuffer();
+ sb = new StringBuilder();
watch = open;
}
w = 0;
