svn commit: r1549782 - in /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2: TestPStmtPooling.java TestPoolingDriver.java

[markt]

Author: markt
Date: Tue Dec 10 08:23:22 2013
New Revision: 1549782

URL: http://svn.apache.org/r1549782
Log:
Suppress some unused code warnings in the unit tests

Modified:
    
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPStmtPooling.java
    
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDriver.java

Modified: 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPStmtPooling.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPStmtPooling.java?rev=1549782&r1=1549781&r2=1549782&view=diff
==============================================================================
--- 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPStmtPooling.java
 (original)
+++ 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPStmtPooling.java
 Tue Dec 10 08:23:22 2013
@@ -18,6 +18,7 @@
 package org.apache.commons.dbcp2;
 
 import java.sql.Connection;
+import java.sql.Driver;
 import java.sql.Statement;
 import java.sql.SQLException;
 
@@ -46,7 +47,8 @@ public class TestPStmtPooling extends Te
     }
 
     public void testStmtPool() throws Exception {
-        new TesterDriver();
+        @SuppressWarnings("unused") // Ensure TesterDriver is registered
+        Driver d = new TesterDriver();
         ConnectionFactory connFactory = new DriverManagerConnectionFactory(
                 "jdbc:apache:commons:testdriver","u1","p1");
 
@@ -70,7 +72,8 @@ public class TestPStmtPooling extends Te
     }
 
     public void testCallableStatementPooling() throws Exception {
-        new TesterDriver();
+        @SuppressWarnings("unused") // Ensure TesterDriver is registered
+        Driver d = new TesterDriver();
         ConnectionFactory connFactory = new DriverManagerConnectionFactory(
                 "jdbc:apache:commons:testdriver","u1","p1");
 
@@ -108,7 +111,8 @@ public class TestPStmtPooling extends Te
     }
 
     public void testClosePool() throws Exception {
-        new TesterDriver();
+        @SuppressWarnings("unused") // Ensure TesterDriver is registered
+        Driver d = new TesterDriver();
         ConnectionFactory connFactory = new DriverManagerConnectionFactory(
                 "jdbc:apache:commons:testdriver","u1","p1");
 

Modified: 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDriver.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDriver.java?rev=1549782&r1=1549781&r2=1549782&view=diff
==============================================================================
--- 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDriver.java
 (original)
+++ 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDriver.java
 Tue Dec 10 08:23:22 2013
@@ -24,6 +24,8 @@ import java.sql.Connection;
 import java.sql.DriverManager;
 import java.sql.SQLException;
 
+import javax.sql.DataSource;
+
 import junit.framework.Test;
 import junit.framework.TestSuite;
 
@@ -98,7 +100,8 @@ public class TestPoolingDriver extends T
         pcf.setDefaultAutoCommit(true);
         GenericObjectPool<PoolableConnection> connectionPool =
                 new GenericObjectPool<>(pcf);
-        new PoolingDataSource<>(connectionPool);
+        @SuppressWarnings("unused") // Ensure PoolingDataSource can be created
+        DataSource ds = new PoolingDataSource<>(connectionPool);
     }
 
     public void test2() {