Author: markt
Date: Mon Feb 10 13:18:32 2014
New Revision: 1566614
URL: http://svn.apache.org/r1566614
Log:
Exclude a false positive
Modified:
commons/proper/pool/trunk/findbugs-exclude-filter.xml
Modified: commons/proper/pool/trunk/findbugs-exclude-filter.xml
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/findbugs-exclude-filter.xml?rev=1566614&r1=1566613&r2=1566614&view=diff
==============================================================================
--- commons/proper/pool/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/trunk/findbugs-exclude-filter.xml Mon Feb 10 13:18:32
2014
@@ -57,6 +57,13 @@
<Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS " />
</Match>
<Match>
+ <!-- Update is inside sync block. Volatile is to ensure other threads
-->
+ <!-- can read new value.
-->
+ <Class name="org.apache.commons.pool2.impl.DefaultPooledObject" />
+ <Method name="allocate" />
+ <Bug pattern="VO_VOLATILE_INCREMENT" />
+ </Match>
+ <Match>
<!-- Ignoring the exception is deliberate since an earlier exception is
-->
<!-- more important.
-->
<Class name="org.apache.commons.pool2.impl.GenericKeyedObjectPool" />
