Author: oheger
Date: Sat May 24 13:54:17 2014
New Revision: 1597292

URL: http://svn.apache.org/r1597292
Log:
Made methods for adding and removing event listeners final.

Sub classes need to invoke these methods during construction time - and a
constructor should not invoke non-final methods. Also, it really makes
sense to have these methods final as the default implementation should be
sufficient and not changed by derived classes.

Modified:
    
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/builder/BasicConfigurationBuilder.java

Modified: 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/builder/BasicConfigurationBuilder.java
URL: 
http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/builder/BasicConfigurationBuilder.java?rev=1597292&r1=1597291&r2=1597292&view=diff
==============================================================================
--- 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/builder/BasicConfigurationBuilder.java
 (original)
+++ 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/builder/BasicConfigurationBuilder.java
 Sat May 24 13:54:17 2014
@@ -382,14 +382,14 @@ public class BasicConfigurationBuilder<T
      *         <b>null</b>
      */
     @Override
-    public <T1 extends ConfigurationBuilderEvent> void addEventListener(
+    public final  <T1 extends ConfigurationBuilderEvent> void addEventListener(
             EventType<T1> eventType, EventListener<? super T1> listener)
     {
         eventListeners.addEventListener(eventType, listener);
     }
 
     @Override
-    public <T1 extends ConfigurationBuilderEvent> void removeEventListener(
+    public final  <T1 extends ConfigurationBuilderEvent> void 
removeEventListener(
             EventType<T1> eventType, EventListener<? super T1> listener)
     {
         eventListeners.removeEventListener(eventType, listener);


Reply via email to