Modified: 
websites/production/commons/content/proper/commons-email/xref/org/apache/commons/mail/HtmlEmail.html
==============================================================================
--- 
websites/production/commons/content/proper/commons-email/xref/org/apache/commons/mail/HtmlEmail.html
 (original)
+++ 
websites/production/commons/content/proper/commons-email/xref/org/apache/commons/mail/HtmlEmail.html
 Wed Jul  9 20:46:21 2014
@@ -88,7 +88,7 @@
 <a class="jxr_linenumber" name="L80" href="#L80">80</a>  <em 
class="jxr_javadoccomment"> * method defined on the 
&lt;code&gt;DataSource&lt;/code&gt;s to make the determination.</em>
 <a class="jxr_linenumber" name="L81" href="#L81">81</a>  <em 
class="jxr_javadoccomment"> *</em>
 <a class="jxr_linenumber" name="L82" href="#L82">82</a>  <em 
class="jxr_javadoccomment"> * @since 1.0</em>
-<a class="jxr_linenumber" name="L83" href="#L83">83</a>  <em 
class="jxr_javadoccomment"> * @version $Id: HtmlEmail.java 1563555 2014-02-02 
02:51:10Z ggregory $</em>
+<a class="jxr_linenumber" name="L83" href="#L83">83</a>  <em 
class="jxr_javadoccomment"> * @version $Id: HtmlEmail.java 1606709 2014-06-30 
12:26:06Z ggregory $</em>
 <a class="jxr_linenumber" name="L84" href="#L84">84</a>  <em 
class="jxr_javadoccomment"> */</em>
 <a class="jxr_linenumber" name="L85" href="#L85">85</a>  <strong 
class="jxr_keyword">public</strong> <strong class="jxr_keyword">class</strong> 
<a href="../../../../org/apache/commons/mail/HtmlEmail.html">HtmlEmail</a> 
<strong class="jxr_keyword">extends</strong> <a 
href="../../../../org/apache/commons/mail/MultiPartEmail.html">MultiPartEmail</a>
 <a class="jxr_linenumber" name="L86" href="#L86">86</a>  {
@@ -132,7 +132,7 @@
 <a class="jxr_linenumber" name="L124" href="#L124">124</a> <em 
class="jxr_javadoccomment">     *  for definitions</em>
 <a class="jxr_linenumber" name="L125" href="#L125">125</a> <em 
class="jxr_javadoccomment">     * @since 1.0</em>
 <a class="jxr_linenumber" name="L126" href="#L126">126</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L127" href="#L127">127</a>     <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">HtmlEmail</a> 
setTextMsg(String aText) <strong class="jxr_keyword">throws</strong> 
EmailException
+<a class="jxr_linenumber" name="L127" href="#L127">127</a>     <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">HtmlEmail</a> 
setTextMsg(<strong class="jxr_keyword">final</strong> String aText) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L128" href="#L128">128</a>     {
 <a class="jxr_linenumber" name="L129" href="#L129">129</a>         <strong 
class="jxr_keyword">if</strong> (EmailUtils.isEmpty(aText))
 <a class="jxr_linenumber" name="L130" href="#L130">130</a>         {
@@ -152,7 +152,7 @@
 <a class="jxr_linenumber" name="L144" href="#L144">144</a> <em 
class="jxr_javadoccomment">     *  for definitions</em>
 <a class="jxr_linenumber" name="L145" href="#L145">145</a> <em 
class="jxr_javadoccomment">     * @since 1.0</em>
 <a class="jxr_linenumber" name="L146" href="#L146">146</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L147" href="#L147">147</a>     <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">HtmlEmail</a> 
setHtmlMsg(String aHtml) <strong class="jxr_keyword">throws</strong> 
EmailException
+<a class="jxr_linenumber" name="L147" href="#L147">147</a>     <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">HtmlEmail</a> 
setHtmlMsg(<strong class="jxr_keyword">final</strong> String aHtml) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L148" href="#L148">148</a>     {
 <a class="jxr_linenumber" name="L149" href="#L149">149</a>         <strong 
class="jxr_keyword">if</strong> (EmailUtils.isEmpty(aHtml))
 <a class="jxr_linenumber" name="L150" href="#L150">150</a>         {
@@ -179,7 +179,7 @@
 <a class="jxr_linenumber" name="L171" href="#L171">171</a> <em 
class="jxr_javadoccomment">     * @since 1.0</em>
 <a class="jxr_linenumber" name="L172" href="#L172">172</a> <em 
class="jxr_javadoccomment">     */</em>
 <a class="jxr_linenumber" name="L173" href="#L173">173</a>     @Override
-<a class="jxr_linenumber" name="L174" href="#L174">174</a>     <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/Email.html">Email</a> setMsg(String 
msg) <strong class="jxr_keyword">throws</strong> EmailException
+<a class="jxr_linenumber" name="L174" href="#L174">174</a>     <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/Email.html">Email</a> setMsg(<strong 
class="jxr_keyword">final</strong> String msg) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L175" href="#L175">175</a>     {
 <a class="jxr_linenumber" name="L176" href="#L176">176</a>         <strong 
class="jxr_keyword">if</strong> (EmailUtils.isEmpty(msg))
 <a class="jxr_linenumber" name="L177" href="#L177">177</a>         {
@@ -188,7 +188,7 @@
 <a class="jxr_linenumber" name="L180" href="#L180">180</a> 
 <a class="jxr_linenumber" name="L181" href="#L181">181</a>         
setTextMsg(msg);
 <a class="jxr_linenumber" name="L182" href="#L182">182</a> 
-<a class="jxr_linenumber" name="L183" href="#L183">183</a>         
StringBuffer htmlMsgBuf = <strong class="jxr_keyword">new</strong> StringBuffer(
+<a class="jxr_linenumber" name="L183" href="#L183">183</a>         <strong 
class="jxr_keyword">final</strong> StringBuffer htmlMsgBuf = <strong 
class="jxr_keyword">new</strong> StringBuffer(
 <a class="jxr_linenumber" name="L184" href="#L184">184</a>             
msg.length()
 <a class="jxr_linenumber" name="L185" href="#L185">185</a>             + 
HTML_MESSAGE_START.length()
 <a class="jxr_linenumber" name="L186" href="#L186">186</a>             + 
HTML_MESSAGE_END.length()
@@ -216,13 +216,13 @@
 <a class="jxr_linenumber" name="L208" href="#L208">208</a> <em 
class="jxr_javadoccomment">     * @see #embed(URL, String)</em>
 <a class="jxr_linenumber" name="L209" href="#L209">209</a> <em 
class="jxr_javadoccomment">     * @since 1.1</em>
 <a class="jxr_linenumber" name="L210" href="#L210">210</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L211" href="#L211">211</a>     <strong 
class="jxr_keyword">public</strong> String embed(String urlString, String name) 
<strong class="jxr_keyword">throws</strong> EmailException
+<a class="jxr_linenumber" name="L211" href="#L211">211</a>     <strong 
class="jxr_keyword">public</strong> String embed(<strong 
class="jxr_keyword">final</strong> String urlString, <strong 
class="jxr_keyword">final</strong> String name) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L212" href="#L212">212</a>     {
 <a class="jxr_linenumber" name="L213" href="#L213">213</a>         <strong 
class="jxr_keyword">try</strong>
 <a class="jxr_linenumber" name="L214" href="#L214">214</a>         {
 <a class="jxr_linenumber" name="L215" href="#L215">215</a>             <strong 
class="jxr_keyword">return</strong> embed(<strong 
class="jxr_keyword">new</strong> URL(urlString), name);
 <a class="jxr_linenumber" name="L216" href="#L216">216</a>         }
-<a class="jxr_linenumber" name="L217" href="#L217">217</a>         <strong 
class="jxr_keyword">catch</strong> (MalformedURLException e)
+<a class="jxr_linenumber" name="L217" href="#L217">217</a>         <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
MalformedURLException e)
 <a class="jxr_linenumber" name="L218" href="#L218">218</a>         {
 <a class="jxr_linenumber" name="L219" href="#L219">219</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(<span
 class="jxr_string">"Invalid URL"</span>, e);
 <a class="jxr_linenumber" name="L220" href="#L220">220</a>         }
@@ -260,7 +260,7 @@
 <a class="jxr_linenumber" name="L252" href="#L252">252</a> <em 
class="jxr_javadoccomment">     * or empty; also see {@link 
javax.mail.internet.MimeBodyPart} for definitions</em>
 <a class="jxr_linenumber" name="L253" href="#L253">253</a> <em 
class="jxr_javadoccomment">     * @since 1.0</em>
 <a class="jxr_linenumber" name="L254" href="#L254">254</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L255" href="#L255">255</a>     <strong 
class="jxr_keyword">public</strong> String embed(URL url, String name) <strong 
class="jxr_keyword">throws</strong> EmailException
+<a class="jxr_linenumber" name="L255" href="#L255">255</a>     <strong 
class="jxr_keyword">public</strong> String embed(<strong 
class="jxr_keyword">final</strong> URL url, <strong 
class="jxr_keyword">final</strong> String name) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L256" href="#L256">256</a>     {
 <a class="jxr_linenumber" name="L257" href="#L257">257</a>         <strong 
class="jxr_keyword">if</strong> (EmailUtils.isEmpty(name))
 <a class="jxr_linenumber" name="L258" href="#L258">258</a>         {
@@ -271,8 +271,8 @@
 <a class="jxr_linenumber" name="L263" href="#L263">263</a>         <em 
class="jxr_comment">// if so, return the cached CID value.</em>
 <a class="jxr_linenumber" name="L264" href="#L264">264</a>         <strong 
class="jxr_keyword">if</strong> (inlineEmbeds.containsKey(name))
 <a class="jxr_linenumber" name="L265" href="#L265">265</a>         {
-<a class="jxr_linenumber" name="L266" href="#L266">266</a>             <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
inlineEmbeds.get(name);
-<a class="jxr_linenumber" name="L267" href="#L267">267</a>             
URLDataSource urlDataSource = (URLDataSource) ii.getDataSource();
+<a class="jxr_linenumber" name="L266" href="#L266">266</a>             <strong 
class="jxr_keyword">final</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
inlineEmbeds.get(name);
+<a class="jxr_linenumber" name="L267" href="#L267">267</a>             <strong 
class="jxr_keyword">final</strong> URLDataSource urlDataSource = 
(URLDataSource) ii.getDataSource();
 <a class="jxr_linenumber" name="L268" href="#L268">268</a>             <em 
class="jxr_comment">// make sure the supplied URL points to the same thing</em>
 <a class="jxr_linenumber" name="L269" href="#L269">269</a>             <em 
class="jxr_comment">// as the one already associated with this name.</em>
 <a class="jxr_linenumber" name="L270" href="#L270">270</a>             <em 
class="jxr_comment">// NOTE: Comparing URLs with URL.equals() is a blocking 
operation</em>
@@ -296,7 +296,7 @@
 <a class="jxr_linenumber" name="L288" href="#L288">288</a>         {
 <a class="jxr_linenumber" name="L289" href="#L289">289</a>             is = 
url.openStream();
 <a class="jxr_linenumber" name="L290" href="#L290">290</a>         }
-<a class="jxr_linenumber" name="L291" href="#L291">291</a>         <strong 
class="jxr_keyword">catch</strong> (IOException e)
+<a class="jxr_linenumber" name="L291" href="#L291">291</a>         <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
IOException e)
 <a class="jxr_linenumber" name="L292" href="#L292">292</a>         {
 <a class="jxr_linenumber" name="L293" href="#L293">293</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(<span
 class="jxr_string">"Invalid URL"</span>, e);
 <a class="jxr_linenumber" name="L294" href="#L294">294</a>         }
@@ -309,7 +309,7 @@
 <a class="jxr_linenumber" name="L301" href="#L301">301</a>                     
is.close();
 <a class="jxr_linenumber" name="L302" href="#L302">302</a>                 }
 <a class="jxr_linenumber" name="L303" href="#L303">303</a>             }
-<a class="jxr_linenumber" name="L304" href="#L304">304</a>             <strong 
class="jxr_keyword">catch</strong> (IOException ioe) <em class="jxr_comment">// 
NOPMD</em>
+<a class="jxr_linenumber" name="L304" href="#L304">304</a>             <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
IOException ioe) <em class="jxr_comment">// NOPMD</em>
 <a class="jxr_linenumber" name="L305" href="#L305">305</a>             { <em 
class="jxr_comment">/* sigh */</em> }
 <a class="jxr_linenumber" name="L306" href="#L306">306</a>         }
 <a class="jxr_linenumber" name="L307" href="#L307">307</a> 
@@ -328,9 +328,9 @@
 <a class="jxr_linenumber" name="L320" href="#L320">320</a> <em 
class="jxr_javadoccomment">     * @see #embed(File, String)</em>
 <a class="jxr_linenumber" name="L321" href="#L321">321</a> <em 
class="jxr_javadoccomment">     * @since 1.1</em>
 <a class="jxr_linenumber" name="L322" href="#L322">322</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L323" href="#L323">323</a>     <strong 
class="jxr_keyword">public</strong> String embed(File file) <strong 
class="jxr_keyword">throws</strong> EmailException
+<a class="jxr_linenumber" name="L323" href="#L323">323</a>     <strong 
class="jxr_keyword">public</strong> String embed(<strong 
class="jxr_keyword">final</strong> File file) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L324" href="#L324">324</a>     {
-<a class="jxr_linenumber" name="L325" href="#L325">325</a>         String cid 
= EmailUtils.randomAlphabetic(HtmlEmail.CID_LENGTH).toLowerCase(Locale.ENGLISH);
+<a class="jxr_linenumber" name="L325" href="#L325">325</a>         <strong 
class="jxr_keyword">final</strong> String cid = 
EmailUtils.randomAlphabetic(HtmlEmail.CID_LENGTH).toLowerCase(Locale.ENGLISH);
 <a class="jxr_linenumber" name="L326" href="#L326">326</a>         <strong 
class="jxr_keyword">return</strong> embed(file, cid);
 <a class="jxr_linenumber" name="L327" href="#L327">327</a>     }
 <a class="jxr_linenumber" name="L328" href="#L328">328</a> 
@@ -359,7 +359,7 @@
 <a class="jxr_linenumber" name="L351" href="#L351">351</a> <em 
class="jxr_javadoccomment">     *  also see {@link 
javax.mail.internet.MimeBodyPart} for definitions</em>
 <a class="jxr_linenumber" name="L352" href="#L352">352</a> <em 
class="jxr_javadoccomment">     * @since 1.1</em>
 <a class="jxr_linenumber" name="L353" href="#L353">353</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L354" href="#L354">354</a>     <strong 
class="jxr_keyword">public</strong> String embed(File file, String cid) <strong 
class="jxr_keyword">throws</strong> EmailException
+<a class="jxr_linenumber" name="L354" href="#L354">354</a>     <strong 
class="jxr_keyword">public</strong> String embed(<strong 
class="jxr_keyword">final</strong> File file, <strong 
class="jxr_keyword">final</strong> String cid) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L355" href="#L355">355</a>     {
 <a class="jxr_linenumber" name="L356" href="#L356">356</a>         <strong 
class="jxr_keyword">if</strong> (EmailUtils.isEmpty(file.getName()))
 <a class="jxr_linenumber" name="L357" href="#L357">357</a>         {
@@ -372,7 +372,7 @@
 <a class="jxr_linenumber" name="L364" href="#L364">364</a>         {
 <a class="jxr_linenumber" name="L365" href="#L365">365</a>             
filePath = file.getCanonicalPath();
 <a class="jxr_linenumber" name="L366" href="#L366">366</a>         }
-<a class="jxr_linenumber" name="L367" href="#L367">367</a>         <strong 
class="jxr_keyword">catch</strong> (IOException ioe)
+<a class="jxr_linenumber" name="L367" href="#L367">367</a>         <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
IOException ioe)
 <a class="jxr_linenumber" name="L368" href="#L368">368</a>         {
 <a class="jxr_linenumber" name="L369" href="#L369">369</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(<span
 class="jxr_string">"couldn't get canonical path for "</span>
 <a class="jxr_linenumber" name="L370" href="#L370">370</a>                     
+ file.getName(), ioe);
@@ -382,8 +382,8 @@
 <a class="jxr_linenumber" name="L374" href="#L374">374</a>         <em 
class="jxr_comment">// if so, return the cached CID value.</em>
 <a class="jxr_linenumber" name="L375" href="#L375">375</a>         <strong 
class="jxr_keyword">if</strong> (inlineEmbeds.containsKey(file.getName()))
 <a class="jxr_linenumber" name="L376" href="#L376">376</a>         {
-<a class="jxr_linenumber" name="L377" href="#L377">377</a>             <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
inlineEmbeds.get(file.getName());
-<a class="jxr_linenumber" name="L378" href="#L378">378</a>             
FileDataSource fileDataSource = (FileDataSource) ii.getDataSource();
+<a class="jxr_linenumber" name="L377" href="#L377">377</a>             <strong 
class="jxr_keyword">final</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
inlineEmbeds.get(file.getName());
+<a class="jxr_linenumber" name="L378" href="#L378">378</a>             <strong 
class="jxr_keyword">final</strong> FileDataSource fileDataSource = 
(FileDataSource) ii.getDataSource();
 <a class="jxr_linenumber" name="L379" href="#L379">379</a>             <em 
class="jxr_comment">// make sure the supplied file has the same canonical 
path</em>
 <a class="jxr_linenumber" name="L380" href="#L380">380</a>             <em 
class="jxr_comment">// as the one already associated with this name.</em>
 <a class="jxr_linenumber" name="L381" href="#L381">381</a>             String 
existingFilePath = <strong class="jxr_keyword">null</strong>;
@@ -391,7 +391,7 @@
 <a class="jxr_linenumber" name="L383" href="#L383">383</a>             {
 <a class="jxr_linenumber" name="L384" href="#L384">384</a>                 
existingFilePath = fileDataSource.getFile().getCanonicalPath();
 <a class="jxr_linenumber" name="L385" href="#L385">385</a>             }
-<a class="jxr_linenumber" name="L386" href="#L386">386</a>             <strong 
class="jxr_keyword">catch</strong> (IOException ioe)
+<a class="jxr_linenumber" name="L386" href="#L386">386</a>             <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
IOException ioe)
 <a class="jxr_linenumber" name="L387" href="#L387">387</a>             {
 <a class="jxr_linenumber" name="L388" href="#L388">388</a>                 
<strong class="jxr_keyword">throw</strong> <strong 
class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(<span
 class="jxr_string">"couldn't get canonical path for file "</span>
 <a class="jxr_linenumber" name="L389" href="#L389">389</a>                     
    + fileDataSource.getFile().getName()
@@ -438,13 +438,13 @@
 <a class="jxr_linenumber" name="L430" href="#L430">430</a> <em 
class="jxr_javadoccomment">     * @see #embed(DataSource, String, String)</em>
 <a class="jxr_linenumber" name="L431" href="#L431">431</a> <em 
class="jxr_javadoccomment">     * @since 1.1</em>
 <a class="jxr_linenumber" name="L432" href="#L432">432</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L433" href="#L433">433</a>     <strong 
class="jxr_keyword">public</strong> String embed(DataSource dataSource, String 
name) <strong class="jxr_keyword">throws</strong> EmailException
+<a class="jxr_linenumber" name="L433" href="#L433">433</a>     <strong 
class="jxr_keyword">public</strong> String embed(<strong 
class="jxr_keyword">final</strong> DataSource dataSource, <strong 
class="jxr_keyword">final</strong> String name) <strong 
class="jxr_keyword">throws</strong> EmailException
 <a class="jxr_linenumber" name="L434" href="#L434">434</a>     {
 <a class="jxr_linenumber" name="L435" href="#L435">435</a>         <em 
class="jxr_comment">// check if the DataSource has already been attached;</em>
 <a class="jxr_linenumber" name="L436" href="#L436">436</a>         <em 
class="jxr_comment">// if so, return the cached CID value.</em>
 <a class="jxr_linenumber" name="L437" href="#L437">437</a>         <strong 
class="jxr_keyword">if</strong> (inlineEmbeds.containsKey(name))
 <a class="jxr_linenumber" name="L438" href="#L438">438</a>         {
-<a class="jxr_linenumber" name="L439" href="#L439">439</a>             <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
inlineEmbeds.get(name);
+<a class="jxr_linenumber" name="L439" href="#L439">439</a>             <strong 
class="jxr_keyword">final</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
inlineEmbeds.get(name);
 <a class="jxr_linenumber" name="L440" href="#L440">440</a>             <em 
class="jxr_comment">// make sure the supplied URL points to the same thing</em>
 <a class="jxr_linenumber" name="L441" href="#L441">441</a>             <em 
class="jxr_comment">// as the one already associated with this name.</em>
 <a class="jxr_linenumber" name="L442" href="#L442">442</a>             <strong 
class="jxr_keyword">if</strong> (dataSource.equals(ii.getDataSource()))
@@ -459,7 +459,7 @@
 <a class="jxr_linenumber" name="L451" href="#L451">451</a>             }
 <a class="jxr_linenumber" name="L452" href="#L452">452</a>         }
 <a class="jxr_linenumber" name="L453" href="#L453">453</a> 
-<a class="jxr_linenumber" name="L454" href="#L454">454</a>         String cid 
= EmailUtils.randomAlphabetic(HtmlEmail.CID_LENGTH).toLowerCase();
+<a class="jxr_linenumber" name="L454" href="#L454">454</a>         <strong 
class="jxr_keyword">final</strong> String cid = 
EmailUtils.randomAlphabetic(HtmlEmail.CID_LENGTH).toLowerCase();
 <a class="jxr_linenumber" name="L455" href="#L455">455</a>         <strong 
class="jxr_keyword">return</strong> embed(dataSource, name, cid);
 <a class="jxr_linenumber" name="L456" href="#L456">456</a>     }
 <a class="jxr_linenumber" name="L457" href="#L457">457</a> 
@@ -475,7 +475,7 @@
 <a class="jxr_linenumber" name="L467" href="#L467">467</a> <em 
class="jxr_javadoccomment">     * null or empty</em>
 <a class="jxr_linenumber" name="L468" href="#L468">468</a> <em 
class="jxr_javadoccomment">     * @since 1.1</em>
 <a class="jxr_linenumber" name="L469" href="#L469">469</a> <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L470" href="#L470">470</a>     <strong 
class="jxr_keyword">public</strong> String embed(DataSource dataSource, String 
name, String cid)
+<a class="jxr_linenumber" name="L470" href="#L470">470</a>     <strong 
class="jxr_keyword">public</strong> String embed(<strong 
class="jxr_keyword">final</strong> DataSource dataSource, <strong 
class="jxr_keyword">final</strong> String name, String cid)
 <a class="jxr_linenumber" name="L471" href="#L471">471</a>         <strong 
class="jxr_keyword">throws</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>
 <a class="jxr_linenumber" name="L472" href="#L472">472</a>     {
 <a class="jxr_linenumber" name="L473" href="#L473">473</a>         <strong 
class="jxr_keyword">if</strong> (EmailUtils.isEmpty(name))
@@ -483,7 +483,7 @@
 <a class="jxr_linenumber" name="L475" href="#L475">475</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(<span
 class="jxr_string">"name cannot be null or empty"</span>);
 <a class="jxr_linenumber" name="L476" href="#L476">476</a>         }
 <a class="jxr_linenumber" name="L477" href="#L477">477</a> 
-<a class="jxr_linenumber" name="L478" href="#L478">478</a>         
MimeBodyPart mbp = <strong class="jxr_keyword">new</strong> MimeBodyPart();
+<a class="jxr_linenumber" name="L478" href="#L478">478</a>         <strong 
class="jxr_keyword">final</strong> MimeBodyPart mbp = <strong 
class="jxr_keyword">new</strong> MimeBodyPart();
 <a class="jxr_linenumber" name="L479" href="#L479">479</a> 
 <a class="jxr_linenumber" name="L480" href="#L480">480</a>         <strong 
class="jxr_keyword">try</strong>
 <a class="jxr_linenumber" name="L481" href="#L481">481</a>         {
@@ -495,16 +495,16 @@
 <a class="jxr_linenumber" name="L487" href="#L487">487</a>             
mbp.setDisposition(EmailAttachment.INLINE);
 <a class="jxr_linenumber" name="L488" href="#L488">488</a>             
mbp.setContentID(<span class="jxr_string">"&lt;"</span> + cid + <span 
class="jxr_string">"&gt;"</span>);
 <a class="jxr_linenumber" name="L489" href="#L489">489</a> 
-<a class="jxr_linenumber" name="L490" href="#L490">490</a>             <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
<strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a>(cid, 
dataSource, mbp);
+<a class="jxr_linenumber" name="L490" href="#L490">490</a>             <strong 
class="jxr_keyword">final</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> ii = 
<strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a>(cid, 
dataSource, mbp);
 <a class="jxr_linenumber" name="L491" href="#L491">491</a>             <strong 
class="jxr_keyword">this</strong>.inlineEmbeds.put(name, ii);
 <a class="jxr_linenumber" name="L492" href="#L492">492</a> 
 <a class="jxr_linenumber" name="L493" href="#L493">493</a>             <strong 
class="jxr_keyword">return</strong> cid;
 <a class="jxr_linenumber" name="L494" href="#L494">494</a>         }
-<a class="jxr_linenumber" name="L495" href="#L495">495</a>         <strong 
class="jxr_keyword">catch</strong> (MessagingException me)
+<a class="jxr_linenumber" name="L495" href="#L495">495</a>         <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
MessagingException me)
 <a class="jxr_linenumber" name="L496" href="#L496">496</a>         {
 <a class="jxr_linenumber" name="L497" href="#L497">497</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(me);
 <a class="jxr_linenumber" name="L498" href="#L498">498</a>         }
-<a class="jxr_linenumber" name="L499" href="#L499">499</a>         <strong 
class="jxr_keyword">catch</strong> (UnsupportedEncodingException uee)
+<a class="jxr_linenumber" name="L499" href="#L499">499</a>         <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
UnsupportedEncodingException uee)
 <a class="jxr_linenumber" name="L500" href="#L500">500</a>         {
 <a class="jxr_linenumber" name="L501" href="#L501">501</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(uee);
 <a class="jxr_linenumber" name="L502" href="#L502">502</a>         }
@@ -526,7 +526,7 @@
 <a class="jxr_linenumber" name="L518" href="#L518">518</a>         {
 <a class="jxr_linenumber" name="L519" href="#L519">519</a>             build();
 <a class="jxr_linenumber" name="L520" href="#L520">520</a>         }
-<a class="jxr_linenumber" name="L521" href="#L521">521</a>         <strong 
class="jxr_keyword">catch</strong> (MessagingException me)
+<a class="jxr_linenumber" name="L521" href="#L521">521</a>         <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
MessagingException me)
 <a class="jxr_linenumber" name="L522" href="#L522">522</a>         {
 <a class="jxr_linenumber" name="L523" href="#L523">523</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(me);
 <a class="jxr_linenumber" name="L524" href="#L524">524</a>         }
@@ -539,7 +539,7 @@
 <a class="jxr_linenumber" name="L531" href="#L531">531</a> <em 
class="jxr_javadoccomment">     */</em>
 <a class="jxr_linenumber" name="L532" href="#L532">532</a>     <strong 
class="jxr_keyword">private</strong> <strong class="jxr_keyword">void</strong> 
build() <strong class="jxr_keyword">throws</strong> MessagingException, 
EmailException
 <a class="jxr_linenumber" name="L533" href="#L533">533</a>     {
-<a class="jxr_linenumber" name="L534" href="#L534">534</a>         
MimeMultipart rootContainer = <strong 
class="jxr_keyword">this</strong>.getContainer();
+<a class="jxr_linenumber" name="L534" href="#L534">534</a>         <strong 
class="jxr_keyword">final</strong> MimeMultipart rootContainer = <strong 
class="jxr_keyword">this</strong>.getContainer();
 <a class="jxr_linenumber" name="L535" href="#L535">535</a>         
MimeMultipart bodyEmbedsContainer = rootContainer;
 <a class="jxr_linenumber" name="L536" href="#L536">536</a>         
MimeMultipart bodyContainer = rootContainer;
 <a class="jxr_linenumber" name="L537" href="#L537">537</a>         
MimeBodyPart msgHtml = <strong class="jxr_keyword">null</strong>;
@@ -560,13 +560,13 @@
 <a class="jxr_linenumber" name="L552" href="#L552">552</a>             <strong 
class="jxr_keyword">if</strong> (EmailUtils.isNotEmpty(<strong 
class="jxr_keyword">this</strong>.text))
 <a class="jxr_linenumber" name="L553" href="#L553">553</a>             {
 <a class="jxr_linenumber" name="L554" href="#L554">554</a>                 
bodyContainer = <strong class="jxr_keyword">new</strong> MimeMultipart(<span 
class="jxr_string">"alternative"</span>);
-<a class="jxr_linenumber" name="L555" href="#L555">555</a>                 
BodyPart bodyPart = createBodyPart();
+<a class="jxr_linenumber" name="L555" href="#L555">555</a>                 
<strong class="jxr_keyword">final</strong> BodyPart bodyPart = createBodyPart();
 <a class="jxr_linenumber" name="L556" href="#L556">556</a>                 
<strong class="jxr_keyword">try</strong>
 <a class="jxr_linenumber" name="L557" href="#L557">557</a>                 {
 <a class="jxr_linenumber" name="L558" href="#L558">558</a>                     
bodyPart.setContent(bodyContainer);
 <a class="jxr_linenumber" name="L559" href="#L559">559</a>                     
bodyEmbedsContainer.addBodyPart(bodyPart, 0);
 <a class="jxr_linenumber" name="L560" href="#L560">560</a>                 }
-<a class="jxr_linenumber" name="L561" href="#L561">561</a>                 
<strong class="jxr_keyword">catch</strong> (MessagingException me)
+<a class="jxr_linenumber" name="L561" href="#L561">561</a>                 
<strong class="jxr_keyword">catch</strong> (<strong 
class="jxr_keyword">final</strong> MessagingException me)
 <a class="jxr_linenumber" name="L562" href="#L562">562</a>                 {
 <a class="jxr_linenumber" name="L563" href="#L563">563</a>                     
<strong class="jxr_keyword">throw</strong> <strong 
class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(me);
 <a class="jxr_linenumber" name="L564" href="#L564">564</a>                 }
@@ -588,7 +588,7 @@
 <a class="jxr_linenumber" name="L580" href="#L580">580</a>             <em 
class="jxr_comment">//            (property "mail.mime.charset") in case none 
has been set</em>
 <a class="jxr_linenumber" name="L581" href="#L581">581</a>             
msgHtml.setText(<strong class="jxr_keyword">this</strong>.html, <strong 
class="jxr_keyword">this</strong>.charset, EmailConstants.TEXT_SUBTYPE_HTML);
 <a class="jxr_linenumber" name="L582" href="#L582">582</a> 
-<a class="jxr_linenumber" name="L583" href="#L583">583</a>             <strong 
class="jxr_keyword">for</strong> (InlineImage image : <strong 
class="jxr_keyword">this</strong>.inlineEmbeds.values())
+<a class="jxr_linenumber" name="L583" href="#L583">583</a>             <strong 
class="jxr_keyword">for</strong> (<strong class="jxr_keyword">final</strong> 
InlineImage image : <strong 
class="jxr_keyword">this</strong>.inlineEmbeds.values())
 <a class="jxr_linenumber" name="L584" href="#L584">584</a>             {
 <a class="jxr_linenumber" name="L585" href="#L585">585</a>                 
bodyEmbedsContainer.addBodyPart(image.getMbp());
 <a class="jxr_linenumber" name="L586" href="#L586">586</a>             }
@@ -613,11 +613,11 @@
 <a class="jxr_linenumber" name="L605" href="#L605">605</a>     <strong 
class="jxr_keyword">private</strong> <strong 
class="jxr_keyword">static</strong> <strong class="jxr_keyword">class</strong> 
<a href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a>
 <a class="jxr_linenumber" name="L606" href="#L606">606</a>     {
 <a class="jxr_linenumber" name="L607" href="#L607">607</a>         <em 
class="jxr_javadoccomment">/** content id. */</em>
-<a class="jxr_linenumber" name="L608" href="#L608">608</a>         <strong 
class="jxr_keyword">private</strong> String cid;
+<a class="jxr_linenumber" name="L608" href="#L608">608</a>         <strong 
class="jxr_keyword">private</strong> <strong class="jxr_keyword">final</strong> 
String cid;
 <a class="jxr_linenumber" name="L609" href="#L609">609</a>         <em 
class="jxr_javadoccomment">/** &lt;code&gt;DataSource&lt;/code&gt; for the 
content. */</em>
-<a class="jxr_linenumber" name="L610" href="#L610">610</a>         <strong 
class="jxr_keyword">private</strong> DataSource dataSource;
+<a class="jxr_linenumber" name="L610" href="#L610">610</a>         <strong 
class="jxr_keyword">private</strong> <strong class="jxr_keyword">final</strong> 
DataSource dataSource;
 <a class="jxr_linenumber" name="L611" href="#L611">611</a>         <em 
class="jxr_javadoccomment">/** the &lt;code&gt;MimeBodyPart&lt;/code&gt; that 
contains the encoded data. */</em>
-<a class="jxr_linenumber" name="L612" href="#L612">612</a>         <strong 
class="jxr_keyword">private</strong> MimeBodyPart mbp;
+<a class="jxr_linenumber" name="L612" href="#L612">612</a>         <strong 
class="jxr_keyword">private</strong> <strong class="jxr_keyword">final</strong> 
MimeBodyPart mbp;
 <a class="jxr_linenumber" name="L613" href="#L613">613</a> 
 <a class="jxr_linenumber" name="L614" href="#L614">614</a>         <em 
class="jxr_javadoccomment">/**</em>
 <a class="jxr_linenumber" name="L615" href="#L615">615</a> <em 
class="jxr_javadoccomment">         * Creates an InlineImage object to 
represent the</em>
@@ -627,7 +627,7 @@
 <a class="jxr_linenumber" name="L619" href="#L619">619</a> <em 
class="jxr_javadoccomment">         * @param mbp the 
&lt;code&gt;MimeBodyPart&lt;/code&gt; that contains the encoded</em>
 <a class="jxr_linenumber" name="L620" href="#L620">620</a> <em 
class="jxr_javadoccomment">         * data</em>
 <a class="jxr_linenumber" name="L621" href="#L621">621</a> <em 
class="jxr_javadoccomment">         */</em>
-<a class="jxr_linenumber" name="L622" href="#L622">622</a>         <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a>(String
 cid, DataSource dataSource, MimeBodyPart mbp)
+<a class="jxr_linenumber" name="L622" href="#L622">622</a>         <strong 
class="jxr_keyword">public</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a>(<strong
 class="jxr_keyword">final</strong> String cid, <strong 
class="jxr_keyword">final</strong> DataSource dataSource, <strong 
class="jxr_keyword">final</strong> MimeBodyPart mbp)
 <a class="jxr_linenumber" name="L623" href="#L623">623</a>         {
 <a class="jxr_linenumber" name="L624" href="#L624">624</a>             <strong 
class="jxr_keyword">this</strong>.cid = cid;
 <a class="jxr_linenumber" name="L625" href="#L625">625</a>             <strong 
class="jxr_keyword">this</strong>.dataSource = dataSource;
@@ -670,7 +670,7 @@
 <a class="jxr_linenumber" name="L662" href="#L662">662</a> <em 
class="jxr_javadoccomment">         * @return true if the other object is also 
an InlineImage with the same cid.</em>
 <a class="jxr_linenumber" name="L663" href="#L663">663</a> <em 
class="jxr_javadoccomment">         */</em>
 <a class="jxr_linenumber" name="L664" href="#L664">664</a>         @Override
-<a class="jxr_linenumber" name="L665" href="#L665">665</a>         <strong 
class="jxr_keyword">public</strong> <strong 
class="jxr_keyword">boolean</strong> equals(Object obj)
+<a class="jxr_linenumber" name="L665" href="#L665">665</a>         <strong 
class="jxr_keyword">public</strong> <strong 
class="jxr_keyword">boolean</strong> equals(<strong 
class="jxr_keyword">final</strong> Object obj)
 <a class="jxr_linenumber" name="L666" href="#L666">666</a>         {
 <a class="jxr_linenumber" name="L667" href="#L667">667</a>             <strong 
class="jxr_keyword">if</strong> (<strong class="jxr_keyword">this</strong> == 
obj)
 <a class="jxr_linenumber" name="L668" href="#L668">668</a>             {
@@ -681,7 +681,7 @@
 <a class="jxr_linenumber" name="L673" href="#L673">673</a>                 
<strong class="jxr_keyword">return</strong> false;
 <a class="jxr_linenumber" name="L674" href="#L674">674</a>             }
 <a class="jxr_linenumber" name="L675" href="#L675">675</a> 
-<a class="jxr_linenumber" name="L676" href="#L676">676</a>             <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> that 
= (InlineImage) obj;
+<a class="jxr_linenumber" name="L676" href="#L676">676</a>             <strong 
class="jxr_keyword">final</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">InlineImage</a> that 
= (InlineImage) obj;
 <a class="jxr_linenumber" name="L677" href="#L677">677</a> 
 <a class="jxr_linenumber" name="L678" href="#L678">678</a>             <strong 
class="jxr_keyword">return</strong> <strong 
class="jxr_keyword">this</strong>.cid.equals(that.cid);
 <a class="jxr_linenumber" name="L679" href="#L679">679</a>         }

Modified: 
websites/production/commons/content/proper/commons-email/xref/org/apache/commons/mail/ImageHtmlEmail.html
==============================================================================
--- 
websites/production/commons/content/proper/commons-email/xref/org/apache/commons/mail/ImageHtmlEmail.html
 (original)
+++ 
websites/production/commons/content/proper/commons-email/xref/org/apache/commons/mail/ImageHtmlEmail.html
 Wed Jul  9 20:46:21 2014
@@ -49,7 +49,7 @@
 <a class="jxr_linenumber" name="L41" href="#L41">41</a>  <em 
class="jxr_javadoccomment"> * &lt;/p&gt;</em>
 <a class="jxr_linenumber" name="L42" href="#L42">42</a>  <em 
class="jxr_javadoccomment"> *</em>
 <a class="jxr_linenumber" name="L43" href="#L43">43</a>  <em 
class="jxr_javadoccomment"> * @since 1.3</em>
-<a class="jxr_linenumber" name="L44" href="#L44">44</a>  <em 
class="jxr_javadoccomment"> * @version $Id: ImageHtmlEmail.java 1563555 
2014-02-02 02:51:10Z ggregory $</em>
+<a class="jxr_linenumber" name="L44" href="#L44">44</a>  <em 
class="jxr_javadoccomment"> * @version $Id: ImageHtmlEmail.java 1606709 
2014-06-30 12:26:06Z ggregory $</em>
 <a class="jxr_linenumber" name="L45" href="#L45">45</a>  <em 
class="jxr_javadoccomment"> */</em>
 <a class="jxr_linenumber" name="L46" href="#L46">46</a>  <strong 
class="jxr_keyword">public</strong> <strong class="jxr_keyword">class</strong> 
<a 
href="../../../../org/apache/commons/mail/ImageHtmlEmail.html">ImageHtmlEmail</a>
 <strong class="jxr_keyword">extends</strong> <a 
href="../../../../org/apache/commons/mail/HtmlEmail.html">HtmlEmail</a>
 <a class="jxr_linenumber" name="L47" href="#L47">47</a>  {
@@ -93,7 +93,7 @@
 <a class="jxr_linenumber" name="L85" href="#L85">85</a>  <em 
class="jxr_javadoccomment">     *</em>
 <a class="jxr_linenumber" name="L86" href="#L86">86</a>  <em 
class="jxr_javadoccomment">     * @param dataSourceResolver the resolver</em>
 <a class="jxr_linenumber" name="L87" href="#L87">87</a>  <em 
class="jxr_javadoccomment">     */</em>
-<a class="jxr_linenumber" name="L88" href="#L88">88</a>      <strong 
class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> 
setDataSourceResolver(<a 
href="../../../../org/apache/commons/mail/DataSourceResolver.html">DataSourceResolver</a>
 dataSourceResolver)
+<a class="jxr_linenumber" name="L88" href="#L88">88</a>      <strong 
class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> 
setDataSourceResolver(<strong class="jxr_keyword">final</strong> <a 
href="../../../../org/apache/commons/mail/DataSourceResolver.html">DataSourceResolver</a>
 dataSourceResolver)
 <a class="jxr_linenumber" name="L89" href="#L89">89</a>      {
 <a class="jxr_linenumber" name="L90" href="#L90">90</a>          <strong 
class="jxr_keyword">this</strong>.dataSourceResolver = dataSourceResolver;
 <a class="jxr_linenumber" name="L91" href="#L91">91</a>      }
@@ -115,7 +115,7 @@
 <a class="jxr_linenumber" name="L107" href="#L107">107</a>             
setHtmlMsg(temp);
 <a class="jxr_linenumber" name="L108" href="#L108">108</a>             <strong 
class="jxr_keyword">super</strong>.buildMimeMessage();
 <a class="jxr_linenumber" name="L109" href="#L109">109</a>         }
-<a class="jxr_linenumber" name="L110" href="#L110">110</a>         <strong 
class="jxr_keyword">catch</strong> (IOException e)
+<a class="jxr_linenumber" name="L110" href="#L110">110</a>         <strong 
class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> 
IOException e)
 <a class="jxr_linenumber" name="L111" href="#L111">111</a>         {
 <a class="jxr_linenumber" name="L112" href="#L112">112</a>             <strong 
class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a 
href="../../../../org/apache/commons/mail/EmailException.html">EmailException</a>(<span
 class="jxr_string">"Building the MimeMessage failed"</span>, e);
 <a class="jxr_linenumber" name="L113" href="#L113">113</a>         }
@@ -134,23 +134,23 @@
 <a class="jxr_linenumber" name="L126" href="#L126">126</a>             <strong 
class="jxr_keyword">throws</strong> EmailException, IOException
 <a class="jxr_linenumber" name="L127" href="#L127">127</a>     {
 <a class="jxr_linenumber" name="L128" href="#L128">128</a>         DataSource 
dataSource;
-<a class="jxr_linenumber" name="L129" href="#L129">129</a>         
StringBuffer stringBuffer = <strong class="jxr_keyword">new</strong> 
StringBuffer();
+<a class="jxr_linenumber" name="L129" href="#L129">129</a>         <strong 
class="jxr_keyword">final</strong> StringBuffer stringBuffer = <strong 
class="jxr_keyword">new</strong> StringBuffer();
 <a class="jxr_linenumber" name="L130" href="#L130">130</a> 
 <a class="jxr_linenumber" name="L131" href="#L131">131</a>         <em 
class="jxr_comment">// maps "cid" --&gt; name</em>
-<a class="jxr_linenumber" name="L132" href="#L132">132</a>         
Map&lt;String, String&gt; cidCache = <strong class="jxr_keyword">new</strong> 
HashMap&lt;String, String&gt;();
+<a class="jxr_linenumber" name="L132" href="#L132">132</a>         <strong 
class="jxr_keyword">final</strong> Map&lt;String, String&gt; cidCache = <strong 
class="jxr_keyword">new</strong> HashMap&lt;String, String&gt;();
 <a class="jxr_linenumber" name="L133" href="#L133">133</a> 
 <a class="jxr_linenumber" name="L134" href="#L134">134</a>         <em 
class="jxr_comment">// maps "name" --&gt; dataSource</em>
-<a class="jxr_linenumber" name="L135" href="#L135">135</a>         
Map&lt;String, DataSource&gt; dataSourceCache = <strong 
class="jxr_keyword">new</strong> HashMap&lt;String, DataSource&gt;();
+<a class="jxr_linenumber" name="L135" href="#L135">135</a>         <strong 
class="jxr_keyword">final</strong> Map&lt;String, DataSource&gt; 
dataSourceCache = <strong class="jxr_keyword">new</strong> HashMap&lt;String, 
DataSource&gt;();
 <a class="jxr_linenumber" name="L136" href="#L136">136</a> 
 <a class="jxr_linenumber" name="L137" href="#L137">137</a>         <em 
class="jxr_comment">// in the String, replace all "img src" with a CID and 
embed the related</em>
 <a class="jxr_linenumber" name="L138" href="#L138">138</a>         <em 
class="jxr_comment">// image file if we find it.</em>
-<a class="jxr_linenumber" name="L139" href="#L139">139</a>         Matcher 
matcher = pattern.matcher(htmlMessage);
+<a class="jxr_linenumber" name="L139" href="#L139">139</a>         <strong 
class="jxr_keyword">final</strong> Matcher matcher = 
pattern.matcher(htmlMessage);
 <a class="jxr_linenumber" name="L140" href="#L140">140</a> 
 <a class="jxr_linenumber" name="L141" href="#L141">141</a>         <em 
class="jxr_comment">// the matcher returns all instances one by one</em>
 <a class="jxr_linenumber" name="L142" href="#L142">142</a>         <strong 
class="jxr_keyword">while</strong> (matcher.find())
 <a class="jxr_linenumber" name="L143" href="#L143">143</a>         {
 <a class="jxr_linenumber" name="L144" href="#L144">144</a>             <em 
class="jxr_comment">// in the RegEx we have the &lt;src&gt; element as second 
"group"</em>
-<a class="jxr_linenumber" name="L145" href="#L145">145</a>             String 
resourceLocation = matcher.group(2);
+<a class="jxr_linenumber" name="L145" href="#L145">145</a>             <strong 
class="jxr_keyword">final</strong> String resourceLocation = matcher.group(2);
 <a class="jxr_linenumber" name="L146" href="#L146">146</a> 
 <a class="jxr_linenumber" name="L147" href="#L147">147</a>             <em 
class="jxr_comment">// avoid loading the same data source more than once</em>
 <a class="jxr_linenumber" name="L148" href="#L148">148</a>             <strong 
class="jxr_keyword">if</strong> (dataSourceCache.get(resourceLocation) == 
<strong class="jxr_keyword">null</strong>)


Reply via email to