Author: ggregory
Date: Mon Dec 29 15:54:59 2014
New Revision: 1648377
URL: http://svn.apache.org/r1648377
Log:
Add final modifier to some private fields.
Modified:
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/ValidatorAction.java
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/UrlTest.java
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/ISBNValidatorTest.java
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
Modified:
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/ValidatorAction.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/ValidatorAction.java?rev=1648377&r1=1648376&r2=1648377&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/ValidatorAction.java
(original)
+++
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/ValidatorAction.java
Mon Dec 29 15:54:59 2014
@@ -149,13 +149,13 @@ public class ValidatorAction implements
* setDepends() (which clears the List) won't interfere with a call to
* isDependency().
*/
- private List dependencyList = Collections.synchronizedList(new
ArrayList());
+ private final List dependencyList = Collections.synchronizedList(new
ArrayList());
/**
* An internal List representation of all the validation method's
* parameters defined in the methodParams String.
*/
- private List methodParameterList = new ArrayList();
+ private final List methodParameterList = new ArrayList();
/**
* Gets the name of the validator action.
Modified:
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/UrlTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/UrlTest.java?rev=1648377&r1=1648376&r2=1648377&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/UrlTest.java
(original)
+++
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/UrlTest.java
Mon Dec 29 15:54:59 2014
@@ -26,8 +26,8 @@ import junit.framework.TestCase;
*/
public class UrlTest extends TestCase {
- private boolean printStatus = false;
- private boolean printIndex = false;//print index that indicates current
scheme,host,port,path, query test were using.
+ private final boolean printStatus = false;
+ private final boolean printIndex = false;//print index that indicates
current scheme,host,port,path, query test were using.
public UrlTest(String testName) {
super(testName);
Modified:
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/ISBNValidatorTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/ISBNValidatorTest.java?rev=1648377&r1=1648376&r2=1648377&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/ISBNValidatorTest.java
(original)
+++
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/ISBNValidatorTest.java
Mon Dec 29 15:54:59 2014
@@ -26,7 +26,7 @@ import junit.framework.TestCase;
*/
public class ISBNValidatorTest extends TestCase {
- private String[] validISBN10Format = new String[] {
+ private final String[] validISBN10Format = new String[] {
"1234567890",
"123456789X",
"12345-1234567-123456-X",
@@ -35,7 +35,7 @@ public class ISBNValidatorTest extends T
"1 2 3 4",
};
- private String[] invalidISBN10Format = new String[] {
+ private final String[] invalidISBN10Format = new String[] {
"", // empty
" ", // empty
"1", // too short
@@ -58,7 +58,7 @@ public class ISBNValidatorTest extends T
"068-556-98-45" // format
};
- private String[] validISBN13Format = new String[] {
+ private final String[] validISBN13Format = new String[] {
"9781234567890",
"9791234567890",
"978-12345-1234567-123456-1",
@@ -71,7 +71,7 @@ public class ISBNValidatorTest extends T
"979 1 2 3 4",
};
- private String[] invalidISBN13Format = new String[] {
+ private final String[] invalidISBN13Format = new String[] {
"", // empty
" ", // empty
"1", // too short
Modified:
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java?rev=1648377&r1=1648376&r2=1648377&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
(original)
+++
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
Mon Dec 29 15:54:59 2014
@@ -27,8 +27,8 @@ import org.apache.commons.validator.Resu
*/
public class UrlValidatorTest extends TestCase {
- private boolean printStatus = false;
- private boolean printIndex = false;//print index that indicates current
scheme,host,port,path, query test were using.
+ private final boolean printStatus = false;
+ private final boolean printIndex = false;//print index that indicates
current scheme,host,port,path, query test were using.
public UrlValidatorTest(String testName) {
super(testName);