Author: britter
Date: Wed Mar 18 10:20:51 2015
New Revision: 1667480
URL: http://svn.apache.org/r1667480
Log:
VALIDATOR-362: Local part of the email address should not be longer than 64
bytes. Thanks to Teo Bran.
Modified:
commons/proper/validator/trunk/src/changes/changes.xml
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/EmailValidator.java
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
Modified: commons/proper/validator/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/changes/changes.xml?rev=1667480&r1=1667479&r2=1667480&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/changes/changes.xml (original)
+++ commons/proper/validator/trunk/src/changes/changes.xml Wed Mar 18 10:20:51
2015
@@ -43,6 +43,9 @@ The <action> type attribute can be add,u
<body>
<release version="1.5.0" date="tba" description="tba">
+ <action issue="VALIDATOR-362" dev="britter" type="fix" due-to="Teo Bran">
+ Local part of the email address should not be longer than 64 bytes
+ </action>
<action issue="VALIDATOR-356" dev="seb" type="fix" >
IDN.toASCII drops trailing dot in Java 6 & 7
</action>
Modified:
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/EmailValidator.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/EmailValidator.java?rev=1667480&r1=1667479&r2=1667480&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/EmailValidator.java
(original)
+++
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/EmailValidator.java
Wed Mar 18 10:20:51 2015
@@ -159,6 +159,11 @@ public class EmailValidator implements S
* @return true if the user name is valid.
*/
protected boolean isValidUser(String user) {
+
+ if (user == null || user.length() > 64) {
+ return false;
+ }
+
return USER_PATTERN.matcher(user).matches();
}
Modified:
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java?rev=1667480&r1=1667479&r2=1667480&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
(original)
+++
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
Wed Mar 18 10:20:51 2015
@@ -367,6 +367,7 @@ public class EmailValidatorTest extends
assertTrue(validator.isValid("\"..\"@apache.org"));
+
assertFalse(validator.isValid("john56789.john56789.john56789.john56789.john56789.john56789.jo...@example.com"));
}
/**
