MATH-1255 Wrong usage of "Gaussian" function.
Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/4f73871c Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/4f73871c Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/4f73871c Branch: refs/heads/master Commit: 4f73871cf40b6dd05c8872d39246c67f798ed915 Parents: 63bc0db Author: Gilles <[email protected]> Authored: Thu Aug 13 23:32:37 2015 +0200 Committer: Gilles <[email protected]> Committed: Thu Aug 13 23:32:37 2015 +0200 ---------------------------------------------------------------------- src/changes/changes.xml | 3 +++ .../commons/math4/ml/neuralnet/sofm/KohonenUpdateAction.java | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-math/blob/4f73871c/src/changes/changes.xml ---------------------------------------------------------------------- diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 1849688..f1076db 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -54,6 +54,9 @@ If the output is not quite correct, check for invisible trailing spaces! </release> <release version="4.0" date="XXXX-XX-XX" description=""> + <action dev="erans" type="fix" issue="MATH-1255"> + Wrong neighbourhood size in class "KohonenUpdateAction" (package "o.a.c.m.ml.neuralnet.sofm"). + </action> <action dev="psteitz" type="fix" issue="MATH-1252" due-to="John Bay"> <!-- backported to 3.6 --> ResizableDoubleArray constructor does not work with double array of size 1. </action> http://git-wip-us.apache.org/repos/asf/commons-math/blob/4f73871c/src/main/java/org/apache/commons/math4/ml/neuralnet/sofm/KohonenUpdateAction.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ml/neuralnet/sofm/KohonenUpdateAction.java b/src/main/java/org/apache/commons/math4/ml/neuralnet/sofm/KohonenUpdateAction.java index 1b4b54e..87e1bbc 100644 --- a/src/main/java/org/apache/commons/math4/ml/neuralnet/sofm/KohonenUpdateAction.java +++ b/src/main/java/org/apache/commons/math4/ml/neuralnet/sofm/KohonenUpdateAction.java @@ -107,7 +107,7 @@ public class KohonenUpdateAction implements UpdateAction { final Gaussian neighbourhoodDecay = new Gaussian(currentLearning, 0, - 1d / currentNeighbourhood); + currentNeighbourhood); if (currentNeighbourhood > 0) { // Initial set of neurons only contains the winning neuron.
