Fixed checkstyle warnings. These warnings correspond to redundant modifiers (public, static, ...). They are identified by recent versions of checkstyle, in particular the one shipped with Eclipse. They are not detected by our maven-checkstyle-plugin yet because it is not the latest one and still depends on an older version of checkstyle.
Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/bf7e9d50 Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/bf7e9d50 Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/bf7e9d50 Branch: refs/heads/master Commit: bf7e9d505a75728fd69a51b1bee30e645c813c27 Parents: e10556e Author: Luc Maisonobe <[email protected]> Authored: Mon Nov 2 15:08:01 2015 +0100 Committer: Luc Maisonobe <[email protected]> Committed: Mon Nov 2 15:08:01 2015 +0100 ---------------------------------------------------------------------- .../differentiation/DerivativeStructure.java | 2 +- .../BicubicInterpolatingFunction.java | 2 +- .../interpolation/InterpolatingMicrosphere.java | 5 ++--- .../TricubicInterpolatingFunction.java | 2 +- .../analysis/polynomials/PolynomialsUtils.java | 2 +- .../math4/exception/util/LocalizedFormats.java | 2 +- .../fitting/leastsquares/GaussNewtonOptimizer.java | 2 +- .../geometry/euclidean/oned/IntervalsSet.java | 2 +- .../euclidean/threed/OutlineExtractor.java | 2 +- .../geometry/euclidean/threed/PolyhedronsSet.java | 6 +++--- .../euclidean/threed/SphericalCoordinates.java | 2 +- .../math4/geometry/euclidean/twod/Line.java | 4 ++-- .../math4/geometry/euclidean/twod/NestedLoops.java | 2 +- .../math4/geometry/euclidean/twod/PolygonsSet.java | 14 +++++++------- .../geometry/partitioning/BoundaryProjector.java | 2 +- .../geometry/partitioning/BoundarySizeVisitor.java | 2 +- .../geometry/partitioning/Characterization.java | 2 +- .../math4/geometry/partitioning/InsideFinder.java | 2 +- .../math4/geometry/partitioning/Region.java | 2 +- .../math4/geometry/partitioning/RegionFactory.java | 4 ++-- .../math4/geometry/partitioning/SubHyperplane.java | 2 +- .../math4/geometry/spherical/oned/ArcsSet.java | 2 +- .../math4/geometry/spherical/twod/Circle.java | 2 +- .../geometry/spherical/twod/EdgesBuilder.java | 2 +- .../spherical/twod/PropertiesComputer.java | 4 ++-- .../math4/linear/BiDiagonalTransformer.java | 2 +- .../math4/linear/HessenbergTransformer.java | 2 +- .../apache/commons/math4/linear/MatrixUtils.java | 4 ++-- .../commons/math4/linear/SchurTransformer.java | 2 +- .../org/apache/commons/math4/linear/SymmLQ.java | 2 +- .../math4/linear/TriDiagonalTransformer.java | 2 +- .../ml/clustering/KMeansPlusPlusClusterer.java | 2 +- .../commons/math4/ml/neuralnet/MapUtils.java | 3 +-- .../commons/math4/ode/ExpandableStatefulODE.java | 2 +- .../apache/commons/math4/ode/JacobianMatrices.java | 4 ++-- .../commons/math4/ode/MultistepIntegrator.java | 4 ++-- .../commons/math4/ode/ParameterConfiguration.java | 2 +- .../math4/ode/ParameterJacobianWrapper.java | 6 +++--- .../commons/math4/ode/ParameterizedWrapper.java | 2 +- .../commons/math4/ode/events/EventHandler.java | 2 +- .../commons/math4/ode/events/EventState.java | 2 +- .../math4/ode/nonstiff/AdamsMoultonIntegrator.java | 2 +- .../ClassicalRungeKuttaStepInterpolator.java | 4 ++-- .../nonstiff/DormandPrince54StepInterpolator.java | 4 ++-- .../nonstiff/DormandPrince853StepInterpolator.java | 4 ++-- .../math4/ode/nonstiff/EulerStepInterpolator.java | 4 ++-- .../math4/ode/nonstiff/GillStepInterpolator.java | 4 ++-- .../GraggBulirschStoerStepInterpolator.java | 17 ++++++++--------- .../ode/nonstiff/HighamHall54StepInterpolator.java | 4 ++-- .../math4/ode/nonstiff/LutherStepInterpolator.java | 4 ++-- .../ode/nonstiff/MidpointStepInterpolator.java | 4 ++-- .../ode/nonstiff/RungeKuttaStepInterpolator.java | 2 +- .../nonstiff/ThreeEighthesStepInterpolator.java | 4 ++-- .../math4/ode/sampling/StepNormalizerBounds.java | 2 +- .../apache/commons/math4/optim/PointValuePair.java | 2 +- .../commons/math4/optim/PointVectorValuePair.java | 2 +- .../commons/math4/optim/linear/Relationship.java | 2 +- .../scalar/MultivariateFunctionMappingAdapter.java | 6 +++--- .../NonLinearConjugateGradientOptimizer.java | 2 +- .../nonlinear/scalar/noderiv/CMAESOptimizer.java | 4 ++-- .../math4/random/EmpiricalDistribution.java | 4 ++-- .../correlation/StorelessBivariateCovariance.java | 4 ++-- .../descriptive/AggregateSummaryStatistics.java | 2 +- .../math4/stat/descriptive/moment/FirstMoment.java | 4 ++-- .../stat/descriptive/moment/FourthMoment.java | 4 ++-- .../math4/stat/descriptive/moment/ThirdMoment.java | 4 ++-- .../stat/descriptive/rank/PSquarePercentile.java | 2 +- .../math4/stat/descriptive/rank/Percentile.java | 4 ++-- .../commons/math4/stat/ranking/NaturalRanking.java | 2 +- .../math4/transform/FastFourierTransformer.java | 3 +-- .../apache/commons/math4/util/Combinations.java | 9 ++++----- .../org/apache/commons/math4/util/FastMath.java | 6 +++--- .../org/apache/commons/math4/util/MathArrays.java | 6 +++--- .../commons/math4/util/ResizableDoubleArray.java | 2 +- 74 files changed, 123 insertions(+), 128 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/analysis/differentiation/DerivativeStructure.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/analysis/differentiation/DerivativeStructure.java b/src/main/java/org/apache/commons/math4/analysis/differentiation/DerivativeStructure.java index eaea818..de9fe60 100644 --- a/src/main/java/org/apache/commons/math4/analysis/differentiation/DerivativeStructure.java +++ b/src/main/java/org/apache/commons/math4/analysis/differentiation/DerivativeStructure.java @@ -1237,7 +1237,7 @@ public class DerivativeStructure implements RealFieldElement<DerivativeStructure * @param order derivation order * @param data partial derivatives */ - public DataTransferObject(final int variables, final int order, final double[] data) { + DataTransferObject(final int variables, final int order, final double[] data) { this.variables = variables; this.order = order; this.data = data; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/analysis/interpolation/BicubicInterpolatingFunction.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/analysis/interpolation/BicubicInterpolatingFunction.java b/src/main/java/org/apache/commons/math4/analysis/interpolation/BicubicInterpolatingFunction.java index b89a517..4ded79d 100644 --- a/src/main/java/org/apache/commons/math4/analysis/interpolation/BicubicInterpolatingFunction.java +++ b/src/main/java/org/apache/commons/math4/analysis/interpolation/BicubicInterpolatingFunction.java @@ -275,7 +275,7 @@ class BicubicFunction implements BivariateFunction { * * @param coeff Spline coefficients. */ - public BicubicFunction(double[] coeff) { + BicubicFunction(double[] coeff) { a = new double[N][N]; for (int j = 0; j < N; j++) { final double[] aJ = a[j]; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/analysis/interpolation/InterpolatingMicrosphere.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/analysis/interpolation/InterpolatingMicrosphere.java b/src/main/java/org/apache/commons/math4/analysis/interpolation/InterpolatingMicrosphere.java index d813549..c8929cf 100644 --- a/src/main/java/org/apache/commons/math4/analysis/interpolation/InterpolatingMicrosphere.java +++ b/src/main/java/org/apache/commons/math4/analysis/interpolation/InterpolatingMicrosphere.java @@ -334,7 +334,7 @@ public class InterpolatingMicrosphere { * @param n Normal vector characterizing a surface element * of the microsphere. No copy is made. */ - public Facet(double[] n) { + Facet(double[] n) { normal = n; } @@ -361,8 +361,7 @@ public class InterpolatingMicrosphere { * @param illumination Illumination. * @param sample Data value. */ - public FacetData(double illumination, - double sample) { + FacetData(double illumination, double sample) { this.illumination = illumination; this.sample = sample; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/analysis/interpolation/TricubicInterpolatingFunction.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/analysis/interpolation/TricubicInterpolatingFunction.java b/src/main/java/org/apache/commons/math4/analysis/interpolation/TricubicInterpolatingFunction.java index a9f7c0d..d81b664 100644 --- a/src/main/java/org/apache/commons/math4/analysis/interpolation/TricubicInterpolatingFunction.java +++ b/src/main/java/org/apache/commons/math4/analysis/interpolation/TricubicInterpolatingFunction.java @@ -453,7 +453,7 @@ class TricubicFunction /** * @param aV List of spline coefficients. */ - public TricubicFunction(double[] aV) { + TricubicFunction(double[] aV) { for (int i = 0; i < N; i++) { for (int j = 0; j < N; j++) { for (int k = 0; k < N; k++) { http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/analysis/polynomials/PolynomialsUtils.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/analysis/polynomials/PolynomialsUtils.java b/src/main/java/org/apache/commons/math4/analysis/polynomials/PolynomialsUtils.java index 601692e..a9ff990 100644 --- a/src/main/java/org/apache/commons/math4/analysis/polynomials/PolynomialsUtils.java +++ b/src/main/java/org/apache/commons/math4/analysis/polynomials/PolynomialsUtils.java @@ -269,7 +269,7 @@ public class PolynomialsUtils { * @param v first exponent * @param w second exponent */ - public JacobiKey(final int v, final int w) { + JacobiKey(final int v, final int w) { this.v = v; this.w = w; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/exception/util/LocalizedFormats.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/exception/util/LocalizedFormats.java b/src/main/java/org/apache/commons/math4/exception/util/LocalizedFormats.java index 4349e40..1b589f1 100644 --- a/src/main/java/org/apache/commons/math4/exception/util/LocalizedFormats.java +++ b/src/main/java/org/apache/commons/math4/exception/util/LocalizedFormats.java @@ -379,7 +379,7 @@ public enum LocalizedFormats implements Localizable { * @param sourceFormat source English format to use when no * localized version is available */ - private LocalizedFormats(final String sourceFormat) { + LocalizedFormats(final String sourceFormat) { this.sourceFormat = sourceFormat; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/fitting/leastsquares/GaussNewtonOptimizer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/fitting/leastsquares/GaussNewtonOptimizer.java b/src/main/java/org/apache/commons/math4/fitting/leastsquares/GaussNewtonOptimizer.java index 92619d6..5999b20 100644 --- a/src/main/java/org/apache/commons/math4/fitting/leastsquares/GaussNewtonOptimizer.java +++ b/src/main/java/org/apache/commons/math4/fitting/leastsquares/GaussNewtonOptimizer.java @@ -50,7 +50,7 @@ public class GaussNewtonOptimizer implements LeastSquaresOptimizer { /** The decomposition algorithm to use to solve the normal equations. */ //TODO move to linear package and expand options? - public static enum Decomposition { + public enum Decomposition { /** * Solve by forming the normal equations (J<sup>T</sup>Jx=J<sup>T</sup>r) and * using the {@link LUDecomposition}. http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/euclidean/oned/IntervalsSet.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/euclidean/oned/IntervalsSet.java b/src/main/java/org/apache/commons/math4/geometry/euclidean/oned/IntervalsSet.java index e8bd4d4..7d944af 100644 --- a/src/main/java/org/apache/commons/math4/geometry/euclidean/oned/IntervalsSet.java +++ b/src/main/java/org/apache/commons/math4/geometry/euclidean/oned/IntervalsSet.java @@ -527,7 +527,7 @@ public class IntervalsSet extends AbstractRegion<Euclidean1D, Euclidean1D> imple /** Simple constructor. */ - public SubIntervalsIterator() { + SubIntervalsIterator() { current = getFirstIntervalBoundary(); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/OutlineExtractor.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/OutlineExtractor.java b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/OutlineExtractor.java index 2e1bfb4..a501813 100644 --- a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/OutlineExtractor.java +++ b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/OutlineExtractor.java @@ -130,7 +130,7 @@ public class OutlineExtractor { /** Simple constructor. * @param tolerance tolerance below which points are considered identical */ - public BoundaryProjector(final double tolerance) { + BoundaryProjector(final double tolerance) { this.projected = new PolygonsSet(new BSPTree<Euclidean2D>(Boolean.FALSE), tolerance); this.tolerance = tolerance; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/PolyhedronsSet.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/PolyhedronsSet.java b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/PolyhedronsSet.java index da6ba93..095d6d5 100644 --- a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/PolyhedronsSet.java +++ b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/PolyhedronsSet.java @@ -374,7 +374,7 @@ public class PolyhedronsSet extends AbstractRegion<Euclidean3D, Euclidean2D> { private class FacetsContributionVisitor implements BSPTreeVisitor<Euclidean3D> { /** Simple constructor. */ - public FacetsContributionVisitor() { + FacetsContributionVisitor() { setSize(0); setBarycenter((Point<Euclidean3D>) new Vector3D(0, 0, 0)); } @@ -560,7 +560,7 @@ public class PolyhedronsSet extends AbstractRegion<Euclidean3D, Euclidean2D> { * @param center center point of the rotation * @param rotation vectorial rotation */ - public RotationTransform(final Vector3D center, final Rotation rotation) { + RotationTransform(final Vector3D center, final Rotation rotation) { this.center = center; this.rotation = rotation; } @@ -634,7 +634,7 @@ public class PolyhedronsSet extends AbstractRegion<Euclidean3D, Euclidean2D> { /** Build a translation transform. * @param translation translation vector */ - public TranslationTransform(final Vector3D translation) { + TranslationTransform(final Vector3D translation) { this.translation = translation; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/SphericalCoordinates.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/SphericalCoordinates.java b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/SphericalCoordinates.java index b623af9..97155b6 100644 --- a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/SphericalCoordinates.java +++ b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/SphericalCoordinates.java @@ -377,7 +377,7 @@ public class SphericalCoordinates implements Serializable { * @param y ordinate * @param z height */ - public DataTransferObject(final double x, final double y, final double z) { + DataTransferObject(final double x, final double y, final double z) { this.x = x; this.y = y; this.z = z; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/Line.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/Line.java b/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/Line.java index 9f7d578..af0846f 100644 --- a/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/Line.java +++ b/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/Line.java @@ -486,8 +486,8 @@ public class Line implements Hyperplane<Euclidean2D>, Embedding<Euclidean2D, Euc * @exception MathIllegalArgumentException if the transform is non invertible * @since 4.0 */ - public LineTransform(final double cXX, final double cYX, final double cXY, - final double cYY, final double cX1, final double cY1) + LineTransform(final double cXX, final double cYX, final double cXY, + final double cYY, final double cX1, final double cY1) throws MathIllegalArgumentException { this.cXX = cXX; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/NestedLoops.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/NestedLoops.java b/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/NestedLoops.java index faead92..a0bd47d 100644 --- a/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/NestedLoops.java +++ b/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/NestedLoops.java @@ -69,7 +69,7 @@ class NestedLoops { * @param tolerance tolerance below which points are considered identical * @since 3.3 */ - public NestedLoops(final double tolerance) { + NestedLoops(final double tolerance) { this.surrounded = new ArrayList<NestedLoops>(); this.tolerance = tolerance; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSet.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSet.java b/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSet.java index 7f655c7..6dcf2cd 100644 --- a/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSet.java +++ b/src/main/java/org/apache/commons/math4/geometry/euclidean/twod/PolygonsSet.java @@ -361,7 +361,7 @@ public class PolygonsSet extends AbstractRegion<Euclidean2D, Euclidean1D> { /** Build a non-processed vertex not owned by any node yet. * @param location vertex location */ - public Vertex(final Vector2D location) { + Vertex(final Vector2D location) { this.location = location; this.incoming = null; this.outgoing = null; @@ -463,7 +463,7 @@ public class PolygonsSet extends AbstractRegion<Euclidean2D, Euclidean1D> { * @param end end vertex * @param line line supporting the edge */ - public Edge(final Vertex start, final Vertex end, final Line line) { + Edge(final Vertex start, final Vertex end, final Line line) { this.start = start; this.end = end; @@ -906,10 +906,10 @@ public class PolygonsSet extends AbstractRegion<Euclidean2D, Euclidean1D> { * @param startNode node whose intersection with current node defines start point * @param endNode node whose intersection with current node defines end point */ - public ConnectableSegment(final Vector2D start, final Vector2D end, final Line line, - final BSPTree<Euclidean2D> node, - final BSPTree<Euclidean2D> startNode, - final BSPTree<Euclidean2D> endNode) { + ConnectableSegment(final Vector2D start, final Vector2D end, final Line line, + final BSPTree<Euclidean2D> node, + final BSPTree<Euclidean2D> startNode, + final BSPTree<Euclidean2D> endNode) { super(start, end, line); this.node = node; this.startNode = startNode; @@ -996,7 +996,7 @@ public class PolygonsSet extends AbstractRegion<Euclidean2D, Euclidean1D> { /** Simple constructor. * @param tolerance tolerance for close nodes connection */ - public SegmentsBuilder(final double tolerance) { + SegmentsBuilder(final double tolerance) { this.tolerance = tolerance; this.segments = new ArrayList<ConnectableSegment>(); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundaryProjector.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundaryProjector.java b/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundaryProjector.java index 655aaa2..4a6079c 100644 --- a/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundaryProjector.java +++ b/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundaryProjector.java @@ -46,7 +46,7 @@ class BoundaryProjector<S extends Space, T extends Space> implements BSPTreeVisi /** Simple constructor. * @param original original point */ - public BoundaryProjector(final Point<S> original) { + BoundaryProjector(final Point<S> original) { this.original = original; this.projected = null; this.leaf = null; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundarySizeVisitor.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundarySizeVisitor.java b/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundarySizeVisitor.java index dae1806..c5b2895 100644 --- a/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundarySizeVisitor.java +++ b/src/main/java/org/apache/commons/math4/geometry/partitioning/BoundarySizeVisitor.java @@ -29,7 +29,7 @@ class BoundarySizeVisitor<S extends Space> implements BSPTreeVisitor<S> { /** Simple constructor. */ - public BoundarySizeVisitor() { + BoundarySizeVisitor() { boundarySize = 0; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/partitioning/Characterization.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/partitioning/Characterization.java b/src/main/java/org/apache/commons/math4/geometry/partitioning/Characterization.java index fb5256d..69df9ad 100644 --- a/src/main/java/org/apache/commons/math4/geometry/partitioning/Characterization.java +++ b/src/main/java/org/apache/commons/math4/geometry/partitioning/Characterization.java @@ -53,7 +53,7 @@ class Characterization<S extends Space> { * @param node current BSP tree node * @param sub sub-hyperplane to characterize */ - public Characterization(final BSPTree<S> node, final SubHyperplane<S> sub) { + Characterization(final BSPTree<S> node, final SubHyperplane<S> sub) { outsideTouching = null; insideTouching = null; outsideSplitters = new NodesSet<S>(); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/partitioning/InsideFinder.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/partitioning/InsideFinder.java b/src/main/java/org/apache/commons/math4/geometry/partitioning/InsideFinder.java index da72e6d..3429d3a 100644 --- a/src/main/java/org/apache/commons/math4/geometry/partitioning/InsideFinder.java +++ b/src/main/java/org/apache/commons/math4/geometry/partitioning/InsideFinder.java @@ -37,7 +37,7 @@ class InsideFinder<S extends Space> { /** Simple constructor. * @param region region on which to operate */ - public InsideFinder(final Region<S> region) { + InsideFinder(final Region<S> region) { this.region = region; plusFound = false; minusFound = false; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/partitioning/Region.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/partitioning/Region.java b/src/main/java/org/apache/commons/math4/geometry/partitioning/Region.java index 404d15d..40314a5 100644 --- a/src/main/java/org/apache/commons/math4/geometry/partitioning/Region.java +++ b/src/main/java/org/apache/commons/math4/geometry/partitioning/Region.java @@ -53,7 +53,7 @@ import org.apache.commons.math4.geometry.Space; public interface Region<S extends Space> { /** Enumerate for the location of a point with respect to the region. */ - public static enum Location { + enum Location { /** Code for points inside the partition. */ INSIDE, http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/partitioning/RegionFactory.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/partitioning/RegionFactory.java b/src/main/java/org/apache/commons/math4/geometry/partitioning/RegionFactory.java index bcae157..6d49939 100644 --- a/src/main/java/org/apache/commons/math4/geometry/partitioning/RegionFactory.java +++ b/src/main/java/org/apache/commons/math4/geometry/partitioning/RegionFactory.java @@ -299,7 +299,7 @@ public class RegionFactory<S extends Space> { * @param region1 region to subtract from * @param region2 region to subtract */ - public DifferenceMerger(final Region<S> region1, final Region<S> region2) { + DifferenceMerger(final Region<S> region1, final Region<S> region2) { this.region1 = region1.copySelf(); this.region2 = region2.copySelf(); } @@ -367,7 +367,7 @@ public class RegionFactory<S extends Space> { /** Simple constructor. * @param inside inside/outside indicator to use for ambiguous nodes */ - public VanishingToLeaf(final boolean inside) { + VanishingToLeaf(final boolean inside) { this.inside = inside; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/partitioning/SubHyperplane.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/partitioning/SubHyperplane.java b/src/main/java/org/apache/commons/math4/geometry/partitioning/SubHyperplane.java index 03a766e..9e8461a 100644 --- a/src/main/java/org/apache/commons/math4/geometry/partitioning/SubHyperplane.java +++ b/src/main/java/org/apache/commons/math4/geometry/partitioning/SubHyperplane.java @@ -84,7 +84,7 @@ public interface SubHyperplane<S extends Space> { /** Class holding the results of the {@link #split split} method. * @param <U> Type of the embedding space. */ - public static class SplitSubHyperplane<U extends Space> { + class SplitSubHyperplane<U extends Space> { /** Part of the sub-hyperplane on the plus side of the splitting hyperplane. */ private final SubHyperplane<U> plus; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/spherical/oned/ArcsSet.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/spherical/oned/ArcsSet.java b/src/main/java/org/apache/commons/math4/geometry/spherical/oned/ArcsSet.java index c5f772b..1436ce2 100644 --- a/src/main/java/org/apache/commons/math4/geometry/spherical/oned/ArcsSet.java +++ b/src/main/java/org/apache/commons/math4/geometry/spherical/oned/ArcsSet.java @@ -599,7 +599,7 @@ public class ArcsSet extends AbstractRegion<Sphere1D, Sphere1D> implements Itera /** Simple constructor. */ - public SubArcsIterator() { + SubArcsIterator() { firstStart = getFirstArcStart(); current = firstStart; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/spherical/twod/Circle.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/spherical/twod/Circle.java b/src/main/java/org/apache/commons/math4/geometry/spherical/twod/Circle.java index 0989bad..62eba43 100644 --- a/src/main/java/org/apache/commons/math4/geometry/spherical/twod/Circle.java +++ b/src/main/java/org/apache/commons/math4/geometry/spherical/twod/Circle.java @@ -304,7 +304,7 @@ public class Circle implements Hyperplane<Sphere2D>, Embedding<Sphere2D, Sphere1 /** Build a transform from a {@code Rotation}. * @param rotation rotation to use */ - public CircleTransform(final Rotation rotation) { + CircleTransform(final Rotation rotation) { this.rotation = rotation; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/spherical/twod/EdgesBuilder.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/spherical/twod/EdgesBuilder.java b/src/main/java/org/apache/commons/math4/geometry/spherical/twod/EdgesBuilder.java index aac7aef..002d42c 100644 --- a/src/main/java/org/apache/commons/math4/geometry/spherical/twod/EdgesBuilder.java +++ b/src/main/java/org/apache/commons/math4/geometry/spherical/twod/EdgesBuilder.java @@ -52,7 +52,7 @@ class EdgesBuilder implements BSPTreeVisitor<Sphere2D> { * @param root tree root * @param tolerance below which points are consider to be identical */ - public EdgesBuilder(final BSPTree<Sphere2D> root, final double tolerance) { + EdgesBuilder(final BSPTree<Sphere2D> root, final double tolerance) { this.root = root; this.tolerance = tolerance; this.edgeToNode = new IdentityHashMap<Edge, BSPTree<Sphere2D>>(); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/geometry/spherical/twod/PropertiesComputer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/geometry/spherical/twod/PropertiesComputer.java b/src/main/java/org/apache/commons/math4/geometry/spherical/twod/PropertiesComputer.java index 7721320..eadc223 100644 --- a/src/main/java/org/apache/commons/math4/geometry/spherical/twod/PropertiesComputer.java +++ b/src/main/java/org/apache/commons/math4/geometry/spherical/twod/PropertiesComputer.java @@ -44,9 +44,9 @@ class PropertiesComputer implements BSPTreeVisitor<Sphere2D> { private final List<Vector3D> convexCellsInsidePoints; /** Simple constructor. - * @param tolerance below which points are consider to be identical + * @param tolerance below which points are consider to be identical */ - public PropertiesComputer(final double tolerance) { + PropertiesComputer(final double tolerance) { this.tolerance = tolerance; this.summedArea = 0; this.summedBarycenter = Vector3D.ZERO; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/linear/BiDiagonalTransformer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/linear/BiDiagonalTransformer.java b/src/main/java/org/apache/commons/math4/linear/BiDiagonalTransformer.java index 7ed29b7..3e9e71a 100644 --- a/src/main/java/org/apache/commons/math4/linear/BiDiagonalTransformer.java +++ b/src/main/java/org/apache/commons/math4/linear/BiDiagonalTransformer.java @@ -58,7 +58,7 @@ class BiDiagonalTransformer { * Build the transformation to bi-diagonal shape of a matrix. * @param matrix the matrix to transform. */ - public BiDiagonalTransformer(RealMatrix matrix) { + BiDiagonalTransformer(RealMatrix matrix) { final int m = matrix.getRowDimension(); final int n = matrix.getColumnDimension(); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/linear/HessenbergTransformer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/linear/HessenbergTransformer.java b/src/main/java/org/apache/commons/math4/linear/HessenbergTransformer.java index a63c0ab..e7bf442 100644 --- a/src/main/java/org/apache/commons/math4/linear/HessenbergTransformer.java +++ b/src/main/java/org/apache/commons/math4/linear/HessenbergTransformer.java @@ -56,7 +56,7 @@ class HessenbergTransformer { * @param matrix matrix to transform * @throws NonSquareMatrixException if the matrix is not square */ - public HessenbergTransformer(final RealMatrix matrix) { + HessenbergTransformer(final RealMatrix matrix) { if (!matrix.isSquare()) { throw new NonSquareMatrixException(matrix.getRowDimension(), matrix.getColumnDimension()); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/linear/MatrixUtils.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/linear/MatrixUtils.java b/src/main/java/org/apache/commons/math4/linear/MatrixUtils.java index e95c4c8..19ff724 100644 --- a/src/main/java/org/apache/commons/math4/linear/MatrixUtils.java +++ b/src/main/java/org/apache/commons/math4/linear/MatrixUtils.java @@ -625,7 +625,7 @@ public class MatrixUtils { /** Converted array. */ private double[][] data; /** Simple constructor. */ - public FractionMatrixConverter() { + FractionMatrixConverter() { super(Fraction.ZERO); } @@ -670,7 +670,7 @@ public class MatrixUtils { /** Converted array. */ private double[][] data; /** Simple constructor. */ - public BigFractionMatrixConverter() { + BigFractionMatrixConverter() { super(BigFraction.ZERO); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/linear/SchurTransformer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/linear/SchurTransformer.java b/src/main/java/org/apache/commons/math4/linear/SchurTransformer.java index 5ad0757..3d818b4 100644 --- a/src/main/java/org/apache/commons/math4/linear/SchurTransformer.java +++ b/src/main/java/org/apache/commons/math4/linear/SchurTransformer.java @@ -65,7 +65,7 @@ class SchurTransformer { * @param matrix matrix to transform * @throws NonSquareMatrixException if the matrix is not square */ - public SchurTransformer(final RealMatrix matrix) { + SchurTransformer(final RealMatrix matrix) { if (!matrix.isSquare()) { throw new NonSquareMatrixException(matrix.getRowDimension(), matrix.getColumnDimension()); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/linear/SymmLQ.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/linear/SymmLQ.java b/src/main/java/org/apache/commons/math4/linear/SymmLQ.java index 990bcc5..ef52904 100644 --- a/src/main/java/org/apache/commons/math4/linear/SymmLQ.java +++ b/src/main/java/org/apache/commons/math4/linear/SymmLQ.java @@ -380,7 +380,7 @@ public class SymmLQ * @param check {@code true} if self-adjointedness of both matrix and * preconditioner should be checked */ - public State(final RealLinearOperator a, + State(final RealLinearOperator a, final RealLinearOperator m, final RealVector b, final boolean goodb, http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/linear/TriDiagonalTransformer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/linear/TriDiagonalTransformer.java b/src/main/java/org/apache/commons/math4/linear/TriDiagonalTransformer.java index 9e73b29..dea5da1 100644 --- a/src/main/java/org/apache/commons/math4/linear/TriDiagonalTransformer.java +++ b/src/main/java/org/apache/commons/math4/linear/TriDiagonalTransformer.java @@ -58,7 +58,7 @@ class TriDiagonalTransformer { * @param matrix Symmetrical matrix to transform. * @throws NonSquareMatrixException if the matrix is not square. */ - public TriDiagonalTransformer(RealMatrix matrix) { + TriDiagonalTransformer(RealMatrix matrix) { if (!matrix.isSquare()) { throw new NonSquareMatrixException(matrix.getRowDimension(), matrix.getColumnDimension()); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ml/clustering/KMeansPlusPlusClusterer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ml/clustering/KMeansPlusPlusClusterer.java b/src/main/java/org/apache/commons/math4/ml/clustering/KMeansPlusPlusClusterer.java index 14e9a89..1901013 100644 --- a/src/main/java/org/apache/commons/math4/ml/clustering/KMeansPlusPlusClusterer.java +++ b/src/main/java/org/apache/commons/math4/ml/clustering/KMeansPlusPlusClusterer.java @@ -42,7 +42,7 @@ import org.apache.commons.math4.util.MathUtils; public class KMeansPlusPlusClusterer<T extends Clusterable> extends Clusterer<T> { /** Strategies to use for replacing an empty cluster. */ - public static enum EmptyClusterStrategy { + public enum EmptyClusterStrategy { /** Split the cluster with largest distance variance. */ LARGEST_VARIANCE, http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ml/neuralnet/MapUtils.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ml/neuralnet/MapUtils.java b/src/main/java/org/apache/commons/math4/ml/neuralnet/MapUtils.java index 6d2f63a..eb9d627 100644 --- a/src/main/java/org/apache/commons/math4/ml/neuralnet/MapUtils.java +++ b/src/main/java/org/apache/commons/math4/ml/neuralnet/MapUtils.java @@ -302,8 +302,7 @@ public class MapUtils { * @param neuron Neuron. * @param value Value. */ - public PairNeuronDouble(Neuron neuron, - double value) { + PairNeuronDouble(Neuron neuron, double value) { this.neuron = neuron; this.value = value; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/ExpandableStatefulODE.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/ExpandableStatefulODE.java b/src/main/java/org/apache/commons/math4/ode/ExpandableStatefulODE.java index 711f524..77e50bc 100644 --- a/src/main/java/org/apache/commons/math4/ode/ExpandableStatefulODE.java +++ b/src/main/java/org/apache/commons/math4/ode/ExpandableStatefulODE.java @@ -317,7 +317,7 @@ public class ExpandableStatefulODE { * @param equation secondary differential equation * @param firstIndex index to use for the first element in the complete arrays */ - public SecondaryComponent(final SecondaryEquations equation, final int firstIndex) { + SecondaryComponent(final SecondaryEquations equation, final int firstIndex) { final int n = equation.getDimension(); this.equation = equation; mapper = new EquationsMapper(firstIndex, n); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/JacobianMatrices.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/JacobianMatrices.java b/src/main/java/org/apache/commons/math4/ode/JacobianMatrices.java index bcbbc6e..1296620 100644 --- a/src/main/java/org/apache/commons/math4/ode/JacobianMatrices.java +++ b/src/main/java/org/apache/commons/math4/ode/JacobianMatrices.java @@ -433,8 +433,8 @@ public class JacobianMatrices { * @exception DimensionMismatchException if there is a dimension mismatch between * the steps array {@code hY} and the equation dimension */ - public MainStateJacobianWrapper(final FirstOrderDifferentialEquations ode, - final double[] hY) + MainStateJacobianWrapper(final FirstOrderDifferentialEquations ode, + final double[] hY) throws DimensionMismatchException { this.ode = ode; this.hY = hY.clone(); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/MultistepIntegrator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/MultistepIntegrator.java b/src/main/java/org/apache/commons/math4/ode/MultistepIntegrator.java index b8b6a1d..d6c024f 100644 --- a/src/main/java/org/apache/commons/math4/ode/MultistepIntegrator.java +++ b/src/main/java/org/apache/commons/math4/ode/MultistepIntegrator.java @@ -357,7 +357,7 @@ public abstract class MultistepIntegrator extends AdaptiveStepsizeIntegrator { * @param nSteps number of steps of the multistep method (excluding the one being computed) * @param n problem dimension */ - public NordsieckInitializer(final int nSteps, final int n) { + NordsieckInitializer(final int nSteps, final int n) { this.count = 0; this.t = new double[nSteps]; this.y = new double[nSteps][n]; @@ -442,7 +442,7 @@ public abstract class MultistepIntegrator extends AdaptiveStepsizeIntegrator { private static final long serialVersionUID = -1914085471038046418L; /** Simple constructor. */ - public InitializationCompletedMarkerException() { + InitializationCompletedMarkerException() { super((Throwable) null); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/ParameterConfiguration.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/ParameterConfiguration.java b/src/main/java/org/apache/commons/math4/ode/ParameterConfiguration.java index d71c2b7..14c7919 100644 --- a/src/main/java/org/apache/commons/math4/ode/ParameterConfiguration.java +++ b/src/main/java/org/apache/commons/math4/ode/ParameterConfiguration.java @@ -38,7 +38,7 @@ class ParameterConfiguration implements Serializable { * @param parameterName parameter name * @param hP parameter step */ - public ParameterConfiguration(final String parameterName, final double hP) { + ParameterConfiguration(final String parameterName, final double hP) { this.parameterName = parameterName; this.hP = hP; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/ParameterJacobianWrapper.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/ParameterJacobianWrapper.java b/src/main/java/org/apache/commons/math4/ode/ParameterJacobianWrapper.java index a01d98f..d555aa4 100644 --- a/src/main/java/org/apache/commons/math4/ode/ParameterJacobianWrapper.java +++ b/src/main/java/org/apache/commons/math4/ode/ParameterJacobianWrapper.java @@ -46,9 +46,9 @@ class ParameterJacobianWrapper implements ParameterJacobianProvider { * @param paramsAndSteps parameters and steps to compute the Jacobians df/dp * @see JacobianMatrices#setParameterStep(String, double) */ - public ParameterJacobianWrapper(final FirstOrderDifferentialEquations fode, - final ParameterizedODE pode, - final ParameterConfiguration[] paramsAndSteps) { + ParameterJacobianWrapper(final FirstOrderDifferentialEquations fode, + final ParameterizedODE pode, + final ParameterConfiguration[] paramsAndSteps) { this.fode = fode; this.pode = pode; this.hParam = new HashMap<String, Double>(); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/ParameterizedWrapper.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/ParameterizedWrapper.java b/src/main/java/org/apache/commons/math4/ode/ParameterizedWrapper.java index e37b849..c306ec8 100644 --- a/src/main/java/org/apache/commons/math4/ode/ParameterizedWrapper.java +++ b/src/main/java/org/apache/commons/math4/ode/ParameterizedWrapper.java @@ -35,7 +35,7 @@ class ParameterizedWrapper implements ParameterizedODE { /** Simple constructor. * @param ode original first order differential equations */ - public ParameterizedWrapper(final FirstOrderDifferentialEquations ode) { + ParameterizedWrapper(final FirstOrderDifferentialEquations ode) { this.fode = ode; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/events/EventHandler.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/events/EventHandler.java b/src/main/java/org/apache/commons/math4/ode/events/EventHandler.java index cb22ea1..f1900f7 100644 --- a/src/main/java/org/apache/commons/math4/ode/events/EventHandler.java +++ b/src/main/java/org/apache/commons/math4/ode/events/EventHandler.java @@ -50,7 +50,7 @@ package org.apache.commons.math4.ode.events; public interface EventHandler { /** Enumerate for actions to be performed when an event occurs. */ - public enum Action { + enum Action { /** Stop indicator. * <p>This value should be used as the return value of the {@link http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/events/EventState.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/events/EventState.java b/src/main/java/org/apache/commons/math4/ode/events/EventState.java index f4abfb3..b89b00d 100644 --- a/src/main/java/org/apache/commons/math4/ode/events/EventState.java +++ b/src/main/java/org/apache/commons/math4/ode/events/EventState.java @@ -414,7 +414,7 @@ public class EventState { /** Simple constructor. * @param exception exception to wrap */ - public LocalMaxCountExceededException(final MaxCountExceededException exception) { + LocalMaxCountExceededException(final MaxCountExceededException exception) { wrapped = exception; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/AdamsMoultonIntegrator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/AdamsMoultonIntegrator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/AdamsMoultonIntegrator.java index 37affbe..70ec4f4 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/AdamsMoultonIntegrator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/AdamsMoultonIntegrator.java @@ -367,7 +367,7 @@ public class AdamsMoultonIntegrator extends AdamsIntegrator { * @param scaled current scaled first derivative * @param state state to correct (will be overwritten after visit) */ - public Corrector(final double[] previous, final double[] scaled, final double[] state) { + Corrector(final double[] previous, final double[] scaled, final double[] state) { this.previous = previous; this.scaled = scaled; this.after = state; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java index 1f60963..dd23975 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java @@ -68,7 +68,7 @@ class ClassicalRungeKuttaStepInterpolator * interpolators by cloning an uninitialized model and latter initializing * the copy. */ - public ClassicalRungeKuttaStepInterpolator() { + ClassicalRungeKuttaStepInterpolator() { } /** Copy constructor. @@ -76,7 +76,7 @@ class ClassicalRungeKuttaStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public ClassicalRungeKuttaStepInterpolator(final ClassicalRungeKuttaStepInterpolator interpolator) { + ClassicalRungeKuttaStepInterpolator(final ClassicalRungeKuttaStepInterpolator interpolator) { super(interpolator); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java index 114ce48..815b9b8 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java @@ -97,7 +97,7 @@ class DormandPrince54StepInterpolator * prototyping design pattern to create the step interpolators by * cloning an uninitialized model and latter initializing the copy. */ - public DormandPrince54StepInterpolator() { + DormandPrince54StepInterpolator() { super(); v1 = null; v2 = null; @@ -111,7 +111,7 @@ class DormandPrince54StepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public DormandPrince54StepInterpolator(final DormandPrince54StepInterpolator interpolator) { + DormandPrince54StepInterpolator(final DormandPrince54StepInterpolator interpolator) { super(interpolator); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java index 38fe2ec..9a17fe1 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java @@ -227,7 +227,7 @@ class DormandPrince853StepInterpolator * prototyping design pattern to create the step interpolators by * cloning an uninitialized model and latter initializing the copy. */ - public DormandPrince853StepInterpolator() { + DormandPrince853StepInterpolator() { super(); yDotKLast = null; v = null; @@ -239,7 +239,7 @@ class DormandPrince853StepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public DormandPrince853StepInterpolator(final DormandPrince853StepInterpolator interpolator) { + DormandPrince853StepInterpolator(final DormandPrince853StepInterpolator interpolator) { super(interpolator); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java index af78449..c31db8e 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java @@ -59,7 +59,7 @@ class EulerStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public EulerStepInterpolator() { + EulerStepInterpolator() { } /** Copy constructor. @@ -67,7 +67,7 @@ class EulerStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public EulerStepInterpolator(final EulerStepInterpolator interpolator) { + EulerStepInterpolator(final EulerStepInterpolator interpolator) { super(interpolator); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java index 7131388..3a7c034 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java @@ -75,7 +75,7 @@ class GillStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public GillStepInterpolator() { + GillStepInterpolator() { } /** Copy constructor. @@ -83,7 +83,7 @@ class GillStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public GillStepInterpolator(final GillStepInterpolator interpolator) { + GillStepInterpolator(final GillStepInterpolator interpolator) { super(interpolator); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java index 95c41c8..6afdf37 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java @@ -107,7 +107,7 @@ class GraggBulirschStoerStepInterpolator * This constructor should not be used directly, it is only intended * for the serialization process. */ - public GraggBulirschStoerStepInterpolator() { + GraggBulirschStoerStepInterpolator() { y0Dot = null; y1 = null; y1Dot = null; @@ -129,12 +129,12 @@ class GraggBulirschStoerStepInterpolator * @param primaryMapper equations mapper for the primary equations set * @param secondaryMappers equations mappers for the secondary equations sets */ - public GraggBulirschStoerStepInterpolator(final double[] y, final double[] y0Dot, - final double[] y1, final double[] y1Dot, - final double[][] yMidDots, - final boolean forward, - final EquationsMapper primaryMapper, - final EquationsMapper[] secondaryMappers) { + GraggBulirschStoerStepInterpolator(final double[] y, final double[] y0Dot, + final double[] y1, final double[] y1Dot, + final double[][] yMidDots, + final boolean forward, + final EquationsMapper primaryMapper, + final EquationsMapper[] secondaryMappers) { super(y, forward, primaryMapper, secondaryMappers); this.y0Dot = y0Dot; @@ -151,8 +151,7 @@ class GraggBulirschStoerStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public GraggBulirschStoerStepInterpolator - (final GraggBulirschStoerStepInterpolator interpolator) { + GraggBulirschStoerStepInterpolator(final GraggBulirschStoerStepInterpolator interpolator) { super(interpolator); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java index 19acf08..01a00d0 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java @@ -45,7 +45,7 @@ class HighamHall54StepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public HighamHall54StepInterpolator() { + HighamHall54StepInterpolator() { super(); } @@ -54,7 +54,7 @@ class HighamHall54StepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public HighamHall54StepInterpolator(final HighamHall54StepInterpolator interpolator) { + HighamHall54StepInterpolator(final HighamHall54StepInterpolator interpolator) { super(interpolator); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java index d3fd546..e4d212b 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java @@ -51,7 +51,7 @@ class LutherStepInterpolator extends RungeKuttaStepInterpolator { * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public LutherStepInterpolator() { + LutherStepInterpolator() { } /** Copy constructor. @@ -59,7 +59,7 @@ class LutherStepInterpolator extends RungeKuttaStepInterpolator { * copy: its arrays are separated from the original arrays of the * instance */ - public LutherStepInterpolator(final LutherStepInterpolator interpolator) { + LutherStepInterpolator(final LutherStepInterpolator interpolator) { super(interpolator); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java index d872d6e..38393ca 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java @@ -61,7 +61,7 @@ class MidpointStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public MidpointStepInterpolator() { + MidpointStepInterpolator() { } /** Copy constructor. @@ -69,7 +69,7 @@ class MidpointStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public MidpointStepInterpolator(final MidpointStepInterpolator interpolator) { + MidpointStepInterpolator(final MidpointStepInterpolator interpolator) { super(interpolator); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/RungeKuttaStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/RungeKuttaStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/RungeKuttaStepInterpolator.java index 5d09d94..207435f 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/RungeKuttaStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/RungeKuttaStepInterpolator.java @@ -79,7 +79,7 @@ abstract class RungeKuttaStepInterpolator * @param interpolator interpolator to copy from. */ - public RungeKuttaStepInterpolator(final RungeKuttaStepInterpolator interpolator) { + RungeKuttaStepInterpolator(final RungeKuttaStepInterpolator interpolator) { super(interpolator); http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java index 33fee20..2dba16e 100644 --- a/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java +++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java @@ -71,7 +71,7 @@ class ThreeEighthesStepInterpolator * to create the step interpolators by cloning an uninitialized model * and later initializing the copy. */ - public ThreeEighthesStepInterpolator() { + ThreeEighthesStepInterpolator() { } /** Copy constructor. @@ -79,7 +79,7 @@ class ThreeEighthesStepInterpolator * copy: its arrays are separated from the original arrays of the * instance */ - public ThreeEighthesStepInterpolator(final ThreeEighthesStepInterpolator interpolator) { + ThreeEighthesStepInterpolator(final ThreeEighthesStepInterpolator interpolator) { super(interpolator); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/ode/sampling/StepNormalizerBounds.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/ode/sampling/StepNormalizerBounds.java b/src/main/java/org/apache/commons/math4/ode/sampling/StepNormalizerBounds.java index 0a9ccfd..c9b02ed 100644 --- a/src/main/java/org/apache/commons/math4/ode/sampling/StepNormalizerBounds.java +++ b/src/main/java/org/apache/commons/math4/ode/sampling/StepNormalizerBounds.java @@ -56,7 +56,7 @@ public enum StepNormalizerBounds { * @param last Whether the last point should be passed to the * underlying fixed step size step handler. */ - private StepNormalizerBounds(final boolean first, final boolean last) { + StepNormalizerBounds(final boolean first, final boolean last) { this.first = first; this.last = last; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/optim/PointValuePair.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/optim/PointValuePair.java b/src/main/java/org/apache/commons/math4/optim/PointValuePair.java index b3e01a0..9ad21aa 100644 --- a/src/main/java/org/apache/commons/math4/optim/PointValuePair.java +++ b/src/main/java/org/apache/commons/math4/optim/PointValuePair.java @@ -107,7 +107,7 @@ public class PointValuePair extends Pair<double[], Double> implements Serializab * @param point Point coordinates. * @param value Value of the objective function at the point. */ - public DataTransferObject(final double[] point, final double value) { + DataTransferObject(final double[] point, final double value) { this.point = point.clone(); this.value = value; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/optim/PointVectorValuePair.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/optim/PointVectorValuePair.java b/src/main/java/org/apache/commons/math4/optim/PointVectorValuePair.java index 62741d7..efb9818 100644 --- a/src/main/java/org/apache/commons/math4/optim/PointVectorValuePair.java +++ b/src/main/java/org/apache/commons/math4/optim/PointVectorValuePair.java @@ -132,7 +132,7 @@ public class PointVectorValuePair extends Pair<double[], double[]> implements Se * @param point Point coordinates. * @param value Value of the objective function at the point. */ - public DataTransferObject(final double[] point, final double[] value) { + DataTransferObject(final double[] point, final double[] value) { this.point = point.clone(); this.value = value.clone(); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/optim/linear/Relationship.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/optim/linear/Relationship.java b/src/main/java/org/apache/commons/math4/optim/linear/Relationship.java index f46a649..7822302 100644 --- a/src/main/java/org/apache/commons/math4/optim/linear/Relationship.java +++ b/src/main/java/org/apache/commons/math4/optim/linear/Relationship.java @@ -37,7 +37,7 @@ public enum Relationship { * * @param stringValue Display string for the relationship. */ - private Relationship(String stringValue) { + Relationship(String stringValue) { this.stringValue = stringValue; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java b/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java index dc01a2f..a430d48 100644 --- a/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java +++ b/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/MultivariateFunctionMappingAdapter.java @@ -224,7 +224,7 @@ public class MultivariateFunctionMappingAdapter * * @param lower lower bound */ - public LowerBoundMapper(final double lower) { + LowerBoundMapper(final double lower) { this.lower = lower; } @@ -251,7 +251,7 @@ public class MultivariateFunctionMappingAdapter /** Simple constructor. * @param upper upper bound */ - public UpperBoundMapper(final double upper) { + UpperBoundMapper(final double upper) { this.upper = upper; } @@ -282,7 +282,7 @@ public class MultivariateFunctionMappingAdapter * @param lower lower bound * @param upper upper bound */ - public LowerUpperBoundMapper(final double lower, final double upper) { + LowerUpperBoundMapper(final double lower, final double upper) { boundingFunction = new Sigmoid(lower, upper); unboundingFunction = new Logit(lower, upper); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java b/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java index 8ef98fc..75dd024 100644 --- a/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java +++ b/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/gradient/NonLinearConjugateGradientOptimizer.java @@ -69,7 +69,7 @@ public class NonLinearConjugateGradientOptimizer * * @since 2.0 */ - public static enum Formula { + public enum Formula { /** Fletcher-Reeves formula. */ FLETCHER_REEVES, /** Polak-Ribière formula. */ http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java b/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java index 121aa2e..f769585 100644 --- a/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java +++ b/src/main/java/org/apache/commons/math4/optim/nonlinear/scalar/noderiv/CMAESOptimizer.java @@ -912,7 +912,7 @@ public class CMAESOptimizer * @param value Function value. * @param penalty Out-of-bounds penalty. */ - public ValuePenaltyPair(final double value, final double penalty) { + ValuePenaltyPair(final double value, final double penalty) { this.value = value; this.penalty = penalty; } @@ -932,7 +932,7 @@ public class CMAESOptimizer /** Simple constructor. */ - public FitnessFunction() { + FitnessFunction() { isRepairMode = true; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/random/EmpiricalDistribution.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/random/EmpiricalDistribution.java b/src/main/java/org/apache/commons/math4/random/EmpiricalDistribution.java index f1a86b1..6d2722e 100644 --- a/src/main/java/org/apache/commons/math4/random/EmpiricalDistribution.java +++ b/src/main/java/org/apache/commons/math4/random/EmpiricalDistribution.java @@ -322,7 +322,7 @@ public class EmpiricalDistribution extends AbstractRealDistribution { * * @param in BufferedReader input stream */ - public StreamDataAdapter(BufferedReader in){ + StreamDataAdapter(BufferedReader in){ super(); inputStream = in; } @@ -371,7 +371,7 @@ public class EmpiricalDistribution extends AbstractRealDistribution { * @param in double[] array holding the data * @throws NullArgumentException if in is null */ - public ArrayDataAdapter(double[] in) throws NullArgumentException { + ArrayDataAdapter(double[] in) throws NullArgumentException { super(); MathUtils.checkNotNull(in); inputArray = in; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/correlation/StorelessBivariateCovariance.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/correlation/StorelessBivariateCovariance.java b/src/main/java/org/apache/commons/math4/stat/correlation/StorelessBivariateCovariance.java index 93f6ca3..6f418fb 100644 --- a/src/main/java/org/apache/commons/math4/stat/correlation/StorelessBivariateCovariance.java +++ b/src/main/java/org/apache/commons/math4/stat/correlation/StorelessBivariateCovariance.java @@ -56,7 +56,7 @@ class StorelessBivariateCovariance { * Create an empty {@link StorelessBivariateCovariance} instance with * bias correction. */ - public StorelessBivariateCovariance() { + StorelessBivariateCovariance() { this(true); } @@ -67,7 +67,7 @@ class StorelessBivariateCovariance { * for bias, i.e. n-1 in the denominator, otherwise there is no bias correction, * i.e. n in the denominator. */ - public StorelessBivariateCovariance(final boolean biasCorrection) { + StorelessBivariateCovariance(final boolean biasCorrection) { meanX = meanY = 0.0; n = 0; covarianceNumerator = 0.0; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/descriptive/AggregateSummaryStatistics.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/descriptive/AggregateSummaryStatistics.java b/src/main/java/org/apache/commons/math4/stat/descriptive/AggregateSummaryStatistics.java index 40d989c..05054f4 100644 --- a/src/main/java/org/apache/commons/math4/stat/descriptive/AggregateSummaryStatistics.java +++ b/src/main/java/org/apache/commons/math4/stat/descriptive/AggregateSummaryStatistics.java @@ -379,7 +379,7 @@ public class AggregateSummaryStatistics implements StatisticalSummary, * @param aggregateStatistics a {@code SummaryStatistics} into which * values added to this statistics object should be aggregated */ - public AggregatingSummaryStatistics(SummaryStatistics aggregateStatistics) { + AggregatingSummaryStatistics(SummaryStatistics aggregateStatistics) { this.aggregateStatistics = aggregateStatistics; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FirstMoment.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FirstMoment.java b/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FirstMoment.java index a1eb340..50b107f 100644 --- a/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FirstMoment.java +++ b/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FirstMoment.java @@ -75,7 +75,7 @@ class FirstMoment extends AbstractStorelessUnivariateStatistic /** * Create a FirstMoment instance */ - public FirstMoment() { + FirstMoment() { n = 0; m1 = Double.NaN; dev = Double.NaN; @@ -89,7 +89,7 @@ class FirstMoment extends AbstractStorelessUnivariateStatistic * @param original the {@code FirstMoment} instance to copy * @throws NullArgumentException if original is null */ - public FirstMoment(FirstMoment original) throws NullArgumentException { + FirstMoment(FirstMoment original) throws NullArgumentException { super(); copy(original, this); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FourthMoment.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FourthMoment.java b/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FourthMoment.java index d005762..88e373e 100644 --- a/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FourthMoment.java +++ b/src/main/java/org/apache/commons/math4/stat/descriptive/moment/FourthMoment.java @@ -64,7 +64,7 @@ class FourthMoment extends ThirdMoment implements Serializable{ /** * Create a FourthMoment instance */ - public FourthMoment() { + FourthMoment() { super(); m4 = Double.NaN; } @@ -76,7 +76,7 @@ class FourthMoment extends ThirdMoment implements Serializable{ * @param original the {@code FourthMoment} instance to copy * @throws NullArgumentException if original is null */ - public FourthMoment(FourthMoment original) throws NullArgumentException { + FourthMoment(FourthMoment original) throws NullArgumentException { super(); copy(original, this); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/descriptive/moment/ThirdMoment.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/descriptive/moment/ThirdMoment.java b/src/main/java/org/apache/commons/math4/stat/descriptive/moment/ThirdMoment.java index b26b77f..96dc802 100644 --- a/src/main/java/org/apache/commons/math4/stat/descriptive/moment/ThirdMoment.java +++ b/src/main/java/org/apache/commons/math4/stat/descriptive/moment/ThirdMoment.java @@ -66,7 +66,7 @@ class ThirdMoment extends SecondMoment implements Serializable { /** * Create a FourthMoment instance. */ - public ThirdMoment() { + ThirdMoment() { super(); m3 = Double.NaN; nDevSq = Double.NaN; @@ -79,7 +79,7 @@ class ThirdMoment extends SecondMoment implements Serializable { * @param original the {@code ThirdMoment} instance to copy * @throws NullArgumentException if original is null */ - public ThirdMoment(ThirdMoment original) throws NullArgumentException { + ThirdMoment(ThirdMoment original) throws NullArgumentException { copy(original, this); } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/descriptive/rank/PSquarePercentile.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/descriptive/rank/PSquarePercentile.java b/src/main/java/org/apache/commons/math4/stat/descriptive/rank/PSquarePercentile.java index 097b8fd..34d8b60 100644 --- a/src/main/java/org/apache/commons/math4/stat/descriptive/rank/PSquarePercentile.java +++ b/src/main/java/org/apache/commons/math4/stat/descriptive/rank/PSquarePercentile.java @@ -894,7 +894,7 @@ public class PSquarePercentile extends AbstractStorelessUnivariateStatistic * * @param fixedCapacity the capacity to be fixed for this list */ - public FixedCapacityList(final int fixedCapacity) { + FixedCapacityList(final int fixedCapacity) { super(fixedCapacity); this.capacity = fixedCapacity; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/descriptive/rank/Percentile.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/descriptive/rank/Percentile.java b/src/main/java/org/apache/commons/math4/stat/descriptive/rank/Percentile.java index f820437..23d1a8e 100644 --- a/src/main/java/org/apache/commons/math4/stat/descriptive/rank/Percentile.java +++ b/src/main/java/org/apache/commons/math4/stat/descriptive/rank/Percentile.java @@ -669,7 +669,7 @@ public class Percentile extends AbstractUnivariateStatistic implements Serializa * R-Manual </a></li> * </ol> */ - public static enum EstimationType { + public enum EstimationType { /** * This is the default type used in the {@link Percentile}.This method * has the following formulae for index and estimates<br> @@ -928,7 +928,7 @@ public class Percentile extends AbstractUnivariateStatistic implements Serializa * * @param type name of estimation type as per wikipedia */ - private EstimationType(final String type) { + EstimationType(final String type) { this.name = type; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/stat/ranking/NaturalRanking.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/ranking/NaturalRanking.java b/src/main/java/org/apache/commons/math4/stat/ranking/NaturalRanking.java index 83b8c8f..d6efc09 100644 --- a/src/main/java/org/apache/commons/math4/stat/ranking/NaturalRanking.java +++ b/src/main/java/org/apache/commons/math4/stat/ranking/NaturalRanking.java @@ -438,7 +438,7 @@ public class NaturalRanking implements RankingAlgorithm { * @param value the value of the pair * @param position the original position */ - public IntDoublePair(double value, int position) { + IntDoublePair(double value, int position) { this.value = value; this.position = position; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/transform/FastFourierTransformer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/transform/FastFourierTransformer.java b/src/main/java/org/apache/commons/math4/transform/FastFourierTransformer.java index b829367..5f3f8c3 100644 --- a/src/main/java/org/apache/commons/math4/transform/FastFourierTransformer.java +++ b/src/main/java/org/apache/commons/math4/transform/FastFourierTransformer.java @@ -516,8 +516,7 @@ public class FastFourierTransformer implements Serializable { * @param multiDimensionalComplexArray array containing the matrix * elements */ - public MultiDimensionalComplexMatrix( - Object multiDimensionalComplexArray) { + MultiDimensionalComplexMatrix(Object multiDimensionalComplexArray) { this.multiDimensionalComplexArray = multiDimensionalComplexArray; http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/util/Combinations.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/util/Combinations.java b/src/main/java/org/apache/commons/math4/util/Combinations.java index 372bd17..d88a393 100644 --- a/src/main/java/org/apache/commons/math4/util/Combinations.java +++ b/src/main/java/org/apache/commons/math4/util/Combinations.java @@ -45,7 +45,7 @@ public class Combinations implements Iterable<int[]> { * Describes the type of iteration performed by the * {@link #iterator() iterator}. */ - private static enum IterationOrder { + private enum IterationOrder { /** Lexicographic order. */ LEXICOGRAPHIC } @@ -205,7 +205,7 @@ public class Combinations implements Iterable<int[]> { * @param n size of the set from which subsets are enumerated * @param k size of the subsets to enumerate */ - public LexicographicIterator(int n, int k) { + LexicographicIterator(int n, int k) { this.k = k; c = new int[k + 3]; if (k == 0 || k >= n) { @@ -302,7 +302,7 @@ public class Combinations implements Iterable<int[]> { * Create a singleton iterator providing the given array. * @param singleton array returned by the iterator */ - public SingletonIterator(final int[] singleton) { + SingletonIterator(final int[] singleton) { this.singleton = singleton; } /** @return True until next is called the first time, then false */ @@ -344,8 +344,7 @@ public class Combinations implements Iterable<int[]> { * @param n Size of the set from which subsets are selected. * @param k Size of the subsets to be enumerated. */ - public LexicographicComparator(int n, - int k) { + LexicographicComparator(int n, int k) { this.n = n; this.k = k; } http://git-wip-us.apache.org/repos/asf/commons-math/blob/bf7e9d50/src/main/java/org/apache/commons/math4/util/FastMath.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/util/FastMath.java b/src/main/java/org/apache/commons/math4/util/FastMath.java index fed5f53..12368a5 100644 --- a/src/main/java/org/apache/commons/math4/util/FastMath.java +++ b/src/main/java/org/apache/commons/math4/util/FastMath.java @@ -1655,7 +1655,7 @@ public class FastMath { /** Simple constructor. * @param x number to split */ - public Split(final double x) { + Split(final double x) { full = x; high = Double.longBitsToDouble(Double.doubleToRawLongBits(x) & ((-1L) << 27)); low = x - high; @@ -1665,7 +1665,7 @@ public class FastMath { * @param high high order bits * @param low low order bits */ - public Split(final double high, final double low) { + Split(final double high, final double low) { this(high == 0.0 ? (low == 0.0 && Double.doubleToRawLongBits(high) == Long.MIN_VALUE /* negative zero */ ? -0.0 : low) : high + low, high, low); } @@ -1674,7 +1674,7 @@ public class FastMath { * @param high high order bits * @param low low order bits */ - public Split(final double full, final double high, final double low) { + Split(final double full, final double high, final double low) { this.full = full; this.high = high; this.low = low;
