Author: mbenson
Date: Tue Dec 15 01:36:16 2015
New Revision: 1720059
URL: http://svn.apache.org/viewvc?rev=1720059&view=rev
Log:
pmd
Modified:
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/ActionGenerator.java
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/BlueprintingVisitor.java
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/InlineNestedPrivilegedCalls.java
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/Privilizer.java
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizerCleaner.java
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizingVisitor.java
Modified:
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/ActionGenerator.java
URL:
http://svn.apache.org/viewvc/commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/ActionGenerator.java?rev=1720059&r1=1720058&r2=1720059&view=diff
==============================================================================
---
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/ActionGenerator.java
(original)
+++
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/ActionGenerator.java
Tue Dec 15 01:36:16 2015
@@ -104,6 +104,7 @@ class ActionGenerator extends Privilizer
return buf.append("_ACTION").toString();
}
+ @SuppressWarnings("PMD.UseVarargs") //not needed
private static Field[] fields(final Type[] args) {
final Field[] result = new Field[args.length];
Modified:
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/BlueprintingVisitor.java
URL:
http://svn.apache.org/viewvc/commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/BlueprintingVisitor.java?rev=1720059&r1=1720058&r2=1720059&view=diff
==============================================================================
---
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/BlueprintingVisitor.java
(original)
+++
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/BlueprintingVisitor.java
Tue Dec 15 01:36:16 2015
@@ -133,6 +133,7 @@ class BlueprintingVisitor extends Privil
}
@Override
+ @SuppressWarnings("PMD.UseVarargs") //overridden method
public void visit(final int version, final int access, final String name,
final String signature,
final String superName, final String[] interfaces) {
Validate.isTrue(!blueprintTypes.contains(Type.getObjectType(name)),
@@ -141,6 +142,7 @@ class BlueprintingVisitor extends Privil
}
@Override
+ @SuppressWarnings("PMD.UseVarargs") //overridden method
public MethodVisitor visitMethod(final int access, final String name,
final String desc, final String signature,
final String[] exceptions) {
final MethodVisitor toWrap = super.visitMethod(access, name, desc,
signature, exceptions);
@@ -219,6 +221,7 @@ class BlueprintingVisitor extends Privil
bytecode =
privilizer().env.getClassfile(next.getValue().getInternalName()).getInputStream();
new ClassReader(bytecode).accept(privilizer().new
PrivilizerClassVisitor() {
@Override
+ @SuppressWarnings("PMD.UseVarargs") //overridden
method
public void visit(final int version, final int
access, final String name,
final String signature, final String
superName, final String[] interfaces) {
super.visit(version, access, name, signature,
superName, interfaces);
Modified:
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/InlineNestedPrivilegedCalls.java
URL:
http://svn.apache.org/viewvc/commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/InlineNestedPrivilegedCalls.java?rev=1720059&r1=1720058&r2=1720059&view=diff
==============================================================================
---
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/InlineNestedPrivilegedCalls.java
(original)
+++
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/InlineNestedPrivilegedCalls.java
Tue Dec 15 01:36:16 2015
@@ -63,6 +63,7 @@ class InlineNestedPrivilegedCalls extend
}
@Override
+ @SuppressWarnings("PMD.UseVarargs") //overridden method
public MethodVisitor visitMethod(final int access, final String name,
final String desc,
final String signature, final String[] exceptions) {
final Method outer = new Method(name, desc);
Modified:
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/Privilizer.java
URL:
http://svn.apache.org/viewvc/commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/Privilizer.java?rev=1720059&r1=1720058&r2=1720059&view=diff
==============================================================================
---
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/Privilizer.java
(original)
+++
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/Privilizer.java
Tue Dec 15 01:36:16 2015
@@ -65,6 +65,7 @@ public class Privilizer {
}
@Override
+ @SuppressWarnings("PMD.UseVarargs") //overridden method
public void visit(final int version, final int access, final String
name, final String signature,
final String superName, final String[] interfaces) {
super.visit(version, access, name, signature, superName,
interfaces);
Modified:
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizerCleaner.java
URL:
http://svn.apache.org/viewvc/commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizerCleaner.java?rev=1720059&r1=1720058&r2=1720059&view=diff
==============================================================================
---
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizerCleaner.java
(original)
+++
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizerCleaner.java
Tue Dec 15 01:36:16 2015
@@ -62,6 +62,7 @@ public class PrivilizerCleaner implement
final ClassReader classReader = new ClassReader(bytecode);
classReader.accept(new ClassVisitor(Opcodes.ASM5) {
@Override
+ @SuppressWarnings("PMD.UseVarargs") //overridden method
public void visit(final int version, final int access,
final String name, final String signature,
final String superName, final String[] interfaces) {
toDelete.add(name);
Modified:
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizingVisitor.java
URL:
http://svn.apache.org/viewvc/commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizingVisitor.java?rev=1720059&r1=1720058&r2=1720059&view=diff
==============================================================================
---
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizingVisitor.java
(original)
+++
commons/proper/weaver/trunk/modules/privilizer/weaver/src/main/java/org/apache/commons/weaver/privilizer/PrivilizingVisitor.java
Tue Dec 15 01:36:16 2015
@@ -85,6 +85,7 @@ class PrivilizingVisitor extends Privili
}
@Override
+ @SuppressWarnings("PMD.UseVarargs") //overridden method
public MethodVisitor visitMethod(final int access, final String name,
final String desc, final String signature,
final String[] exceptions) {
annotate();
