Author: britter
Date: Thu Aug 18 13:45:04 2016
New Revision: 1756783
URL: http://svn.apache.org/viewvc?rev=1756783&view=rev
Log:
VALIDATOR-401: IBANValidator fails for Seychelles and Ukraine. Thanks to Björn
Raupach for reporting this issue.
Modified:
commons/proper/validator/trunk/src/changes/changes.xml
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java
Modified: commons/proper/validator/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/changes/changes.xml?rev=1756783&r1=1756782&r2=1756783&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/changes/changes.xml (original)
+++ commons/proper/validator/trunk/src/changes/changes.xml Thu Aug 18 13:45:04
2016
@@ -64,8 +64,10 @@ The <action> type attribute can be add,u
-->
<body>
- <release version="1.5.2" date="TBA" description="
- ">
+ <release version="1.5.2" date="TBA" description="">
+ <action issue="VALIDATOR-401" type="fix" dev="britter">
+ IBANValidator fails for Seychelles and Ukraine
+ </action>
<action issue="VALIDATOR-391" type="fix" dev="sebb" due-to="Mark E. Scott,
Jr. & Jason Loomis">
UrlValidator.isValid throws exception for FILEURLs
Fixed code so it handles URLs with no authority field
Modified:
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java?rev=1756783&r1=1756782&r2=1756783&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java
(original)
+++
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java
Thu Aug 18 13:45:04 2016
@@ -153,6 +153,7 @@ public class IBANValidator {
new Validator("ST", 25, "ST\\d{23}" ),
// Sao Tome And Principe
new Validator("SA", 24, "SA\\d{4}[A-Z0-9]{18}" ),
// Saudi Arabia
new Validator("RS", 22, "RS\\d{20}" ),
// Serbia
+ new Validator("SC", 31, "SC\\d{2}[A-Z]{4}\\d{20}[A-Z]{3}" ),
// Seychelles
new Validator("SK", 24, "SK\\d{22}" ),
// Slovak Republic
new Validator("SI", 19, "SI\\d{17}" ),
// Slovenia
new Validator("ES", 24, "ES\\d{22}" ),
// Spain
@@ -161,6 +162,7 @@ public class IBANValidator {
new Validator("TL", 23, "TL\\d{21}" ),
// Timor-Leste
new Validator("TN", 24, "TN59\\d{20}" ),
// Tunisia
new Validator("TR", 26, "TR\\d{8}[A-Z0-9]{16}" ),
// Turkey
+ new Validator("UA", 29, "UA\\d{8}[A-Z0-9]{19}" ),
// Ukraine
new Validator("AE", 23, "AE\\d{21}" ),
// United Arab Emirates
new Validator("GB", 22, "GB\\d{2}[A-Z]{4}\\d{14}" ),
// United Kingdom
new Validator("VG", 24, "VG\\d{2}[A-Z]{4}\\d{16}" ),
// Virgin Islands, British
Modified:
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java?rev=1756783&r1=1756782&r2=1756783&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java
(original)
+++
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java
Thu Aug 18 13:45:04 2016
@@ -107,7 +107,9 @@ public class IBANValidatorTest {
"AE070331234567890123456",
"GB29NWBK60161331926819",
"VG96VPVG0000012345678901",
- };
+ "SC18SSCB11010000000000001497USD",
+ "UA213996220000026007233566001"
+ };
private final String[] invalidIBANFormat = new String[] {
"", // empty
