Author: sebb
Date: Sun Oct 9 12:00:14 2016
New Revision: 1763962
URL: http://svn.apache.org/viewvc?rev=1763962&view=rev
Log:
Doc notes
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App2Segment.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/BitParser.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunk.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIccp.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPlte.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/psd/PsdImageParser.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/icc/IccProfileInfo.java
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App2Segment.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App2Segment.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App2Segment.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App2Segment.java
Sun Oct 9 12:00:14 2016
@@ -84,7 +84,7 @@ public class App2Segment extends AppnSeg
* @return the iccBytes
*/
public byte[] getIccBytes() {
- return iccBytes;
+ return iccBytes; // TODO clone?
}
// public String getDescription()
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/BitParser.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/BitParser.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/BitParser.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/BitParser.java
Sun Oct 9 12:00:14 2016
@@ -24,7 +24,7 @@ class BitParser {
private final int bitDepth;
public BitParser(final byte[] bytes, final int bitsPerPixel, final int
bitDepth) {
- this.bytes = bytes;
+ this.bytes = bytes; // TODO clone?
this.bitsPerPixel = bitsPerPixel;
this.bitDepth = bitDepth;
}
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunk.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunk.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunk.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunk.java
Sun Oct 9 12:00:14 2016
@@ -36,7 +36,7 @@ public class PngChunk extends BinaryFile
this.length = length;
this.chunkType = chunkType;
this.crc = crc;
- this.bytes = bytes;
+ this.bytes = bytes; // TODO clone?
propertyBits = new boolean[4];
int shift = 24;
@@ -54,7 +54,7 @@ public class PngChunk extends BinaryFile
}
public byte[] getBytes() {
- return bytes;
+ return bytes; // TODO clone?
}
public boolean[] getPropertyBits() {
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIccp.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIccp.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIccp.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIccp.java
Sun Oct 9 12:00:14 2016
@@ -32,7 +32,7 @@ public class PngChunkIccp extends PngChu
private final byte[] uncompressedProfile;
public byte[] getUncompressedProfile() {
- return uncompressedProfile;
+ return uncompressedProfile; // TODO clone?
}
public PngChunkIccp(
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPlte.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPlte.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPlte.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPlte.java
Sun Oct 9 12:00:14 2016
@@ -54,7 +54,7 @@ public class PngChunkPlte extends PngChu
}
public int[] getRgb() {
- return rgb;
+ return rgb; // TODO clone? Is the method used?
}
public int getRGB(final int index) throws ImageReadException {
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
Sun Oct 9 12:00:14 2016
@@ -25,7 +25,7 @@ public abstract class TransparencyFilter
private final byte[] bytes;
public TransparencyFilter(final byte[] bytes) {
- this.bytes = bytes;
+ this.bytes = bytes; // TODO clone?
}
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/psd/PsdImageParser.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/psd/PsdImageParser.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/psd/PsdImageParser.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/psd/PsdImageParser.java
Sun Oct 9 12:00:14 2016
@@ -397,7 +397,7 @@ public class PsdImageParser extends Imag
if ((bytes == null) || (bytes.length < 1)) {
return null;
}
- return bytes;
+ return bytes; // TODO clone?
}
@Override
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/icc/IccProfileInfo.java
URL:
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/icc/IccProfileInfo.java?rev=1763962&r1=1763961&r2=1763962&view=diff
==============================================================================
---
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/icc/IccProfileInfo.java
(original)
+++
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/icc/IccProfileInfo.java
Sun Oct 9 12:00:14 2016
@@ -69,11 +69,11 @@ public class IccProfileInfo {
}
public byte[] getData() {
- return data;
+ return data; // TODO clone? does not appear to be used
}
public byte[] getProfileId() {
- return profileId;
+ return profileId; // TODO clone? does not appear to be used
}
public IccTag[] getTags() {
