svn commit: r1764298 - in /commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats: ico/IcoRoundtripTest.java png/PhysicalScaleTest.java png/chunks/PngChunkScalTest.java

[sebb]

Author: sebb
Date: Tue Oct 11 16:44:36 2016
New Revision: 1764298

URL: http://svn.apache.org/viewvc?rev=1764298&view=rev
Log:
Items should be static (Findbugs)

Modified:
    
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/ico/IcoRoundtripTest.java
    
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PhysicalScaleTest.java
    
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScalTest.java

Modified: 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/ico/IcoRoundtripTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/ico/IcoRoundtripTest.java?rev=1764298&r1=1764297&r2=1764298&view=diff
==============================================================================
--- 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/ico/IcoRoundtripTest.java
 (original)
+++ 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/ico/IcoRoundtripTest.java
 Tue Oct 11 16:44:36 2016
@@ -73,7 +73,7 @@ public class IcoRoundtripTest extends Ic
                 throws IOException, ImageWriteException;
     }
 
-    private class GeneratorFor1BitBitmaps implements BitmapGenerator {
+    private static class GeneratorFor1BitBitmaps implements BitmapGenerator {
         @Override
         public byte[] generateBitmap(final int foreground, final int 
background,
  final int paletteSize)
@@ -114,7 +114,7 @@ public class IcoRoundtripTest extends Ic
         }
     }
 
-    private class GeneratorFor4BitBitmaps implements BitmapGenerator {
+    private static class GeneratorFor4BitBitmaps implements BitmapGenerator {
         @Override
         public byte[] generateBitmap(final int foreground, final int 
background, final int paletteSize)
                 throws IOException, ImageWriteException {
@@ -148,7 +148,7 @@ public class IcoRoundtripTest extends Ic
         }
     }
 
-    private class GeneratorFor8BitBitmaps implements BitmapGenerator {
+    private static class GeneratorFor8BitBitmaps implements BitmapGenerator {
         @Override
         public byte[] generateBitmap(final int foreground, final int 
background, final int paletteSize)
                 throws IOException, ImageWriteException {
@@ -182,7 +182,7 @@ public class IcoRoundtripTest extends Ic
         }
     }
 
-    private class GeneratorFor16BitBitmaps implements BitmapGenerator {
+    private static class GeneratorFor16BitBitmaps implements BitmapGenerator {
         @Override
         public byte[] generateBitmap(final int foreground, final int 
background,
  final int paletteSize)
@@ -219,7 +219,7 @@ public class IcoRoundtripTest extends Ic
         }
     }
 
-    private class GeneratorFor24BitBitmaps implements BitmapGenerator {
+    private static class GeneratorFor24BitBitmaps implements BitmapGenerator {
         @Override
         public byte[] generateBitmap(final int foreground, final int 
background, final int paletteSize)
                 throws IOException, ImageWriteException {
@@ -253,7 +253,7 @@ public class IcoRoundtripTest extends Ic
         }
     }
 
-    private class GeneratorFor32BitBitmaps implements BitmapGenerator {
+    private static class GeneratorFor32BitBitmaps implements BitmapGenerator {
         @Override
         public byte[] generateBitmap(final int foreground, final int 
background,
                 final int paletteSize) throws IOException, ImageWriteException 
{

Modified: 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PhysicalScaleTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PhysicalScaleTest.java?rev=1764298&r1=1764297&r2=1764298&view=diff
==============================================================================
--- 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PhysicalScaleTest.java
 (original)
+++ 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PhysicalScaleTest.java
 Tue Oct 11 16:44:36 2016
@@ -23,7 +23,7 @@ import static org.junit.Assert.assertFal
 import static org.junit.Assert.assertTrue;
 
 public class PhysicalScaleTest {
-   private final double delta = 0.01;
+   private static final double delta = 0.01;
 
    @Test
    public void createFromMeters() {

Modified: 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScalTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScalTest.java?rev=1764298&r1=1764297&r2=1764298&view=diff
==============================================================================
--- 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScalTest.java
 (original)
+++ 
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScalTest.java
 Tue Oct 11 16:44:36 2016
@@ -24,8 +24,8 @@ import java.io.IOException;
 import static org.junit.Assert.assertEquals;
 
 public class PngChunkScalTest {
-   private final double delta = 0.001;
-   private final int chunkType = 1933787468;
+   private static final double delta = 0.001;
+   private static final int chunkType = 1933787468;
 
    @Test
    public void testConstructMeters() throws IOException, ImageReadException {