Repository: commons-compress Updated Branches: refs/heads/master f4b675664 -> acab253ab
Avoid some resource leak warnings Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/acab253a Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/acab253a Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/acab253a Branch: refs/heads/master Commit: acab253ab45dfa7b6b80dbec9f3623969c4a57a5 Parents: f4b6756 Author: Sebb <[email protected]> Authored: Mon Feb 27 23:28:34 2017 +0000 Committer: Sebb <[email protected]> Committed: Mon Feb 27 23:28:34 2017 +0000 ---------------------------------------------------------------------- .../compress/archivers/dump/DumpArchiveInputStreamTest.java | 4 ++-- .../apache/commons/compress/archivers/sevenz/SevenZFileTest.java | 2 +- .../commons/compress/archivers/zip/Maven221MultiVolumeTest.java | 3 ++- .../compressors/bzip2/BZip2CompressorInputStreamTest.java | 3 ++- 4 files changed, 7 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-compress/blob/acab253a/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java b/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java index 0875913..a3b6764 100644 --- a/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java +++ b/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java @@ -32,7 +32,7 @@ public class DumpArchiveInputStreamTest extends AbstractTestCase { @Test public void testNotADumpArchive() throws Exception { try (FileInputStream is = new FileInputStream(getFile("bla.zip"))) { - new DumpArchiveInputStream(is); + new DumpArchiveInputStream(is).close(); fail("expected an exception"); } catch (final ArchiveException ex) { // expected @@ -43,7 +43,7 @@ public class DumpArchiveInputStreamTest extends AbstractTestCase { @Test public void testNotADumpArchiveButBigEnough() throws Exception { try (FileInputStream is = new FileInputStream(getFile("zip64support.tar.bz2"))) { - new DumpArchiveInputStream(is); + new DumpArchiveInputStream(is).close(); fail("expected an exception"); } catch (final ArchiveException ex) { // expected http://git-wip-us.apache.org/repos/asf/commons-compress/blob/acab253a/src/test/java/org/apache/commons/compress/archivers/sevenz/SevenZFileTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/compress/archivers/sevenz/SevenZFileTest.java b/src/test/java/org/apache/commons/compress/archivers/sevenz/SevenZFileTest.java index c9c596f..94147d9 100644 --- a/src/test/java/org/apache/commons/compress/archivers/sevenz/SevenZFileTest.java +++ b/src/test/java/org/apache/commons/compress/archivers/sevenz/SevenZFileTest.java @@ -146,7 +146,7 @@ public class SevenZFileTest extends AbstractTestCase { @Test public void testEncryptedArchiveRequiresPassword() throws Exception { try { - new SevenZFile(getFile("bla.encrypted.7z")); + new SevenZFile(getFile("bla.encrypted.7z")).close(); fail("shouldn't decrypt without a password"); } catch (final PasswordRequiredException ex) { final String msg = ex.getMessage(); http://git-wip-us.apache.org/repos/asf/commons-compress/blob/acab253a/src/test/java/org/apache/commons/compress/archivers/zip/Maven221MultiVolumeTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/compress/archivers/zip/Maven221MultiVolumeTest.java b/src/test/java/org/apache/commons/compress/archivers/zip/Maven221MultiVolumeTest.java index eec6c8e..c28f3de 100644 --- a/src/test/java/org/apache/commons/compress/archivers/zip/Maven221MultiVolumeTest.java +++ b/src/test/java/org/apache/commons/compress/archivers/zip/Maven221MultiVolumeTest.java @@ -115,6 +115,7 @@ public class Maven221MultiVolumeTest { @Test(expected=IOException.class) public void testRead7ZipMultiVolumeArchiveForFile() throws IOException { final File file = getFile("apache-maven-2.2.1.zip.001"); - new ZipFile(file); + ZipFile zf = new ZipFile(file); + zf.close(); } } http://git-wip-us.apache.org/repos/asf/commons-compress/blob/acab253a/src/test/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStreamTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStreamTest.java b/src/test/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStreamTest.java index c045a7d..1d49102 100644 --- a/src/test/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStreamTest.java +++ b/src/test/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStreamTest.java @@ -32,7 +32,8 @@ public class BZip2CompressorInputStreamTest { @Test(expected = IOException.class) public void shouldThrowAnIOExceptionWhenAppliedToAZipFile() throws Exception { try (FileInputStream in = new FileInputStream(getFile("bla.zip"))) { - new BZip2CompressorInputStream(in); + BZip2CompressorInputStream bis = new BZip2CompressorInputStream(in); + bis.close(); } }
