Add final modifier to private fields. git-svn-id: https://svn.apache.org/repos/asf/commons/proper/imaging/trunk@1775887 13f79535-47bb-0310-9956-ffa450edef68
Project: http://git-wip-us.apache.org/repos/asf/commons-imaging/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-imaging/commit/b2325327 Tree: http://git-wip-us.apache.org/repos/asf/commons-imaging/tree/b2325327 Diff: http://git-wip-us.apache.org/repos/asf/commons-imaging/diff/b2325327 Branch: refs/heads/master Commit: b23253278ce0c42f83d7ea652a907f0e2cb8ff15 Parents: eb8be12 Author: Gary D. Gregory <[email protected]> Authored: Fri Dec 23 18:50:54 2016 +0000 Committer: Gary D. Gregory <[email protected]> Committed: Fri Dec 23 18:50:54 2016 +0000 ---------------------------------------------------------------------- .../java/org/apache/commons/imaging/formats/pnm/PbmWriter.java | 2 +- .../java/org/apache/commons/imaging/formats/pnm/PgmWriter.java | 2 +- .../java/org/apache/commons/imaging/formats/pnm/PpmWriter.java | 2 +- .../imaging/formats/psd/datareaders/CompressedDataReader.java | 2 +- .../imaging/formats/psd/datareaders/UncompressedDataReader.java | 2 +- .../java/org/apache/commons/imaging/common/RationalNumberTest.java | 2 +- .../commons/imaging/common/bytesource/ByteSourceDataTest.java | 2 +- .../commons/imaging/common/bytesource/ByteSourceImageTest.java | 2 +- .../java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java | 2 +- .../java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java | 2 +- .../java/org/apache/commons/imaging/formats/gif/GifReadTest.java | 2 +- .../java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java | 2 +- .../java/org/apache/commons/imaging/formats/ico/IcoReadTest.java | 2 +- .../java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java | 2 +- .../org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java | 2 +- .../java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java | 2 +- .../commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java | 2 +- .../imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java | 2 +- .../org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java | 2 +- .../org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java | 2 +- .../apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java | 2 +- .../apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java | 2 +- .../commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java | 2 +- 23 files changed, 23 insertions(+), 23 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/main/java/org/apache/commons/imaging/formats/pnm/PbmWriter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/imaging/formats/pnm/PbmWriter.java b/src/main/java/org/apache/commons/imaging/formats/pnm/PbmWriter.java index ae32866..088a038 100644 --- a/src/main/java/org/apache/commons/imaging/formats/pnm/PbmWriter.java +++ b/src/main/java/org/apache/commons/imaging/formats/pnm/PbmWriter.java @@ -25,7 +25,7 @@ import org.apache.commons.imaging.ImageWriteException; class PbmWriter implements PnmWriter { - private boolean rawbits; + private final boolean rawbits; PbmWriter(final boolean rawbits) { this.rawbits = rawbits; http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java b/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java index 9457c61..e46f672 100644 --- a/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java +++ b/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java @@ -25,7 +25,7 @@ import org.apache.commons.imaging.ImageWriteException; class PgmWriter implements PnmWriter { - private boolean rawbits; + private final boolean rawbits; public PgmWriter(boolean rawbits) { this.rawbits = rawbits; http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java b/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java index 3cf0a4d..ef54269 100644 --- a/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java +++ b/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java @@ -25,7 +25,7 @@ import org.apache.commons.imaging.ImageWriteException; class PpmWriter implements PnmWriter { - private boolean rawbits; + private final boolean rawbits; public PpmWriter(boolean rawbits) { this.rawbits = rawbits; http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/CompressedDataReader.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/CompressedDataReader.java b/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/CompressedDataReader.java index 6f9d46c..95d3054 100644 --- a/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/CompressedDataReader.java +++ b/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/CompressedDataReader.java @@ -34,7 +34,7 @@ import org.apache.commons.imaging.formats.psd.dataparsers.DataParser; public class CompressedDataReader implements DataReader { - private DataParser dataParser; + private final DataParser dataParser; public CompressedDataReader(final DataParser dataParser) { this.dataParser = dataParser; http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/UncompressedDataReader.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/UncompressedDataReader.java b/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/UncompressedDataReader.java index 048e926..6261656 100644 --- a/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/UncompressedDataReader.java +++ b/src/main/java/org/apache/commons/imaging/formats/psd/datareaders/UncompressedDataReader.java @@ -31,7 +31,7 @@ import org.apache.commons.imaging.formats.psd.dataparsers.DataParser; public class UncompressedDataReader implements DataReader { - private DataParser dataParser; + private final DataParser dataParser; public UncompressedDataReader(final DataParser dataParser) { this.dataParser = dataParser; http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java b/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java index e8555a0..c3d4d21 100644 --- a/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java +++ b/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java @@ -30,7 +30,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class RationalNumberTest extends ImagingTest { - private double testValue; + private final double testValue; @Parameterized.Parameters public static Collection<Double> data() { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java index 1070b65..f4fdddb 100644 --- a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java +++ b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java @@ -36,7 +36,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class ByteSourceDataTest extends ByteSourceTest { - private byte[] testByteArray; + private final byte[] testByteArray; @Parameterized.Parameters public static Collection<byte[]> data() { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java index 74ed42c..d296eca 100644 --- a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java +++ b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java @@ -47,7 +47,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class ByteSourceImageTest extends ByteSourceTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java b/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java index d17e3af..43c6348 100644 --- a/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java @@ -37,7 +37,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class BmpReadTest extends BmpBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java b/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java index bcddec6..8201880 100644 --- a/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java @@ -33,7 +33,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class DcxReadTest extends DcxBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java b/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java index 7bbd0a0..ae30b9e 100644 --- a/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java @@ -33,7 +33,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class GifReadTest extends GifBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java b/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java index c67568f..adcd6d1 100644 --- a/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java @@ -35,7 +35,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class IcnsReadTest extends IcnsBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java b/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java index f9470f3..3230894 100644 --- a/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java @@ -33,7 +33,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class IcoReadTest extends IcoBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java index 878aaeb..35754e7 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java @@ -39,7 +39,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class JpegReadTest extends JpegBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception{ http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java index 4f0e0e2..7fa78f9 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java @@ -38,7 +38,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class ExifDumpTest extends ExifBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java index f6d2af1..b2c34c7 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java @@ -34,7 +34,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class GpsTest extends ExifBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java index a40e389..728f81c 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java @@ -39,7 +39,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public abstract class SpecificExifTagTest extends ExifBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java index e01cd13..09f4664 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java @@ -29,7 +29,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class WriteExifMetadataExampleTest extends ExifBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java index 5af2d49..b467fc7 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java @@ -42,7 +42,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class IptcAddTest extends IptcBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java index dbd16ef..4e17f40 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java @@ -37,7 +37,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class IptcDumpTest extends IptcBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java index 0f3d70f..4f17c8d 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java @@ -44,7 +44,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class IptcUpdateTest extends IptcBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java index 74102a7..96e9c08 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java @@ -34,7 +34,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class JpegXmpDumpTest extends JpegXmpBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception { http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/b2325327/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java index 8ba41a7..74e0b42 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java @@ -39,7 +39,7 @@ import org.junit.runners.Parameterized; @RunWith(Parameterized.class) public class JpegXmpRewriteTest extends JpegXmpBaseTest { - private File imageFile; + private final File imageFile; @Parameterized.Parameters public static Collection<File> data() throws Exception {
