Local variable is redundant.
Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/f8e33e70 Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/f8e33e70 Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/f8e33e70 Branch: refs/heads/master Commit: f8e33e702ca0570076c58eaa7a83baeefece9553 Parents: f21a705 Author: shahab <[email protected]> Authored: Sun Jan 14 14:21:33 2018 -0500 Committer: Stefan Bodewig <[email protected]> Committed: Thu Jan 18 14:20:49 2018 +0100 ---------------------------------------------------------------------- .../java/org/apache/commons/compress/archivers/tar/TarUtils.java | 3 +-- .../compress/compressors/bzip2/BZip2CompressorInputStream.java | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-compress/blob/f8e33e70/src/main/java/org/apache/commons/compress/archivers/tar/TarUtils.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/compress/archivers/tar/TarUtils.java b/src/main/java/org/apache/commons/compress/archivers/tar/TarUtils.java index 9448cdc..171f44f 100644 --- a/src/main/java/org/apache/commons/compress/archivers/tar/TarUtils.java +++ b/src/main/java/org/apache/commons/compress/archivers/tar/TarUtils.java @@ -245,8 +245,7 @@ public class TarUtils { String string = new String(buffer, offset, length); string=string.replaceAll("\0", "{NUL}"); // Replace NULs to allow string to be printed - final String s = "Invalid byte "+currentByte+" at offset "+(current-offset)+" in '"+string+"' len="+length; - return s; + return "Invalid byte "+currentByte+" at offset "+(current-offset)+" in '"+string+"' len="+length; } /** http://git-wip-us.apache.org/repos/asf/commons-compress/blob/f8e33e70/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java b/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java index f053420..64a9007 100644 --- a/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java +++ b/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java @@ -178,8 +178,7 @@ public class BZip2CompressorInputStream extends CompressorInputStream implements count(1); } - final int c = (destOffs == offs) ? -1 : (destOffs - offs); - return c; + return (destOffs == offs) ? -1 : (destOffs - offs); } private void makeMaps() {
