Update PMD config.
Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/b01d0d1d Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/b01d0d1d Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/b01d0d1d Branch: refs/heads/master Commit: b01d0d1d4ce5b766172b1d7375a4319295e3ce45 Parents: 79db12a Author: Gilles <er...@apache.org> Authored: Thu Feb 22 12:00:21 2018 +0100 Committer: Gilles <er...@apache.org> Committed: Thu Feb 22 12:00:21 2018 +0100 ---------------------------------------------------------------------- pom.xml | 1 + src/main/resources/pmd/pmd-ruleset.xml | 56 +++++++++++++++-------------- 2 files changed, 30 insertions(+), 27 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-rng/blob/b01d0d1d/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 96b222a..421434f 100644 --- a/pom.xml +++ b/pom.xml @@ -361,6 +361,7 @@ <configuration> <targetJdk>${maven.compiler.target}</targetJdk> <skipEmptyReport>false</skipEmptyReport> + <analysisCache>true</analysisCache> <rulesets> <ruleset>${rng.parent.dir}/src/main/resources/pmd/pmd-ruleset.xml</ruleset> </rulesets> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/b01d0d1d/src/main/resources/pmd/pmd-ruleset.xml ---------------------------------------------------------------------- diff --git a/src/main/resources/pmd/pmd-ruleset.xml b/src/main/resources/pmd/pmd-ruleset.xml index c637ef7..0db1c6e 100644 --- a/src/main/resources/pmd/pmd-ruleset.xml +++ b/src/main/resources/pmd/pmd-ruleset.xml @@ -23,35 +23,37 @@ This ruleset checks the code for discouraged programming constructs. </description> - <rule ref="rulesets/java/basic.xml"/> - - <rule ref="rulesets/java/braces.xml"/> - - <rule ref="rulesets/java/comments.xml"> - <exclude name="CommentSize"/> + <rule ref="category/java/bestpractices.xml"> + <exclude name="UseVarargs" /> </rule> - <rule ref="rulesets/java/comments.xml/CommentSize"> - <properties> - <property name="maxLines" value="200"/> - <property name="maxLineLength" value="256"/> - </properties> + <rule ref="category/java/codestyle.xml"> + <exclude name="MethodArgumentCouldBeFinal" /> + <exclude name="ShortVariable" /> + <exclude name="LongVariable" /> + <exclude name="CommentDefaultAccessModifier" /> + <exclude name="DefaultPackage" /> + <exclude name="CallSuperInConstructor" /> + <exclude name="AbstractNaming" /> + <exclude name="UselessParentheses" /> + <exclude name="AtLeastOneConstructor" /> + <exclude name="GenericsNaming" /> </rule> - - <rule ref="rulesets/java/empty.xml"/> - - <rule ref="rulesets/java/finalizers.xml"/> - - <rule ref="rulesets/java/imports.xml"/> - - <rule ref="rulesets/java/typeresolution.xml"/> - - <rule ref="rulesets/java/clone.xml"/> - - <rule ref="rulesets/java/unnecessary.xml"> - <!-- We do use extra parentheses there as most people do not recall operator precedence, - this means even if the parentheses are useless for the compiler, we don't consider - them useless for the developer. This is the reason why we disable this rule. --> - <exclude name="UselessParentheses"/> + <rule ref="category/java/design.xml"> + <exclude name="TooManyMethods" /> + <exclude name="LawOfDemeter" /> + <exclude name="NcssCount" /> + </rule> + <rule ref="category/java/documentation.xml"> + <exclude name="CommentSize" /> + </rule> + <rule ref="category/java/errorprone.xml"> + <!-- <exclude name="..." /> --> + </rule> + <rule ref="category/java/multithreading.xml"> + <!-- <exclude name="..." /> --> + </rule> + <rule ref="category/java/performance.xml"> + <!-- <exclude name="..." /> --> </rule> </ruleset>