Author: ggregory
Date: Mon Jul 23 16:36:42 2018
New Revision: 1836505
URL: http://svn.apache.org/viewvc?rev=1836505&view=rev
Log:
Use final.
Modified:
commons/proper/vfs/trunk/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java
commons/proper/vfs/trunk/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/StandardFileSystemManager.java
commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/DefaultFileContentTest.java
Modified:
commons/proper/vfs/trunk/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java
URL:
http://svn.apache.org/viewvc/commons/proper/vfs/trunk/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java?rev=1836505&r1=1836504&r2=1836505&view=diff
==============================================================================
---
commons/proper/vfs/trunk/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java
(original)
+++
commons/proper/vfs/trunk/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java
Mon Jul 23 16:36:42 2018
@@ -116,17 +116,17 @@ public final class Shell {
}
}
- private void info(String[] cmd) throws Exception {
+ private void info(final String[] cmd) throws Exception {
if (cmd.length > 1) {
info(cmd[1]);
} else {
System.out.println(
"Default manager: \"" + mgr.getClass().getName() + "\" " +
"version " + getVersion(mgr.getClass()));
- String[] schemes = mgr.getSchemes();
- List<String> virtual = new ArrayList<>();
- List<String> physical = new ArrayList<>();
+ final String[] schemes = mgr.getSchemes();
+ final List<String> virtual = new ArrayList<>();
+ final List<String> physical = new ArrayList<>();
for (int i = 0; i < schemes.length; i++) {
- Collection<Capability> caps =
mgr.getProviderCapabilities(schemes[i]);
+ final Collection<Capability> caps =
mgr.getProviderCapabilities(schemes[i]);
if (caps != null) {
if (caps.contains(Capability.VIRTUAL) ||
caps.contains(Capability.COMPRESS)
|| caps.contains(Capability.DISPATCHER)) {
@@ -145,14 +145,14 @@ public final class Shell {
}
}
- private void info(String scheme) throws Exception {
+ private void info(final String scheme) throws Exception {
System.out.println("Provider Info for scheme \"" + scheme + "\":");
Collection<Capability> caps;
caps = mgr.getProviderCapabilities(scheme);
if (caps != null && !caps.isEmpty()) {
System.out.println(" capabilities: " + caps);
}
- FileOperationProvider[] ops = mgr.getOperationProviders(scheme);
+ final FileOperationProvider[] ops = mgr.getOperationProviders(scheme);
if (ops != null && ops.length > 0) {
System.out.println(" operations: " + ops);
}
@@ -334,10 +334,10 @@ public final class Shell {
return cmd.toArray(new String[cmd.size()]);
}
- private static String getVersion(Class<?> cls) {
+ private static String getVersion(final Class<?> cls) {
try {
return cls.getPackage().getImplementationVersion();
- } catch (Exception ignored) {
+ } catch (final Exception ignored) {
return "N/A";
}
}
Modified:
commons/proper/vfs/trunk/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/StandardFileSystemManager.java
URL:
http://svn.apache.org/viewvc/commons/proper/vfs/trunk/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/StandardFileSystemManager.java?rev=1836505&r1=1836504&r2=1836505&view=diff
==============================================================================
---
commons/proper/vfs/trunk/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/StandardFileSystemManager.java
(original)
+++
commons/proper/vfs/trunk/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/StandardFileSystemManager.java
Mon Jul 23 16:36:42 2018
@@ -139,7 +139,7 @@ public class StandardFileSystemManager e
if (classLoader != null) {
return classLoader;
}
- ClassLoader cl = Thread.currentThread().getContextClassLoader();
+ final ClassLoader cl = Thread.currentThread().getContextClassLoader();
if (cl != null) {
return cl;
}
Modified:
commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/DefaultFileContentTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/DefaultFileContentTest.java?rev=1836505&r1=1836504&r2=1836505&view=diff
==============================================================================
---
commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/DefaultFileContentTest.java
(original)
+++
commons/proper/vfs/trunk/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/DefaultFileContentTest.java
Mon Jul 23 16:36:42 2018
@@ -19,8 +19,8 @@ public class DefaultFileContentTest {
@Test
public void testMarkingWorks() throws Exception {
- File temp = File.createTempFile("temp-file-name", ".tmp");
- FileSystemManager fileSystemManager = VFS.getManager();
+ final File temp = File.createTempFile("temp-file-name", ".tmp");
+ final FileSystemManager fileSystemManager = VFS.getManager();
try (FileObject file =
fileSystemManager.resolveFile(temp.getAbsolutePath())) {
try (OutputStream outputStream =
file.getContent().getOutputStream()) {
@@ -31,7 +31,7 @@ public class DefaultFileContentTest {
if (stream.markSupported()) {
for (int i = 0; i < 10; i++) {
stream.mark(0);
- byte[] data = new byte[100];
+ final byte[] data = new byte[100];
stream.read(data, 0, 7);
Assert.assertEquals(expected, new String(data).trim());
stream.reset();
@@ -43,8 +43,8 @@ public class DefaultFileContentTest {
@Test
public void testMarkingWhenReadingEOS() throws Exception {
- File temp = File.createTempFile("temp-file-name", ".tmp");
- FileSystemManager fileSystemManager = VFS.getManager();
+ final File temp = File.createTempFile("temp-file-name", ".tmp");
+ final FileSystemManager fileSystemManager = VFS.getManager();
try (FileObject file =
fileSystemManager.resolveFile(temp.getAbsolutePath())) {
try (OutputStream outputStream =
file.getContent().getOutputStream()) {
@@ -56,7 +56,7 @@ public class DefaultFileContentTest {
if (stream.markSupported()) {
for (int i = 0; i < 10; i++) {
stream.mark(0);
- byte[] data = new byte[100];
+ final byte[] data = new byte[100];
readCount = stream.read(data, 0, 7);
Assert.assertEquals(readCount, 7);
Assert.assertEquals(expected, new String(data).trim());
