Repository: commons-imaging Updated Branches: refs/heads/master 778d3308d -> d2ec76bd1
Remove unused variables from test code Project: http://git-wip-us.apache.org/repos/asf/commons-imaging/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-imaging/commit/d2ec76bd Tree: http://git-wip-us.apache.org/repos/asf/commons-imaging/tree/d2ec76bd Diff: http://git-wip-us.apache.org/repos/asf/commons-imaging/diff/d2ec76bd Branch: refs/heads/master Commit: d2ec76bd10f30c39ae5180ede1254908e76045f0 Parents: 778d330 Author: Bruno P. Kinoshita <ki...@users.noreply.github.com> Authored: Sun Aug 12 10:41:05 2018 +1200 Committer: Bruno P. Kinoshita <ki...@users.noreply.github.com> Committed: Sun Aug 12 10:41:05 2018 +1200 ---------------------------------------------------------------------- .../commons/imaging/formats/jpeg/segments/JfifSegmentTest.java | 3 +-- .../commons/imaging/formats/png/chunks/PngChunkTextTest.java | 4 +--- .../imaging/formats/psd/dataparsers/DataParserIndexedTest.java | 4 +--- .../imaging/formats/tiff/taginfos/TagInfoUnknownTest.java | 2 +- 4 files changed, 4 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/d2ec76bd/src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java index 101d1f2..158f3bb 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java @@ -29,10 +29,9 @@ public class JfifSegmentTest{ @Test public void testCreatesJfifSegment() throws IOException { byte[] byteArray = new byte[25]; - JfifSegment jfifSegment = null; try { - jfifSegment = new JfifSegment((-2275), byteArray); + new JfifSegment((-2275), byteArray); fail("Expecting exception: Exception"); } catch(ImageReadException e) { assertEquals("Not a Valid JPEG File: missing JFIF string",e.getMessage()); http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/d2ec76bd/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkTextTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkTextTest.java b/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkTextTest.java index 8d9b454..fc8c4a5 100644 --- a/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkTextTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkTextTest.java @@ -26,10 +26,8 @@ public class PngChunkTextTest{ @Test public void testCreatesPngChunkText() { byte[] byteArray = new byte[0]; - PngChunkText pngChunkText = null; - try { - pngChunkText = new PngChunkText(1214, 1214, 0, byteArray); + new PngChunkText(1214, 1214, 0, byteArray); fail("Expecting exception: Exception"); } catch(Throwable e) { assertEquals("PNG tEXt chunk keyword is not terminated.",e.getMessage()); http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/d2ec76bd/src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexedTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexedTest.java b/src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexedTest.java index 2646323..f1c9693 100644 --- a/src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexedTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexedTest.java @@ -26,10 +26,8 @@ public class DataParserIndexedTest{ @Test public void testFailsToCreateDataParserIndexedThrowsArrayIndexOutOfBoundsException() { byte[] byteArray = new byte[24]; - DataParserIndexed dataParserIndexed = null; - try { - dataParserIndexed = new DataParserIndexed(byteArray); + new DataParserIndexed(byteArray); fail("Expecting exception: ArrayIndexOutOfBoundsException"); } catch(ArrayIndexOutOfBoundsException e) { assertEquals("256",e.getMessage()); http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/d2ec76bd/src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoUnknownTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoUnknownTest.java b/src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoUnknownTest.java index 8091f55..39a68d3 100644 --- a/src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoUnknownTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoUnknownTest.java @@ -26,7 +26,7 @@ public class TagInfoUnknownTest{ @Test public void testCreatesTagInfoUnknown() { TiffDirectoryType tiffDirectoryType = TiffDirectoryType.EXIF_DIRECTORY_EXIF_IFD; - TagInfoUnknown tagInfoUnknown = new TagInfoUnknown("", 2670, tiffDirectoryType); + new TagInfoUnknown("", 2670, tiffDirectoryType); assertEquals((-1), TagInfo.LENGTH_UNKNOWN); }
