This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git


The following commit(s) were added to refs/heads/master by this push:
     new 25a6612  Fix SpotBugs warning
25a6612 is described below

commit 25a6612b77692c0c2bb4a22c796b0fd8054331d1
Author: Mark Thomas <[email protected]>
AuthorDate: Fri May 3 18:43:12 2019 +0100

    Fix SpotBugs warning
---
 src/main/java/org/apache/commons/fileupload2/disk/DiskFileItem.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/src/main/java/org/apache/commons/fileupload2/disk/DiskFileItem.java 
b/src/main/java/org/apache/commons/fileupload2/disk/DiskFileItem.java
index 83587d1..6f57eb7 100644
--- a/src/main/java/org/apache/commons/fileupload2/disk/DiskFileItem.java
+++ b/src/main/java/org/apache/commons/fileupload2/disk/DiskFileItem.java
@@ -403,7 +403,10 @@ public class DiskFileItem
                  * desired file.
                  */
                 if (file.exists()) {
-                    file.delete();
+                    if (!file.delete()) {
+                        throw new FileUploadException(
+                                "Cannot write uploaded file to disk!");
+                    }
                 }
                 FileUtils.moveFile(outputFile, file);
             } else {

Reply via email to