This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit 91bd0711dcd4ff109dd51f5268aba989260898fb
Author: Steven Fontaine <[email protected]>
AuthorDate: Wed Sep 25 13:36:45 2019 -0500

    Prefer get methods over use of super
---
 .../main/java/org/apache/commons/geometry/euclidean/oned/Vector1D.java  | 2 +-
 .../java/org/apache/commons/geometry/euclidean/threed/Vector3D.java     | 2 +-
 .../main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/oned/Vector1D.java
 
b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/oned/Vector1D.java
index 56b0af0..4be9515 100644
--- 
a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/oned/Vector1D.java
+++ 
b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/oned/Vector1D.java
@@ -428,7 +428,7 @@ public class Vector1D extends EuclideanVector<Vector1D> {
         /** {@inheritDoc} */
         @Override
         public UnitVector negate() {
-            return new UnitVector(-super.x);
+            return new UnitVector(-getX());
         }
     }
 }
diff --git 
a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
 
b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
index 1ad050b..e0f86f3 100644
--- 
a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
+++ 
b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
@@ -641,7 +641,7 @@ public class Vector3D extends 
MultiDimensionalEuclideanVector<Vector3D> {
         /** {@inheritDoc} */
         @Override
         public UnitVector negate() {
-            return new UnitVector(-super.x, -super.y, -super.z);
+            return new UnitVector(-getX(), -getY(), -getZ());
         }
     }
 }
diff --git 
a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java
 
b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java
index 27eef71..1b7c797 100644
--- 
a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java
+++ 
b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java
@@ -575,7 +575,7 @@ public class Vector2D extends 
MultiDimensionalEuclideanVector<Vector2D> {
         /** {@inheritDoc} */
         @Override
         public UnitVector negate() {
-            return new UnitVector(-super.x, -super.y);
+            return new UnitVector(-getX(), -getY());
         }
     }
 }

Reply via email to