This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git


The following commit(s) were added to refs/heads/master by this push:
     new 0bdbd2f  [VFS-733] Parent layer of ZipFileSystem vanishes through 
OnCallRefreshFileObject.
0bdbd2f is described below

commit 0bdbd2f2037fdbf22cba71f8e28fbc8f054cf3e9
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Oct 6 09:10:46 2019 -0400

    [VFS-733] Parent layer of ZipFileSystem vanishes through
    OnCallRefreshFileObject.
    
    Fix compiler warnings.
---
 .../apache/commons/vfs2/provider/zip/Jira733TestCase.java | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git 
a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java
 
b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java
index 8a9aa42..b44754d 100644
--- 
a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java
+++ 
b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java
@@ -43,13 +43,14 @@ public class Jira733TestCase {
     public void testZipParentLayer() throws Exception {
         final File file = new File("src/test/resources/test-data/test.zip");
         final String nestedPath = "zip:" + file.getAbsolutePath() + 
"!/read-tests/file1.txt";
-        final FileObject zipFileObject = 
VFS.getManager().resolveFile(nestedPath);
-        final FileObject wrappedFileObject = new 
OnCallRefreshFileObject(zipFileObject);
-        // VFS.getManager().getFilesCache().close();
-        Assert.assertNotNull("getParentLayer() 1", 
wrappedFileObject.getFileSystem().getParentLayer());
-        wrappedFileObject.exists();
-        wrappedFileObject.getContent();
-        Assert.assertNotNull("getParentLayer() 2", 
wrappedFileObject.getFileSystem().getParentLayer());
+        try (final FileObject fileObject = 
VFS.getManager().resolveFile(nestedPath);
+                final FileObject wrappedFileObject = new 
OnCallRefreshFileObject(fileObject)) {
+            // VFS.getManager().getFilesCache().close();
+            Assert.assertNotNull("getParentLayer() 1", 
wrappedFileObject.getFileSystem().getParentLayer());
+            wrappedFileObject.exists();
+            wrappedFileObject.getContent();
+            Assert.assertNotNull("getParentLayer() 2", 
wrappedFileObject.getFileSystem().getParentLayer());
+        }
     }
 
     private void testZipParentLayer(final VfsConsumer<FileObject> consumer) 
throws Exception {

Reply via email to