[commons-lang] branch master updated: [LANG-1564] use Collections.singletonList insteadof Arrays.asList when there be only one element. (#549)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new f2d376a  [LANG-1564] use Collections.singletonList insteadof 
Arrays.asList when there be only one element. (#549)
f2d376a is described below

commit f2d376ae01d59cf89a87f0114e21f9a5d4bc4885
Author: XenoAmess <xenoam...@gmail.com>
AuthorDate: Sat Jun 13 22:57:51 2020 +0800

    [LANG-1564] use Collections.singletonList insteadof Arrays.asList when 
there be only one element. (#549)
    
    * asList
    
    * Update TypeUtilsTest.java
---
 .../apache/commons/lang3/text/translate/NumericEntityUnescaper.java   | 3 ++-
 src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java           | 4 ++--
 src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java     | 3 +--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
 
b/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
index b9da84a..e765825 100644
--- 
a/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
+++ 
b/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
@@ -19,6 +19,7 @@ package org.apache.commons.lang3.text.translate;
 import java.io.IOException;
 import java.io.Writer;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.EnumSet;
 
 /**
@@ -62,7 +63,7 @@ public class NumericEntityUnescaper extends 
CharSequenceTranslator {
         if (options.length > 0) {
             this.options = EnumSet.copyOf(Arrays.asList(options));
         } else {
-            this.options = 
EnumSet.copyOf(Arrays.asList(OPTION.semiColonRequired));
+            this.options = 
EnumSet.copyOf(Collections.singletonList(OPTION.semiColonRequired));
         }
     }
 
diff --git a/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java 
b/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
index 373f40c..aab3a4e 100644
--- a/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
@@ -243,10 +243,10 @@ public class ObjectUtilsTest {
 
     @Test
     public void testHashCodeMulti_multiple_likeList() {
-        final List<Object> list0 = new ArrayList<>(Arrays.asList());
+        final List<Object> list0 = new ArrayList<>(Collections.emptyList());
         assertEquals(list0.hashCode(), ObjectUtils.hashCodeMulti());
 
-        final List<Object> list1 = new ArrayList<>(Arrays.asList("a"));
+        final List<Object> list1 = new 
ArrayList<>(Collections.singletonList("a"));
         assertEquals(list1.hashCode(), ObjectUtils.hashCodeMulti("a"));
 
         final List<Object> list2 = new ArrayList<>(Arrays.asList("a", "b"));
diff --git a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java 
b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
index eeaaa8c..d029c08 100644
--- a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
@@ -32,7 +32,6 @@ import java.lang.reflect.TypeVariable;
 import java.lang.reflect.WildcardType;
 import java.net.URI;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -504,7 +503,7 @@ public class TypeUtilsTest<B> {
         assertEquals(Integer.class, typeVarAssigns.get(treeSetTypeVar),
                 "Type argument of Comparable from int: " + typeArg);
 
-        final Collection<Integer> col = Arrays.asList();
+        final Collection<Integer> col = Collections.emptyList();
         typeVarAssigns = TypeUtils.getTypeArguments(List.class, 
Collection.class);
         treeSetTypeVar = Comparable.class.getTypeParameters()[0];
         assertFalse(typeVarAssigns.containsKey(treeSetTypeVar),