This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 62032c2e5a2f08f622aa372860a1419af19528e0
Author: aherbert <[email protected]>
AuthorDate: Tue Jun 23 14:52:12 2020 +0100

    Increase BinomialDistribution test coverage.
---
 .../distribution/BinomialDistributionTest.java     | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git 
a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
 
b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
index c87721d..c1bab81 100644
--- 
a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
+++ 
b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
@@ -149,6 +149,21 @@ public class BinomialDistributionTest extends 
DiscreteDistributionAbstractTest {
     }
 
     @Test
+    public void testConstructorPrecondition1() {
+        Assertions.assertThrows(IllegalArgumentException.class, () -> new 
BinomialDistribution(-1, 0.1));
+    }
+
+    @Test
+    public void testConstructorPrecondition2() {
+        Assertions.assertThrows(IllegalArgumentException.class, () -> new 
BinomialDistribution(10, -0.1));
+    }
+
+    @Test
+    public void testConstructorPrecondition3() {
+        Assertions.assertThrows(IllegalArgumentException.class, () -> new 
BinomialDistribution(10, 1.1));
+    }
+
+    @Test
     public void testMoments() {
         final double tol = 1e-9;
         BinomialDistribution dist;
@@ -163,6 +178,22 @@ public class BinomialDistributionTest extends 
DiscreteDistributionAbstractTest {
     }
 
     @Test
+    public void testGetNumberOfTrials() {
+        for (final int n : new int[] {11, 42, 999}) {
+            final BinomialDistribution dist = new BinomialDistribution(n, 0.5);
+            Assertions.assertEquals(n, dist.getNumberOfTrials());
+        }
+    }
+
+    @Test
+    public void testGetProbabilityOfSuccess() {
+        for (final double p : new double[] {0.1, 0.456, 0.999}) {
+            final BinomialDistribution dist = new BinomialDistribution(10, p);
+            Assertions.assertEquals(p, dist.getProbabilityOfSuccess());
+        }
+    }
+
+    @Test
     public void testMath718() {
         // for large trials the evaluation of ContinuedFraction was inaccurate
         // do a sweep over several large trials to test if the current 
implementation is

Reply via email to