[commons-io] branch master updated: Abbreviate and only call readLine() once in the loop.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new 40256d9  Abbreviate and only call readLine() once in the loop.
40256d9 is described below

commit 40256d97e6370c72cfaaa84d7f11fabe0fd10598
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Thu Aug 20 17:43:39 2020 -0400

    Abbreviate and only call readLine() once in the loop.
---
 src/main/java/org/apache/commons/io/input/XmlStreamReader.java       | 5 ++---
 .../org/apache/commons/io/input/compatibility/XmlStreamReader.java   | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/apache/commons/io/input/XmlStreamReader.java 
b/src/main/java/org/apache/commons/io/input/XmlStreamReader.java
index 2ecc38e..2bf918f 100644
--- a/src/main/java/org/apache/commons/io/input/XmlStreamReader.java
+++ b/src/main/java/org/apache/commons/io/input/XmlStreamReader.java
@@ -735,10 +735,9 @@ public class XmlStreamReader extends Reader {
                 final BufferedReader bReader = new BufferedReader(new 
StringReader(
                         xmlProlog.substring(0, firstGT + 1)));
                 final StringBuffer prolog = new StringBuffer();
-                String line = bReader.readLine();
-                while (line != null) {
+                String line;
+                while ((line = bReader.readLine()) != null) {
                     prolog.append(line);
-                    line = bReader.readLine();
                 }
                 final Matcher m = ENCODING_PATTERN.matcher(prolog);
                 if (m.find()) {
diff --git 
a/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java 
b/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java
index 7e5adff..1f79ad8 100644
--- 
a/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java
+++ 
b/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java
@@ -691,10 +691,9 @@ public class XmlStreamReader extends Reader {
                 final BufferedReader bReader = new BufferedReader(new 
StringReader(
                         xmlProlog.substring(0, firstGT + 1)));
                 final StringBuffer prolog = new StringBuffer();
-                String line = bReader.readLine();
-                while (line != null) {
+                String line;
+                while ((line = bReader.readLine()) != null) {
                     prolog.append(line);
-                    line = bReader.readLine();
                 }
                 final Matcher m = ENCODING_PATTERN.matcher(prolog);
                 if (m.find()) {