This is an automated email from the ASF dual-hosted git repository.

mattjuntunen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit ef65dd7f71719866f1d16c56c3267981ff1117f6
Author: Matt Juntunen <[email protected]>
AuthorDate: Wed Dec 9 23:35:15 2020 -0500

    bumping pmd and spotbugs versions; using managed antrun version
---
 pom.xml                                            | 12 +++---
 .../resources/spotbugs/spotbugs-exclude-filter.xml | 50 +---------------------
 2 files changed, 8 insertions(+), 54 deletions(-)

diff --git a/pom.xml b/pom.xml
index 3f64fce..061600e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,16 +53,16 @@
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
     <geometry.pmd.version>3.13.0</geometry.pmd.version>
-    <geometry.pmd.dep.version>6.21.0</geometry.pmd.dep.version>
+    <geometry.pmd.dep.version>6.29.0</geometry.pmd.dep.version>
     <geometry.checkstyle.version>3.1.1</geometry.checkstyle.version>
     <geometry.checkstyle.dep.version>8.29</geometry.checkstyle.dep.version>
     <geometry.mathjax.version>2.7.2</geometry.mathjax.version>
     <!-- Workaround to avoid duplicating config files. -->
     <geometry.parent.dir>${basedir}</geometry.parent.dir>
 
-    <commons.spotbugs.version>3.1.12</commons.spotbugs.version>
+    <commons.spotbugs.version>4.1.4</commons.spotbugs.version>
     <!-- Required for Java 13 build -->
-    <commons.spotbugs.dep.version>4.0.0</commons.spotbugs.dep.version>
+    <commons.spotbugs.dep.version>4.2.0</commons.spotbugs.dep.version>
 
     <!-- Fix to avoid JXR 3.0.0 forking the lifecycle phase 'compile' during 
site report
        jxr:aggregate. If compile is forked, the dist-archive build fails when 
attempting
@@ -304,7 +304,7 @@
             
<ruleset>${geometry.parent.dir}/src/main/resources/pmd/pmd-ruleset.xml</ruleset>
           </rulesets>
           <excludeRoots>
-            <excludeRoot>target/generated-sources</excludeRoot>
+            <excludeRoot>target/generated-sources/annotations</excludeRoot>
           </excludeRoots>
         </configuration>
       </plugin>
@@ -446,6 +446,9 @@
           <rulesets>
             
<ruleset>${geometry.parent.dir}/src/main/resources/pmd/pmd-ruleset.xml</ruleset>
           </rulesets>
+          <excludeRoots>
+            <excludeRoot>target/generated-sources/annotations</excludeRoot>
+          </excludeRoots>
         </configuration>
         <reportSets>
           <reportSet>
@@ -509,7 +512,6 @@
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-antrun-plugin</artifactId>
-            <version>1.7</version>
             <executions>
               <execution>
                 <id>prepare-checkout</id>
diff --git a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml 
b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
index 31044d2..abff0bd 100644
--- a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
+++ b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -26,54 +26,6 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
     xsi:schemaLocation="https://github.com/spotbugs/filter/3.1.0 
https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd";>
 
-  <Class name="~.*\.jmh\.generated\..*" />
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.core.partitioning.bsp.AbstractRegionBSPTree"/>
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.euclidean.threed.RegionBSPTree3D$PartitionedRegionBuilder3D"
 />
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.euclidean.threed.BoundarySourceBoundsBuilder3D"
 />
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.euclidean.threed.BoundarySourceLinecaster3D" 
/>
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.euclidean.threed.mesh.SimpleTriangleMesh" />
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.euclidean.twod.RegionBSPTree2D$PartitionedRegionBuilder2D"
 />
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.euclidean.twod.BoundarySourceBoundsBuilder2D" 
/>
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-
-  <Match>
-    <!-- This is a false positive in JDK 11. See 
https://github.com/spotbugs/spotbugs/issues/756 -->
-    <Class 
name="org.apache.commons.geometry.euclidean.twod.BoundarySourceLinecaster2D" />
-    <BugPattern name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
+  <Class name="~.*\.jmh_generated\..*" />
 
 </FindBugsFilter>

Reply via email to