[commons-beanutils] branch master updated: Better NPE messages. Use String#isEmpty().

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git


The following commit(s) were added to refs/heads/master by this push:
     new 9d73f97  Better NPE messages. Use String#isEmpty().
9d73f97 is described below

commit 9d73f97660ae42874a3081679436ac5142000166
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Dec 31 11:25:53 2020 -0500

    Better NPE messages. Use String#isEmpty().
---
 .../org/apache/commons/beanutils2/converters/CharacterConverter.java    | 2 +-
 .../java/org/apache/commons/beanutils2/converters/URIConverter.java     | 2 +-
 .../java/org/apache/commons/beanutils2/converters/URLConverter.java     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/beanutils2/converters/CharacterConverter.java
 
b/src/main/java/org/apache/commons/beanutils2/converters/CharacterConverter.java
index caf55bd..4371b5d 100644
--- 
a/src/main/java/org/apache/commons/beanutils2/converters/CharacterConverter.java
+++ 
b/src/main/java/org/apache/commons/beanutils2/converters/CharacterConverter.java
@@ -67,7 +67,7 @@ public final class CharacterConverter extends 
AbstractConverter {
     @Override
     protected String convertToString(final Object value) {
         final String strValue = value.toString();
-        return strValue.length() == 0 ? "" : strValue.substring(0, 1);
+        return strValue.isEmpty() ? "" : strValue.substring(0, 1);
     }
 
     /**
diff --git 
a/src/main/java/org/apache/commons/beanutils2/converters/URIConverter.java 
b/src/main/java/org/apache/commons/beanutils2/converters/URIConverter.java
index 7223129..1bc4f1a 100644
--- a/src/main/java/org/apache/commons/beanutils2/converters/URIConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/converters/URIConverter.java
@@ -72,7 +72,7 @@ public final class URIConverter extends AbstractConverter {
     @Override
     protected <T> T convertToType(final Class<T> type, final Object value) 
throws Throwable {
         if (URI.class.equals(type)) {
-            return type.cast(new URI(value.toString()));
+            return type.cast(new URI(toString(value)));
         }
 
         throw conversionException(type, value);
diff --git 
a/src/main/java/org/apache/commons/beanutils2/converters/URLConverter.java 
b/src/main/java/org/apache/commons/beanutils2/converters/URLConverter.java
index 3dcf7c3..1c6b32b 100644
--- a/src/main/java/org/apache/commons/beanutils2/converters/URLConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/converters/URLConverter.java
@@ -72,7 +72,7 @@ public final class URLConverter extends AbstractConverter {
     @Override
     protected <T> T convertToType(final Class<T> type, final Object value) 
throws Throwable {
         if (URL.class.equals(type)) {
-            return type.cast(new URL(value.toString()));
+            return type.cast(new URL(toString(value)));
         }
 
         throw conversionException(type, value);