[commons-codec] branch master updated: Simplify array cloning.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 2a1fc6b  Simplify array cloning.
2a1fc6b is described below

commit 2a1fc6b85977f9aa34c4a26234b68f3e5edb8f72
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jan 2 18:23:18 2021 -0500

    Simplify array cloning.
---
 src/main/java/org/apache/commons/codec/binary/Base32.java           | 3 +--
 src/main/java/org/apache/commons/codec/binary/Base64.java           | 3 +--
 src/main/java/org/apache/commons/codec/language/RefinedSoundex.java | 3 +--
 src/main/java/org/apache/commons/codec/language/Soundex.java        | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/binary/Base32.java 
b/src/main/java/org/apache/commons/codec/binary/Base32.java
index 0b165c1..592b4ed 100644
--- a/src/main/java/org/apache/commons/codec/binary/Base32.java
+++ b/src/main/java/org/apache/commons/codec/binary/Base32.java
@@ -334,8 +334,7 @@ public class Base32 extends BaseNCodec {
                 throw new IllegalArgumentException("lineSeparator must not 
contain Base32 characters: [" + sep + "]");
             }
             this.encodeSize = BYTES_PER_ENCODED_BLOCK + lineSeparator.length;
-            this.lineSeparator = new byte[lineSeparator.length];
-            System.arraycopy(lineSeparator, 0, this.lineSeparator, 0, 
lineSeparator.length);
+            this.lineSeparator = lineSeparator.clone();
         } else {
             this.encodeSize = BYTES_PER_ENCODED_BLOCK;
             this.lineSeparator = null;
diff --git a/src/main/java/org/apache/commons/codec/binary/Base64.java 
b/src/main/java/org/apache/commons/codec/binary/Base64.java
index 476d079..d40b3d4 100644
--- a/src/main/java/org/apache/commons/codec/binary/Base64.java
+++ b/src/main/java/org/apache/commons/codec/binary/Base64.java
@@ -596,8 +596,7 @@ public class Base64 extends BaseNCodec {
             }
             if (lineLength > 0){ // null line-sep forces no chunking rather 
than throwing IAE
                 this.encodeSize = BYTES_PER_ENCODED_BLOCK + 
lineSeparator.length;
-                this.lineSeparator = new byte[lineSeparator.length];
-                System.arraycopy(lineSeparator, 0, this.lineSeparator, 0, 
lineSeparator.length);
+                this.lineSeparator = lineSeparator.clone();
             } else {
                 this.encodeSize = BYTES_PER_ENCODED_BLOCK;
                 this.lineSeparator = null;
diff --git 
a/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java 
b/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
index 317f0e0..54dcd74 100644
--- a/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
+++ b/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
@@ -87,8 +87,7 @@ public class RefinedSoundex implements StringEncoder {
      *                  a given character
      */
     public RefinedSoundex(final char[] mapping) {
-        this.soundexMapping = new char[mapping.length];
-        System.arraycopy(mapping, 0, this.soundexMapping, 0, mapping.length);
+        this.soundexMapping = mapping.clone();
     }
 
     /**
diff --git a/src/main/java/org/apache/commons/codec/language/Soundex.java 
b/src/main/java/org/apache/commons/codec/language/Soundex.java
index 6acdac2..c2106dd 100644
--- a/src/main/java/org/apache/commons/codec/language/Soundex.java
+++ b/src/main/java/org/apache/commons/codec/language/Soundex.java
@@ -150,8 +150,7 @@ public class Soundex implements StringEncoder {
      *                  Mapping array to use when finding the corresponding 
code for a given character
      */
     public Soundex(final char[] mapping) {
-        this.soundexMapping = new char[mapping.length];
-        System.arraycopy(mapping, 0, this.soundexMapping, 0, mapping.length);
+        this.soundexMapping = mapping.clone();
         this.specialCaseHW = !hasMarker(this.soundexMapping);
     }