[commons-digester] branch master updated: Simplify array cloning.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-digester.git


The following commit(s) were added to refs/heads/master by this push:
     new 368fba9  Simplify array cloning.
368fba9 is described below

commit 368fba9163d3b8ab1a0038945d2c0d7da1f23aa8
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jan 2 18:31:06 2021 -0500

    Simplify array cloning.
---
 .../main/java/org/apache/commons/digester3/CallMethodRule.java    | 6 ++----
 .../main/java/org/apache/commons/digester3/ObjectCreateRule.java  | 3 +--
 .../commons/digester3/annotations/reflect/MethodArgument.java     | 8 ++------
 3 files changed, 5 insertions(+), 12 deletions(-)

diff --git 
a/core/src/main/java/org/apache/commons/digester3/CallMethodRule.java 
b/core/src/main/java/org/apache/commons/digester3/CallMethodRule.java
index 4fae6d0..fff1dc0 100644
--- a/core/src/main/java/org/apache/commons/digester3/CallMethodRule.java
+++ b/core/src/main/java/org/apache/commons/digester3/CallMethodRule.java
@@ -196,8 +196,7 @@ public class CallMethodRule
         {
             // copy the parameter class names into an array
             // the classes will be loaded when the digester is set
-            this.paramClassNames = new String[paramTypes.length];
-            arraycopy( paramTypes, 0, this.paramClassNames, 0, 
paramTypes.length );
+            this.paramClassNames = paramTypes.clone();
         }
     }
 
@@ -243,8 +242,7 @@ public class CallMethodRule
         }
         else
         {
-            this.paramTypes = new Class<?>[paramTypes.length];
-            arraycopy( paramTypes, 0, this.paramTypes, 0, paramTypes.length );
+            this.paramTypes = paramTypes.clone();
         }
     }
 
diff --git 
a/core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java 
b/core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java
index 9226997..e8e78c2 100644
--- a/core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java
+++ b/core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java
@@ -138,8 +138,7 @@ public class ObjectCreateRule
 
         Object createProxy()
         {
-            final Object[] constructorArguments = new 
Object[templateConstructorArguments.length];
-            arraycopy( templateConstructorArguments, 0, constructorArguments, 
0, constructorArguments.length );
+            final Object[] constructorArguments = 
templateConstructorArguments.clone();
             digester.pushParams( constructorArguments );
 
             final DeferredConstructionCallback callback =
diff --git 
a/core/src/main/java/org/apache/commons/digester3/annotations/reflect/MethodArgument.java
 
b/core/src/main/java/org/apache/commons/digester3/annotations/reflect/MethodArgument.java
index b2547ba..109468f 100644
--- 
a/core/src/main/java/org/apache/commons/digester3/annotations/reflect/MethodArgument.java
+++ 
b/core/src/main/java/org/apache/commons/digester3/annotations/reflect/MethodArgument.java
@@ -68,9 +68,7 @@ public final class MethodArgument
 
         this.index = index;
         this.parameterType = parameterType;
-        this.annotations = new Annotation[annotations.length];
-
-        arraycopy( annotations, 0, this.annotations, 0, annotations.length );
+        this.annotations = annotations.clone();
     }
 
     /**
@@ -134,9 +132,7 @@ public final class MethodArgument
      */
     private Annotation[] getAnnotationsArrayCopy()
     {
-        final Annotation[] annotations = new 
Annotation[this.annotations.length];
-        System.arraycopy( this.annotations, 0, annotations, 0, 
annotations.length );
-        return annotations;
+        return this.annotations.clone();
     }
 
     /**