This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git

commit 9a65b47b2615102710306fe4320390cdd0c75e57
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Jan 2 19:45:57 2021 -0500

    Simplify array cloning.
---
 .../commons/mail/resolver/DataSourceCompositeResolver.java     | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/mail/resolver/DataSourceCompositeResolver.java
 
b/src/main/java/org/apache/commons/mail/resolver/DataSourceCompositeResolver.java
index a70f06e..ac78818 100644
--- 
a/src/main/java/org/apache/commons/mail/resolver/DataSourceCompositeResolver.java
+++ 
b/src/main/java/org/apache/commons/mail/resolver/DataSourceCompositeResolver.java
@@ -39,8 +39,7 @@ public class DataSourceCompositeResolver extends 
DataSourceBaseResolver
      */
     public DataSourceCompositeResolver(final DataSourceResolver[] 
dataSourceResolvers)
     {
-        this.dataSourceResolvers = new 
DataSourceResolver[dataSourceResolvers.length];
-        System.arraycopy(dataSourceResolvers, 0, this.dataSourceResolvers, 0, 
dataSourceResolvers.length);
+        this.dataSourceResolvers = dataSourceResolvers.clone();
     }
 
     /**
@@ -52,8 +51,7 @@ public class DataSourceCompositeResolver extends 
DataSourceBaseResolver
     public DataSourceCompositeResolver(final DataSourceResolver[] 
dataSourceResolvers, final boolean isLenient)
     {
         super(isLenient);
-        this.dataSourceResolvers = new 
DataSourceResolver[dataSourceResolvers.length];
-        System.arraycopy(dataSourceResolvers, 0, this.dataSourceResolvers, 0, 
dataSourceResolvers.length);
+        this.dataSourceResolvers = dataSourceResolvers.clone();
     }
 
     /**
@@ -64,9 +62,7 @@ public class DataSourceCompositeResolver extends 
DataSourceBaseResolver
     public DataSourceResolver[] getDataSourceResolvers()
     {
         // clone the internal array to prevent external modification (see 
EMAIL-116)
-        final DataSourceResolver[] resolvers = new 
DataSourceResolver[dataSourceResolvers.length];
-        System.arraycopy(dataSourceResolvers, 0, resolvers, 0, 
dataSourceResolvers.length);
-        return resolvers;
+        return dataSourceResolvers.clone();
     }
 
     /** {@inheritDoc} */

Reply via email to