[commons-net] branch master updated: Simplify array cloning.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git


The following commit(s) were added to refs/heads/master by this push:
     new 42e8dfb  Simplify array cloning.
42e8dfb is described below

commit 42e8dfb3bcd07c1275c80278f973fe4d8775267e
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jan 2 20:12:00 2021 -0500

    Simplify array cloning.
---
 src/main/java/org/apache/commons/net/ftp/FTPSClient.java   | 6 ++----
 src/main/java/org/apache/commons/net/imap/IMAPSClient.java | 6 ++----
 src/main/java/org/apache/commons/net/pop3/POP3SClient.java | 6 ++----
 src/main/java/org/apache/commons/net/smtp/SMTPSClient.java | 6 ++----
 4 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/src/main/java/org/apache/commons/net/ftp/FTPSClient.java 
b/src/main/java/org/apache/commons/net/ftp/FTPSClient.java
index cc77062..6c75f96 100644
--- a/src/main/java/org/apache/commons/net/ftp/FTPSClient.java
+++ b/src/main/java/org/apache/commons/net/ftp/FTPSClient.java
@@ -412,8 +412,7 @@ public class FTPSClient extends FTPClient {
      * @param cipherSuites The cipher suites.
      */
     public void setEnabledCipherSuites(final String[] cipherSuites) {
-        suites = new String[cipherSuites.length];
-        System.arraycopy(cipherSuites, 0, suites, 0, cipherSuites.length);
+        suites = cipherSuites.clone();
     }
 
     /**
@@ -435,8 +434,7 @@ public class FTPSClient extends FTPClient {
      * @param protocolVersions The protocol versions.
      */
     public void setEnabledProtocols(final String[] protocolVersions) {
-        protocols = new String[protocolVersions.length];
-        System.arraycopy(protocolVersions, 0, protocols, 0, 
protocolVersions.length);
+        protocols = protocolVersions.clone();
     }
 
     /**
diff --git a/src/main/java/org/apache/commons/net/imap/IMAPSClient.java 
b/src/main/java/org/apache/commons/net/imap/IMAPSClient.java
index 137c82b..fbf4113 100644
--- a/src/main/java/org/apache/commons/net/imap/IMAPSClient.java
+++ b/src/main/java/org/apache/commons/net/imap/IMAPSClient.java
@@ -267,8 +267,7 @@ public class IMAPSClient extends IMAPClient
      */
     public void setEnabledCipherSuites(final String[] cipherSuites)
     {
-        suites = new String[cipherSuites.length];
-        System.arraycopy(cipherSuites, 0, suites, 0, cipherSuites.length);
+        suites = cipherSuites.clone();
     }
 
     /**
@@ -293,8 +292,7 @@ public class IMAPSClient extends IMAPClient
      */
     public void setEnabledProtocols(final String[] protocolVersions)
     {
-        protocols = new String[protocolVersions.length];
-        System.arraycopy(protocolVersions, 0, protocols, 0, 
protocolVersions.length);
+        protocols = protocolVersions.clone();
     }
 
     /**
diff --git a/src/main/java/org/apache/commons/net/pop3/POP3SClient.java 
b/src/main/java/org/apache/commons/net/pop3/POP3SClient.java
index c85a912..024b196 100644
--- a/src/main/java/org/apache/commons/net/pop3/POP3SClient.java
+++ b/src/main/java/org/apache/commons/net/pop3/POP3SClient.java
@@ -264,8 +264,7 @@ public class POP3SClient extends POP3Client
      */
     public void setEnabledCipherSuites(final String[] cipherSuites)
     {
-        suites = new String[cipherSuites.length];
-        System.arraycopy(cipherSuites, 0, suites, 0, cipherSuites.length);
+        suites = cipherSuites.clone();
     }
 
     /**
@@ -290,8 +289,7 @@ public class POP3SClient extends POP3Client
      */
     public void setEnabledProtocols(final String[] protocolVersions)
     {
-        protocols = new String[protocolVersions.length];
-        System.arraycopy(protocolVersions, 0, protocols, 0, 
protocolVersions.length);
+        protocols = protocolVersions.clone();
     }
 
     /**
diff --git a/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java 
b/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
index 4a22cd5..255862e 100644
--- a/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
+++ b/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
@@ -265,8 +265,7 @@ public class SMTPSClient extends SMTPClient
      */
     public void setEnabledCipherSuites(final String[] cipherSuites)
     {
-        suites = new String[cipherSuites.length];
-        System.arraycopy(cipherSuites, 0, suites, 0, cipherSuites.length);
+        suites = cipherSuites.clone();
     }
 
     /**
@@ -291,8 +290,7 @@ public class SMTPSClient extends SMTPClient
      */
     public void setEnabledProtocols(final String[] protocolVersions)
     {
-        protocols = new String[protocolVersions.length];
-        System.arraycopy(protocolVersions, 0, protocols, 0, 
protocolVersions.length);
+        protocols = protocolVersions.clone();
     }
 
     /**